Re: [Notion-devel] Multihead: mod_xinerama and 'mirrored' multihead

[Arnout E. <no...@bz...>]

On Sun, Apr 10, 2011 at 09:47:19PM +0200, eb...@dr... wrote:
> First, it is not in Lua. This is not so bad for users, but it is bad for
> further developing, as further patches may want to improve this branch,
> and I consider this branch 'dead', because we want this in Lua.

I'm certainly not opposed to doing this in lua, though I don't have a
strong preference between doing it in C and doing it in Lua. Lua has some
nice syntax, otoh in C you have direct access to the C API's... both have
its advantages ;).

> The second objection is, that the algorithm does not merge screen B
> to screen A,C in following setup:
> (..)

You are, of course, entirely right.

> I reimplemented
> the merge of overlapping screens in Lua, so that it merges all screens
> that overlap and it does not merge screens that do not overlap:
> +------+ +---+
> | A    | | C |
> |      | +---+
> |    +-+----+
> +----+-+ B  |
>      +------+
> Here 'C' is considered after merging 'A' with 'B', my algorithm does
> not merge it, yours do.
> Both setups are strange, but user should get expectable behavior.

I'm not sure - we'd have to make sure the C WScreen is not obscured by the 
A+B one... might be neater to merge them, though both behaviors are indeed
strange.

I checked out your branch and the lua logic crashed on me. I added a 'test' 
lua script to the 'split' branch at sf.net . 


Kind regards,

Arnout

> On Sat, 9 Apr 2011 11:39:52 +0200
> Arnout Engelen <no...@bz...> wrote:
> > Hi,
> > 
> > mod_xinerama currently did not support 'mirrored mode' multihead
> > (xrandr --same-as) correctly: it created 2 WScreens (1 for each
> > monitor, even when both monitors took up exactly the same space on
> > the virtual display).
> > 
> > Apart from being generally inelegant and wrong, it also caused some
> > trouble when an embedded dock would be assigned to the invisible
> > WScreen etc.
> > 
> > I created a patch for mod_xinerama that will merge any overlapping
> > Xinerama screens into 1 notion WScreen, solving this problem. I
> > committed it to an 'overlap' branch, and would be interested to get
> > your reviews before merging it to master.
> > 
> > Git:
> > http://notion.git.sourceforge.net/git/gitweb.cgi?p=notion/mod_xinerama;a=shortlog;h=refs/heads/overlap
> > Issuetracker:
> > https://sourceforge.net/tracker/index.php?func=detail&aid=3262747&group_id=314802&atid=1324528#
> > 
> > 
> > Kind regards,
> > 
> > Arnout
> 
> -- 
>                                  Tomáš 'ebík' Ebenlendr
>                                  PF 2011.27366273465
> 



> ------------------------------------------------------------------------------
> Xperia(TM) PLAY
> It's a major breakthrough. An authentic gaming
> smartphone on the nation's most reliable network.
> And it wants your games.
> http://p.sf.net/sfu/verizon-sfdev
> _______________________________________________
> Notion-devel mailing list
> Not...@li...
> https://lists.sourceforge.net/lists/listinfo/notion-devel