Re: [Notion-devel] [PATCH 3/4] Do complete recalculation on tab's title change.

[Arnout E. <no...@bz...>]

On Tue, Feb 08, 2011 at 12:02:00AM +0100, ebik wrote:
> The condition is just copied from place just few lines above (in the
> same function). I did not checked how and why the condition works.

Those strings are from the 'stringstore' (a libtu thing), which appear to 
be (refcounted) constants, so I guess it'd be OK to compare them with ==. 


Arnout

> On Mon, 7 Feb 2011 23:57:47 +0100
> Arnout Engelen <no...@bz...> wrote:
> 
> > On Mon, Feb 07, 2011 at 04:50:59AM +0100, Tomáš Ebenlendr wrote:
> > > @@ -767,9 +769,11 @@ void frame_managed_notify(WFrame *frame,
> > > WRegion *sub, WRegionNotify how)
> > > how==ioncore_g.notifies.sub_activity ||
> > > how==ioncore_g.notifies.tag){ 
> > > +        complete=how==ioncore_g.notifies.name;
> > 
> > Shouldn't that use strcmp?
> > 
> > 
> > Arnout
> > 
> 
> 
> -- 
>                                  Tomáš 'ebík' Ebenlendr
>                                  PF 2011.10410813039
>