[Notion-devel] Atomic commits! Review patches!

[<eb...@dr...>]

I inspected your commit, it was hard to find the fix.
Your commit shoud be split in two commits:
  first one - code purifying (indenting, variable renames etc.)
  second one - the actual fix
This way it would be clear what you did.

I like ion3(plus) because of every line of code was critically
considered by Tuomo. Now we have no Tuomo, thus we should review the
patches. And not blindly apply them. This includes all user contributed
patches that were not part of ion3plus (including my patch for
proportional tabs). Otherwise we end with unmaintainable code.

On Sat, 22 Jan 2011 16:30:24 +0100
Arnout Engelen <no...@bz...> wrote:
> Hi,
> 
> As some of you might have noticed, notion git is starting to get into
> shape and i've been fixing some bugs here and there.
> 
> >From feedback from existing Ion users, the 'elastic/proportional'
> >tab size
> functionality that was merged into Notion from 
> http://github.com/gwash/ion-3plus is not appreciated by everyone. I
> don't care for it much myself either, and the code is not very neat
> (actually one of the things I fixed was an endless loop in this code,
> causing notion to crash and fill up a CPU).
> 
> We should at least make this behavior optional - would anyone be
> against just reverting it entirely?
> 
> 
> Kind regards,
> 
> Arnout
> 
> ------------------------------------------------------------------------------
> Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)!
> Finally, a world-class log management solution at an even better
> price-free! Download using promo code Free_Logger_4_Dev2Dev. Offer
> expires February 28th, so secure your free ArcSight Logger TODAY! 
> http://p.sf.net/sfu/arcsight-sfd2d
> _______________________________________________
> Notion-devel mailing list
> Not...@li...
> https://lists.sourceforge.net/lists/listinfo/notion-devel
> 


-- 
                                 Tomáš 'ebík' Ebenlendr
                                 PF 2011.07332182268