Menu ▾ ▴

#617 [bug 5013] Correct range for "Line Operations"

Next_major_release
closed
nobody
None
1
2014-10-21
2014-10-12
Mike Cowperthwaite
No

This patch addresses the Notepad++ parts of Bug 5013: it tweaks ScintillaEditView::getSelectionLinesRange() to reduce the end line if the end position is in column 0. This fixes the bug for the Sort and Move Up/Move Down cases. The bug's Split and Join cases are a Scintilla issue.

The patch also removes the bit of code that would swap begin and end if begin were somehow greater than end: the Scintilla documentation explicitly states that BEGIN is never a larger value than END.

1 Attachments
NP6_6_9_lines_range.patch

Discussion

  • Mike Cowperthwaite

    Mike Cowperthwaite - 2014-10-13

    I'm withdrawing this patch. It does what I expected for multi-line selections but it breaks the unselected case and the selection-within-a-line case in ways I don't quite understand.

     

  • Don HO

    Don HO - 2014-10-21
    • status: open --> closed
    • Priority: 5 --> 1