#525 Check "Begin/End select" menuitem when active

Next_major_release
closed
nobody
None
6
2013-10-01
2013-09-11
No

When the user starts "Begin/End select" there is no indication that the function is active. This patch sets a check next to the menuitem when Begin/End select has started, and removes it when it ends.

1 Attachments

Discussion

  • Don HO

    Don HO - 2013-09-16
    • status: open --> accepted
    • Priority: 5 --> 6
     
  • Andreas Jonsson

    Andreas Jonsson - 2013-09-17

    There must've been a merge error here. beginOrEndSelect() is no longer called. This is how the code should look:

            case IDM_EDIT_BEGINENDSELECT:
            {
                if(_pEditView->beginEndSelectedIsStarted())
                    ::CheckMenuItem(_mainMenuHandle, IDM_EDIT_BEGINENDSELECT, MF_BYCOMMAND | MF_UNCHECKED);
                else
                    ::CheckMenuItem(_mainMenuHandle, IDM_EDIT_BEGINENDSELECT, MF_BYCOMMAND | MF_CHECKED);
            _pEditView->beginOrEndSelect();
            }
    
     
  • Don HO

    Don HO - 2013-09-17

    Oups, my bad.
    Thank you for checking and letting me know.
    The correction is committed in rev 1121.

    Don

     
  • Don HO

    Don HO - 2013-10-01
    • status: accepted --> closed
     

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks