I'm excited that you've finished the changes to make nmapsql work with 3.70 of nmap. I had a couple suggestions to make the program work with existing Databases a little-bit more seemlessly...
Suggestions:
- specify SQL_OPTIONS_FILE at the command-line for environments where nmap might be executing as a non-privledged user, such as apache. I've been modifying the define to "/etc/nmapsql.conf" in the source to do this, but at the command-line would be more ideal.
- Specify a prefix at the command-line to be used to make nmapsql's TBL_* tables fit better in an existing database 'name-spaces'. I've been modifying the defines in nmap-sql.h and placing "nmapsql_" in front of each TBL_* define, but being able to do it from the command-line would be ideal. This could also be done in the options file, which might be more in line with your design.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
I've just added the following functionality following your suggestion:
-- /etc/nmapsql.conf is the default configuration file
-- The default config file can be overridden from the command line with the --sqlconf <filenname> option
-- The configuration file can now be used to specify different database and table names for the tables used by nmapsql.
More info on these will be available in the README.sql and CHANGELOG files. However, I'm not uploading this version source just yet, especially as I have yet to test it or hear anything back from others as to how good/bad/ugly the previous upoload was.
-- H
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Hello hatique,
I'm excited that you've finished the changes to make nmapsql work with 3.70 of nmap. I had a couple suggestions to make the program work with existing Databases a little-bit more seemlessly...
Suggestions:
- specify SQL_OPTIONS_FILE at the command-line for environments where nmap might be executing as a non-privledged user, such as apache. I've been modifying the define to "/etc/nmapsql.conf" in the source to do this, but at the command-line would be more ideal.
- Specify a prefix at the command-line to be used to make nmapsql's TBL_* tables fit better in an existing database 'name-spaces'. I've been modifying the defines in nmap-sql.h and placing "nmapsql_" in front of each TBL_* define, but being able to do it from the command-line would be ideal. This could also be done in the options file, which might be more in line with your design.
Sounds like a good idea. I'll add this if I have time away from real life ;)
I've just added the following functionality following your suggestion:
-- /etc/nmapsql.conf is the default configuration file
-- The default config file can be overridden from the command line with the --sqlconf <filenname> option
-- The configuration file can now be used to specify different database and table names for the tables used by nmapsql.
More info on these will be available in the README.sql and CHANGELOG files. However, I'm not uploading this version source just yet, especially as I have yet to test it or hear anything back from others as to how good/bad/ugly the previous upoload was.
-- H