Menu

#35 Merge registry configs into document

v1.1.0
open
Other (7)
5
2007-04-18
2006-07-14
mousio
No

Hi again

I think that in private void
Nini.Config.RegistryConfigSource.MergeConfigsIntoDocum
ent(), a line is missing:

if (registryConfig.ParentKey) {
registryConfig.Key =
registryConfig.Key.CreateSubKey
(registryConfig.Name);
registryConfig.ParentKey = false; //LINE TO
ADD?
}

Since ParentKey denotes whether the key is a parent
key, and if so, you create a subkey and move the key
reference to the subkey, the ParentKey property here
needs to be set accordingly; otherwise the ParentKey
will falsely induce creation of subkeys every time a
save happens, while that actually is no longer
required.

Discussion

  • Brent R. Matzelle

    Logged In: YES
    user_id=163900
    Originator: NO

    Interesting. I'll check that out. Thanks!

     
  • Brent R. Matzelle

    • assigned_to: nobody --> bmatzelle
     

Log in to post a comment.