#10 Not all nodes in tree have an active DataComponent

[Anna Wojtowicz]

I was debugging something in MOOSEModel.reviewEntries() and noticed only some nodes have their activeDataNode set. The Property Viewer table is instead reading from the first dataNode when no activeDataNode is available -- this is a good backup plan to have, but it shouldn't have to be used.

Everything used to have an activeDataNode, I don't know at what point they stopped, but it needs to be fixed.

[Anna Wojtowicz]

Went through and ensured all blocks have an actual active data component set. What I noticed along the way, however, is that child exemplars don't have active nodes set. It doesn't really affect anything since Jordan made sure the Property Viewer tables will read the first dataNode if no active node is set, but ideally, everything should have an active data node set.

I could also go through and make sure all child exemplars have an active data node (might be complex since it seems like so many operations reset the actively set node). Or, alternatively (and possibly simpler), we could call setActiveDataNode(...) whenever a child is actually added in the MOOSE TreeViewer.

[Jay Jay Billings]

Calling setActiveDataNode is the appropriate fix.

Jay
On Sep 22, 2014 7:53 PM, "Anna Wojtowicz" awoj@users.sf.net wrote:

Went through and ensured all blocks have an actual active data component
set. What I noticed along the way, however, is that child exemplars don't
have active nodes set. It doesn't really affect anything since Jordan made
sure the Property Viewer tables will read the first dataNode if no active
node is set, but ideally, everything should have an active data node set.

I could also go through and make sure all child exemplars have an active
data node (might be complex since it seems like so many operations reset
the actively set node). Or, alternatively (and possibly simpler), we could
call setActiveDataNode(...) whenever a child is actually added in the
MOOSE TreeViewer.

---

• [moosebugs:#10] http://sourceforge.net/p/niceproject/moosebugs/10 Not
  all nodes in tree have an active DataComponent*

Status: open
Milestone: 2.0
Created: Thu Sep 18, 2014 06:34 PM UTC by Anna Wojtowicz
Last Updated: Thu Sep 18, 2014 06:34 PM UTC
Owner: Anna Wojtowicz

I was debugging something in MOOSEModel.reviewEntries() and noticed only
some nodes have their activeDataNode set. The Property Viewer table is
instead reading from the first dataNode when no activeDataNode is
available -- this is a good backup plan to have, but it shouldn't have to
be used.

Everything used to have an activeDataNode, I don't know at what point
they stopped, but it needs to be fixed.

---

Sent from sourceforge.net because you indicated interest in
https://sourceforge.net/p/niceproject/moosebugs/10/

To unsubscribe from further messages, please visit
https://sourceforge.net/auth/subscriptions/

[Anna Wojtowicz]

The issue is where to do this. There is one point in the MOOSEModel code where I actually do traverse through the entire child exemplar structure as I index it in a HashMap, and it would seem logical to do this here.

But many methods associated to TreeComposites also have the consequence of clearing the currently set active data node, including copying, cloning, setting exemplars, setting children, etc. By the time you get to the end of the reviewEntries() method, they have been cleared again (which is what the issue originally was that prompted this ticket).

I have been trying to figure out a way to avoid having to traverse the entire exemplar structure again at the end, but it might be unavoidable.

[Jay Jay Billings]

Just do it in the TreeViewer. That's where it should be done because that
is where it is created.
On Sep 23, 2014 10:41 AM, "Anna Wojtowicz" awoj@users.sf.net wrote:

The issue is where to do this. There is one point in the MOOSEModel code
where I actually do traverse through the entire child exemplar structure as
I index it in a HashMap, and it would seem logical to do this here.

But many methods associated to TreeComposites also have the consequence
of clearing the currently set active data node, including copying, cloning,
setting exemplars, setting children, etc. By the time you get to the end of
the reviewEntries() method, they have been cleared again (which is what
the issue originally was that prompted this ticket).

I have been trying to figure out a way to avoid having to traverse the
entire exemplar structure again at the end, but it might be unavoidable.

---

• [moosebugs:#10] http://sourceforge.net/p/niceproject/moosebugs/10 Not
  all nodes in tree have an active DataComponent*

Status: open
Milestone: 2.0
Created: Thu Sep 18, 2014 06:34 PM UTC by Anna Wojtowicz
Last Updated: Mon Sep 22, 2014 11:53 PM UTC
Owner: Anna Wojtowicz

I was debugging something in MOOSEModel.reviewEntries() and noticed only
some nodes have their activeDataNode set. The Property Viewer table is
instead reading from the first dataNode when no activeDataNode is
available -- this is a good backup plan to have, but it shouldn't have to
be used.

Everything used to have an activeDataNode, I don't know at what point
they stopped, but it needs to be fixed.

---

Sent from sourceforge.net because you indicated interest in
https://sourceforge.net/p/niceproject/moosebugs/10/

To unsubscribe from further messages, please visit
https://sourceforge.net/auth/subscriptions/

[Anna Wojtowicz]

The add child action now sets the child's active data node.