nhibernate-issues — Updates to JIRA issues are sent to this list

[nhibernate-issues] [NHJIRA] Created: (NH-2767) Make the Register* Methods on Dialect Public

[Ricardo P. (JIRA) <nh...@gm...>]

Make the Register* Methods on Dialect Public
--------------------------------------------

                 Key: NH-2767
                 URL: http://216.121.112.228/browse/NH-2767
             Project:  NHibernate
          Issue Type: Improvement
          Components: DataProviders / Dialects
    Affects Versions: 3.2.0Beta2
            Reporter: Ricardo Peres


In order to make extensibility more easy, the Register* methods on Dialect could be made public. This way, every time we want to register, for example, a custom SQL function, we don't have to subclass all dialects that we need, and we only need to call the new RegisterFunction method on the current dialect.
Since this is a breaking change, because now these functions are protected, perhaps additional public overloads could be added.


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://216.121.112.228/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[nhibernate-issues] [NHJIRA] Commented: (NH-2099) Linq Expressions and case sensitivity

[Patrick E. (JIRA) <nh...@gm...>]

    [ http://216.121.112.228/browse/NH-2099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=21283#action_21283 ] 

Patrick Earl commented on NH-2099:
----------------------------------

Using a registered ilike function sounds good to me.  StartsWith currently uses like IIRC.

> Linq Expressions and case sensitivity
> -------------------------------------
>
>                 Key: NH-2099
>                 URL: http://216.121.112.228/browse/NH-2099
>             Project:  NHibernate
>          Issue Type: New Feature
>          Components: Linq Provider
>    Affects Versions: 3.0.0.Alpha1
>            Reporter: Jose F. Romaniello
>            Priority: Minor
>
> The following query:
> persons.Where(p => p.Nombre.StartsWith("a"))
> in objects is case-sensitive. And I would like in nhibernate be case sensitive too.
> otherwise:
> persons.Where(p => p.Nombre.StartsWith("a", StringComparison.OrdinalIgnoreCase))
> In sql server it is possible to change the "coalesce" in the where statement. I don't know for other providers.
> The same for others string operators.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://216.121.112.228/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[nhibernate-issues] [NHJIRA] Closed: (NH-2766) Linq To NH: support to String.Equals(string, StringComparison)

[Fabio M. (JIRA) <nh...@gm...>]

     [ http://216.121.112.228/browse/NH-2766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Fabio Maulo closed NH-2766.
---------------------------

    Resolution: Duplicate

> Linq To NH: support to String.Equals(string, StringComparison)
> --------------------------------------------------------------
>
>                 Key: NH-2766
>                 URL: http://216.121.112.228/browse/NH-2766
>             Project:  NHibernate
>          Issue Type: Improvement
>          Components: Linq Provider
>    Affects Versions: 3.1.0
>            Reporter: Matteo Migliore
>            Priority: Major
>
> The method for compare string using StringComparison is not supported in Linq To NH.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://216.121.112.228/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[nhibernate-issues] [NHJIRA] Closed: (NH-2764) Binary data being truncated to 8000 bytes when persisting to varbinary(MAX) - Sql Server 2008

[Fabio M. (JIRA) <nh...@gm...>]

     [ http://216.121.112.228/browse/NH-2764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Fabio Maulo closed NH-2764.
---------------------------

    Resolution: Not an Issue

> Binary data being truncated to 8000 bytes when persisting to varbinary(MAX) - Sql Server 2008
> ---------------------------------------------------------------------------------------------
>
>                 Key: NH-2764
>                 URL: http://216.121.112.228/browse/NH-2764
>             Project:  NHibernate
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 3.1.0
>            Reporter: Brendan Cox
>            Priority: Critical
>         Attachments: ByteTruncationRepro.zip
>
>
> Hi
> After upgrading from NHibernate 2.1 to 3.1.0 I appear to have hit a regression that was marked as fixed in version 3.1.0, refer [#NH-2484].
> All attempts to persist binary data exceeding 8k to varbinary(MAX) results in the data being truncated, all worked well using version 2.1, unfortunately upgrading to 3.1.0 has introduced this truncation issue.
> No exception is thrown and no indication is given that the attempt to serialize the binary data to varbinary(MAX) table column has occured.
> Attachment provided illustrates the issue.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://216.121.112.228/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[nhibernate-issues] [NHJIRA] Commented: (NH-2764) Binary data being truncated to 8000 bytes when persisting to varbinary(MAX) - Sql Server 2008

[Julian M. (JIRA) <nh...@gm...>]

    [ http://216.121.112.228/browse/NH-2764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=21282#action_21282 ] 

Julian Maughan commented on NH-2764:
------------------------------------

The fluent mapping in your repro doesn't provide any type information to tell NH that you are mapping a Blob. I believe a 'byte[]' type is interpreted as a BinaryType which has a default max length of 8000. Try setting an explicit type of BinaryBlobType and/or setting the length to a value larger than 8000 bytes.

Note that NH-2484 addresses a slightly different problem, where the type was defined (a serializable type), but the specified length was ignored.

> Binary data being truncated to 8000 bytes when persisting to varbinary(MAX) - Sql Server 2008
> ---------------------------------------------------------------------------------------------
>
>                 Key: NH-2764
>                 URL: http://216.121.112.228/browse/NH-2764
>             Project:  NHibernate
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 3.1.0
>            Reporter: Brendan Cox
>            Priority: Critical
>         Attachments: ByteTruncationRepro.zip
>
>
> Hi
> After upgrading from NHibernate 2.1 to 3.1.0 I appear to have hit a regression that was marked as fixed in version 3.1.0, refer [#NH-2484].
> All attempts to persist binary data exceeding 8k to varbinary(MAX) results in the data being truncated, all worked well using version 2.1, unfortunately upgrading to 3.1.0 has introduced this truncation issue.
> No exception is thrown and no indication is given that the attempt to serialize the binary data to varbinary(MAX) table column has occured.
> Attachment provided illustrates the issue.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://216.121.112.228/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[nhibernate-issues] [NHJIRA] Closed: (NH-2765) Session.Clear() doesn't work after exception occur.

[Steve B. (JIRA) <nh...@gm...>]

     [ http://216.121.112.228/browse/NH-2765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Steve Bohlen closed NH-2765.
----------------------------

    Resolution: Not an Issue

By design, once an exception is thrown in an operation on the ISession, the ISession is considered to be in an "inconsistent state" and thus CANNOT be used for further operations with any expectation of reliable results.

As you have discovered here, this does not mean you can't *call* methods on the ISession after an exception is raised, just that the ISession is not guaranteed to behave predictably after any exception is thrown during an op on it.  Because of this behavior, the recommended pattern is to *discard* the current ISession once an exception is thrown, acquire a brand *new* ISession instance from the ISessionFactory, and perform any compensating/recovery logic in that new instance of the ISession.

Continuing to use/interact with an ISession instance once an exception has been thrown not support/contra-indicated.

You might consider the following pattern that (depending on your specific use-case) might permit you to react to the problem by simply rolling back an NH Transaction...

using (var tx = session.BeginTransaction())
{
  try
  {
    //some behavior in here like...
    session.SaveOrUpdate(myObject);
    tx.Commit();
  }
  catch (Exception ex)
  {
    tx.RollBack();
    throw;
  }
}

> Session.Clear() doesn't work after exception occur. 
> ----------------------------------------------------
>
>                 Key: NH-2765
>                 URL: http://216.121.112.228/browse/NH-2765
>             Project:  NHibernate
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 3.2.0Beta1
>            Reporter: mod sartawi
>
> Hi there,
> When I try to add record by call Session.Save(object), if the object's ID already exists in database I catch the exception then remove the object from the session by Session.Evict(object) or Session.Clear() then change the ID for the object then call again Session.Save(object) after this I notice 2 statement sent to database, one with old ID and other with new ID and this make exception again with old ID, and if do same and change ID again then call Save() 3 statement sent to database even after call Session.Clear(). this behavior I notice with version 3.2.0 Beta 1   
> Thanks in advance.
> Regards,

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://216.121.112.228/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[nhibernate-issues] [NHJIRA] Commented: (NH-2766) Linq To NH: support to String.Equals(string, StringComparison)

[Diego M. (JIRA) <nh...@gm...>]

    [ http://216.121.112.228/browse/NH-2766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=21280#action_21280 ] 

Diego Mijelshon commented on NH-2766:
-------------------------------------

There is no standard way to do an explicit case-insensitive query in SQL.

> Linq To NH: support to String.Equals(string, StringComparison)
> --------------------------------------------------------------
>
>                 Key: NH-2766
>                 URL: http://216.121.112.228/browse/NH-2766
>             Project:  NHibernate
>          Issue Type: Improvement
>          Components: Linq Provider
>    Affects Versions: 3.1.0
>            Reporter: Matteo Migliore
>            Priority: Major
>
> The method for compare string using StringComparison is not supported in Linq To NH.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://216.121.112.228/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[nhibernate-issues] [NHJIRA] Created: (NH-2766) Linq To NH: support to String.Equals(string, StringComparison)

[Matteo M. (JIRA) <nh...@gm...>]

Linq To NH: support to String.Equals(string, StringComparison)
--------------------------------------------------------------

                 Key: NH-2766
                 URL: http://216.121.112.228/browse/NH-2766
             Project:  NHibernate
          Issue Type: Improvement
          Components: Linq Provider
    Affects Versions: 3.1.0
            Reporter: Matteo Migliore
            Priority: Major


The method for compare string using StringComparison is not supported in Linq To NH.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://216.121.112.228/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[nhibernate-issues] [NHJIRA] Assigned: (NH-2763) queryover fails where referencing enum in VB.NET

[Richard B. (JIRA) <nh...@gm...>]

     [ http://216.121.112.228/browse/NH-2763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Richard Brown reassigned NH-2763:
---------------------------------

    Assignee: Richard Brown

> queryover fails where referencing enum in VB.NET
> ------------------------------------------------
>
>                 Key: NH-2763
>                 URL: http://216.121.112.228/browse/NH-2763
>             Project:  NHibernate
>          Issue Type: Bug
>          Components: QueryOver
>    Affects Versions: 3.1.0
>            Reporter: Matthew Beer
>            Assignee: Richard Brown
>            Priority: Major
>
> Prior issue [NH-2407] dealt with what was probably the same issue for the LINQ provider.
> The following fails in VB.NET
> Public Enum States
>         Open = 1
>         Closed = 2
>         Held = 3
> End Enum
> results = session.QueryOver(of foo)().Where(Function(f) f.State = States.Open)
> Stack dump looks like:
> Exception: Cannot interpret member from ConvertChecked(ConvertChecked(value(MyNamespace.MyRepository+_Closure$__32).$VB$Local_criteria.State))]
>    NHibernate.Impl.ExpressionProcessor.IsMemberExpression(Expression expression) +318
>    NHibernate.Impl.ExpressionProcessor.ProcessBinaryExpression(BinaryExpression expression) +95
>    NHibernate.Impl.ExpressionProcessor.ProcessExpression(Expression expression) +57
>    NHibernate.Criterion.QueryOver`2.Add(Expression`1 expression) +28
>    NHibernate.Criterion.QueryOver`2.NHibernate.IQueryOver<TRoot,TSubType>.Where(Expression`1 expression) +5
> Note: database stores value as a string

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://216.121.112.228/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[nhibernate-issues] [NHJIRA] Created: (NH-2765) Session.Clear() doesn't work after exception occur.

[mod s. (JIRA) <nh...@gm...>]

Session.Clear() doesn't work after exception occur. 
----------------------------------------------------

                 Key: NH-2765
                 URL: http://216.121.112.228/browse/NH-2765
             Project:  NHibernate
          Issue Type: Bug
          Components: Core
    Affects Versions: 3.2.0Beta1
            Reporter: mod sartawi


Hi there,
When I try to add record by call Session.Save(object), if the object's ID already exists in database I catch the exception then remove the object from the session by Session.Evict(object) or Session.Clear() then change the ID for the object then call again Session.Save(object) after this I notice 2 statement sent to database, one with old ID and other with new ID and this make exception again with old ID, and if do same and change ID again then call Save() 3 statement sent to database even after call Session.Clear(). this behavior I notice with version 3.2.0 Beta 1   

Thanks in advance.
Regards,


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://216.121.112.228/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[nhibernate-issues] [NHJIRA] Created: (NH-2764) Binary data being truncated to 8000 bytes when persisting to varbinary(MAX) - Sql Server 2008

[Brendan C. (JIRA) <nh...@gm...>]

Binary data being truncated to 8000 bytes when persisting to varbinary(MAX) - Sql Server 2008
---------------------------------------------------------------------------------------------

                 Key: NH-2764
                 URL: http://216.121.112.228/browse/NH-2764
             Project:  NHibernate
          Issue Type: Bug
          Components: Core
    Affects Versions: 3.1.0
            Reporter: Brendan Cox
            Priority: Critical
         Attachments: ByteTruncationRepro.zip

Hi

After upgrading from NHibernate 2.1 to 3.1.0 I appear to have hit a regression that was marked as fixed in version 3.1.0, refer [#NH-2484].

All attempts to persist binary data exceeding 8k to varbinary(MAX) results in the data being truncated, all worked well using version 2.1, unfortunately upgrading to 3.1.0 has introduced this truncation issue.

No exception is thrown and no indication is given that the attempt to serialize the binary data to varbinary(MAX) table column has occured.

Attachment provided illustrates the issue.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://216.121.112.228/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[nhibernate-issues] [NHJIRA] Commented: (NH-2762) Failed to use IGrouping<TKey, TElement>.Contains() from Lookup to make SQL IN statement

[Mazlan (JIRA) <nh...@gm...>]

    [ http://216.121.112.228/browse/NH-2762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=21279#action_21279 ] 

Mazlan commented on NH-2762:
----------------------------

:) Emm...it not only affect v3.1 but until the nightly build release.
I create the test project which I attached above and tested from the current trunk.
It was failed at least in my last checkout reversion 5914, so the new v3.2 beta also the same.
Good luck.

> Failed to use IGrouping<TKey, TElement>.Contains() from Lookup to make SQL IN statement
> ---------------------------------------------------------------------------------------
>
>                 Key: NH-2762
>                 URL: http://216.121.112.228/browse/NH-2762
>             Project:  NHibernate
>          Issue Type: Bug
>          Components: Linq Provider
>    Affects Versions: 3.1.0
>            Reporter: Mazlan
>            Priority: Minor
>         Attachments: NH2762.zip
>
>
> This bug still happened in current Revision 5914.
> Using array, List or collection does not have a problem to make SQL IN statement by using Contains() method.
> However NHibernate does not generete SQL IN statement from IGrouping<TKey, TElement> type which is mostly used from ILookup<TKey, TElement>.
> It simply pass it to SQL parameter which then will cause GenericADOException.
> Reproduce:
>                 var Emps = (from e in s.Query<Employee>()
>                             select e).ToList();
>                 var EmpsInDept = Emps.ToLookup(e => e.Department, e => e.Id); // e.Department is a type of string.
>                 foreach (var DeptGroup in EmpsInDept)
>                 {
>                     if (DeptGroup.Key == "IT")
>                     {
>                         var firstNameInIT = (from e in s.Query<Employee>()
>                                              where DeptGroup.Contains(e.Id)
>                                              select e.FirstName).ToList();
>                     }
>                 }
> The "DeptGroup.Contains(e.Id)" will throw the exception. Currently convert it to a List temporarily fix it "DeptGroup.ToList().Contains(e.Id)".
> Note:
> IGrouping<TKey, TElement> is also IEnumerable<TElement> which can be used like this:
>                             List<string> list = new List<string>(DeptGroup);
>                             foreach (string dept in DeptGroup){}
> because DeptGroup is also implement IEnumerable<TElement> which is IEnumerable<string>
> Suggestion: to build the SQL IN statement do not only look for collection, List or Array type but also any of IEnumerable<TElement> with method Contains().

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://216.121.112.228/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[nhibernate-issues] [NHJIRA] Commented: (NH-2762) Failed to use IGrouping<TKey, TElement>.Contains() from Lookup to make SQL IN statement

[Mazlan (JIRA) <nh...@gm...>]

    [ http://216.121.112.228/browse/NH-2762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=21278#action_21278 ] 

Mazlan commented on NH-2762:
----------------------------

This is my first time use NHibernate in v3.1 and it was extreamly great than buggy Entity Framework. Logically this issue should persist on previous version, I don't have any idea about the other versions on which Linq is started, change it apprioriately.

This issue also my first issue reported, as NHibernate user and using Linq in NHibernate, when trying to get how to use SQL IN, using the .Contains() extension method is the way found in search engine. So I will thinking any .Contains() (mostly from type IEnumerable<TElement>) can automatically turn into SQL IN statement but not from System.Linq.Lookup. There is a reasons why I forced to use Lookup type. It is hard to deal with database with columns only Id, Key and Value which Value has a type sql_variant. I need to filter out by date, I need to do grouping all in application level. I want to avoid unnecessary conversion to List<T>.

Why I report this, because I love Linq for NHibernate than Linq for SQL. Believe me it is possible to fix this, even I never look into the NHibernate source code. Otherwise you could make an exception that NHibernate does not support using IGrouping<TKey, TElement>.Contains() in Linq statement and suggest to convert to list by .ToList() first, it save a lots of time.

This is my QnA in StackOverflow http://stackoverflow.com/questions/6146706/sql-in-statement-in-linq-for-fluent-nhibernate
http://stackoverflow.com/questions/6146706/sql-in-statement-in-linq-for-fluent-nhibernate

> Failed to use IGrouping<TKey, TElement>.Contains() from Lookup to make SQL IN statement
> ---------------------------------------------------------------------------------------
>
>                 Key: NH-2762
>                 URL: http://216.121.112.228/browse/NH-2762
>             Project:  NHibernate
>          Issue Type: Bug
>          Components: Linq Provider
>    Affects Versions: 3.1.0
>            Reporter: Mazlan
>            Priority: Minor
>         Attachments: NH2762.zip
>
>
> This bug still happened in current Revision 5914.
> Using array, List or collection does not have a problem to make SQL IN statement by using Contains() method.
> However NHibernate does not generete SQL IN statement from IGrouping<TKey, TElement> type which is mostly used from ILookup<TKey, TElement>.
> It simply pass it to SQL parameter which then will cause GenericADOException.
> Reproduce:
>                 var Emps = (from e in s.Query<Employee>()
>                             select e).ToList();
>                 var EmpsInDept = Emps.ToLookup(e => e.Department, e => e.Id); // e.Department is a type of string.
>                 foreach (var DeptGroup in EmpsInDept)
>                 {
>                     if (DeptGroup.Key == "IT")
>                     {
>                         var firstNameInIT = (from e in s.Query<Employee>()
>                                              where DeptGroup.Contains(e.Id)
>                                              select e.FirstName).ToList();
>                     }
>                 }
> The "DeptGroup.Contains(e.Id)" will throw the exception. Currently convert it to a List temporarily fix it "DeptGroup.ToList().Contains(e.Id)".
> Note:
> IGrouping<TKey, TElement> is also IEnumerable<TElement> which can be used like this:
>                             List<string> list = new List<string>(DeptGroup);
>                             foreach (string dept in DeptGroup){}
> because DeptGroup is also implement IEnumerable<TElement> which is IEnumerable<string>
> Suggestion: to build the SQL IN statement do not only look for collection, List or Array type but also any of IEnumerable<TElement> with method Contains().

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://216.121.112.228/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[nhibernate-issues] [NHJIRA] Created: (NH-2763) queryover fails where referencing enum in VB.NET

[Matthew B. (JIRA) <nh...@gm...>]

queryover fails where referencing enum in VB.NET
------------------------------------------------

                 Key: NH-2763
                 URL: http://216.121.112.228/browse/NH-2763
             Project:  NHibernate
          Issue Type: Bug
          Components: QueryOver
    Affects Versions: 3.1.0
            Reporter: Matthew Beer
            Priority: Major


Prior issue [NH-2407] dealt with what was probably the same issue for the LINQ provider.

The following fails in VB.NET

Public Enum States
        Open = 1
        Closed = 2
        Held = 3
End Enum

results = session.QueryOver(of foo)().Where(Function(f) f.State = States.Open)

Stack dump looks like:

Exception: Cannot interpret member from ConvertChecked(ConvertChecked(value(MyNamespace.MyRepository+_Closure$__32).$VB$Local_criteria.State))]
   NHibernate.Impl.ExpressionProcessor.IsMemberExpression(Expression expression) +318
   NHibernate.Impl.ExpressionProcessor.ProcessBinaryExpression(BinaryExpression expression) +95
   NHibernate.Impl.ExpressionProcessor.ProcessExpression(Expression expression) +57
   NHibernate.Criterion.QueryOver`2.Add(Expression`1 expression) +28
   NHibernate.Criterion.QueryOver`2.NHibernate.IQueryOver<TRoot,TSubType>.Where(Expression`1 expression) +5

Note: database stores value as a string

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://216.121.112.228/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[nhibernate-issues] [NHJIRA] Resolved: (NHE-12) Dynamic Components cause envers to crash on initialization

[Roger (JIRA) <nh...@gm...>]

     [ http://216.121.112.228/browse/NHE-12?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Roger resolved NHE-12.
----------------------

       Resolution: Fixed
    Fix Version/s: 1.0 RC

Fixed

> Dynamic Components cause envers to crash on initialization
> ----------------------------------------------------------
>
>                 Key: NHE-12
>                 URL: http://216.121.112.228/browse/NHE-12
>             Project: NHibernate.Envers
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.0 Beta 2
>            Reporter: Allan Ritchie
>            Assignee: Roger
>             Fix For: 1.0 RC
>
>         Attachments: DynamicComponent.zip
>
>
> This is current open in hibernate as well (http://opensource.atlassian.com/projects/hibernate/browse/HHH-6003)
> [NullReferenceException: Object reference not set to an instance of an object.]
>    NHibernate.Envers.Tools.Reflection.<PersistentInfo>d__4.MoveNext() +93
>    NHibernate.Envers.Configuration.Metadata.Reader.AuditedPropertiesReader.AddPropertiesFromClass(Type clazz) +679
>    NHibernate.Envers.Configuration.Metadata.Reader.AuditedPropertiesReader.AddPropertiesFromClass(Type clazz) +530
>    NHibernate.Envers.Configuration.Metadata.Reader.AnnotationsMetadataReader.GetAuditData() +321
> [MappingException: Object reference not set to an instance of an object.]
>    NHibernate.Envers.Configuration.Metadata.Reader.AnnotationsMetadataReader.GetAuditData() +463
>    NHibernate.Envers.Configuration.EntitiesConfigurator.Configure(Configuration cfg, IMetaDataStore metaDataStore, GlobalConfiguration globalCfg, AuditEntitiesConfiguration verEntCfg, IAuditStrategy auditStrategy, XmlDocument revisionInfoXmlMapping, XmlElement revisionInfoRelationMapping) +380
>    NHibernate.Envers.Configuration.AuditConfiguration..ctor(Configuration cfg, IMetaDataProvider metaDataProvider) +466
>    NHibernate.Envers.Configuration.AuditConfiguration.GetFor(Configuration cfg) +206
>    NHibernate.Cfg.NhConfigurationExtension.IntegrateWithEnvers(Configuration configuration, AuditEventListener auditEventListener, IMetaDataProvider metaDataProvider) +164

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://216.121.112.228/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[nhibernate-issues] [NHJIRA] Commented: (NHE-12) Dynamic Components cause envers to crash on initialization

[Roger (JIRA) <nh...@gm...>]

    [ http://216.121.112.228/browse/NHE-12?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=21276#action_21276 ] 

Roger commented on NHE-12:
--------------------------

Thanks for the test case - pushed (with some extensions) to trunk.

I'll look at this issue when I find some time.

> Dynamic Components cause envers to crash on initialization
> ----------------------------------------------------------
>
>                 Key: NHE-12
>                 URL: http://216.121.112.228/browse/NHE-12
>             Project: NHibernate.Envers
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.0 Beta 2
>            Reporter: Allan Ritchie
>            Assignee: Roger
>         Attachments: DynamicComponent.zip
>
>
> This is current open in hibernate as well (http://opensource.atlassian.com/projects/hibernate/browse/HHH-6003)
> [NullReferenceException: Object reference not set to an instance of an object.]
>    NHibernate.Envers.Tools.Reflection.<PersistentInfo>d__4.MoveNext() +93
>    NHibernate.Envers.Configuration.Metadata.Reader.AuditedPropertiesReader.AddPropertiesFromClass(Type clazz) +679
>    NHibernate.Envers.Configuration.Metadata.Reader.AuditedPropertiesReader.AddPropertiesFromClass(Type clazz) +530
>    NHibernate.Envers.Configuration.Metadata.Reader.AnnotationsMetadataReader.GetAuditData() +321
> [MappingException: Object reference not set to an instance of an object.]
>    NHibernate.Envers.Configuration.Metadata.Reader.AnnotationsMetadataReader.GetAuditData() +463
>    NHibernate.Envers.Configuration.EntitiesConfigurator.Configure(Configuration cfg, IMetaDataStore metaDataStore, GlobalConfiguration globalCfg, AuditEntitiesConfiguration verEntCfg, IAuditStrategy auditStrategy, XmlDocument revisionInfoXmlMapping, XmlElement revisionInfoRelationMapping) +380
>    NHibernate.Envers.Configuration.AuditConfiguration..ctor(Configuration cfg, IMetaDataProvider metaDataProvider) +466
>    NHibernate.Envers.Configuration.AuditConfiguration.GetFor(Configuration cfg) +206
>    NHibernate.Cfg.NhConfigurationExtension.IntegrateWithEnvers(Configuration configuration, AuditEventListener auditEventListener, IMetaDataProvider metaDataProvider) +164

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://216.121.112.228/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[nhibernate-issues] [NHJIRA] Assigned: (NHE-12) Dynamic Components cause envers to crash on initialization

[Roger (JIRA) <nh...@gm...>]

     [ http://216.121.112.228/browse/NHE-12?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Roger reassigned NHE-12:
------------------------

    Assignee: Roger

> Dynamic Components cause envers to crash on initialization
> ----------------------------------------------------------
>
>                 Key: NHE-12
>                 URL: http://216.121.112.228/browse/NHE-12
>             Project: NHibernate.Envers
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.0 Beta 2
>            Reporter: Allan Ritchie
>            Assignee: Roger
>         Attachments: DynamicComponent.zip
>
>
> This is current open in hibernate as well (http://opensource.atlassian.com/projects/hibernate/browse/HHH-6003)
> [NullReferenceException: Object reference not set to an instance of an object.]
>    NHibernate.Envers.Tools.Reflection.<PersistentInfo>d__4.MoveNext() +93
>    NHibernate.Envers.Configuration.Metadata.Reader.AuditedPropertiesReader.AddPropertiesFromClass(Type clazz) +679
>    NHibernate.Envers.Configuration.Metadata.Reader.AuditedPropertiesReader.AddPropertiesFromClass(Type clazz) +530
>    NHibernate.Envers.Configuration.Metadata.Reader.AnnotationsMetadataReader.GetAuditData() +321
> [MappingException: Object reference not set to an instance of an object.]
>    NHibernate.Envers.Configuration.Metadata.Reader.AnnotationsMetadataReader.GetAuditData() +463
>    NHibernate.Envers.Configuration.EntitiesConfigurator.Configure(Configuration cfg, IMetaDataStore metaDataStore, GlobalConfiguration globalCfg, AuditEntitiesConfiguration verEntCfg, IAuditStrategy auditStrategy, XmlDocument revisionInfoXmlMapping, XmlElement revisionInfoRelationMapping) +380
>    NHibernate.Envers.Configuration.AuditConfiguration..ctor(Configuration cfg, IMetaDataProvider metaDataProvider) +466
>    NHibernate.Envers.Configuration.AuditConfiguration.GetFor(Configuration cfg) +206
>    NHibernate.Cfg.NhConfigurationExtension.IntegrateWithEnvers(Configuration configuration, AuditEventListener auditEventListener, IMetaDataProvider metaDataProvider) +164

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://216.121.112.228/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[nhibernate-issues] [NHJIRA] Updated: (NH-2762) Failed to use IGrouping<TKey, TElement>.Contains() from Lookup to make SQL IN statement

[Fabio M. (JIRA) <nh...@gm...>]

     [ http://216.121.112.228/browse/NH-2762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Fabio Maulo updated NH-2762:
----------------------------

    Affects Version/s:     (was: 3.2.0Beta2)
                           (was: 3.2.0Beta1)
                           (was: 3.2.0Alpha3)
                           (was: 3.2.0Alpha2)
                           (was: 3.2.0Alpha1)
                           (was: 3.0.0.GA)
                           (was: 3.0.0.CR1)
                           (was: 3.0.0.Beta2)
                           (was: 3.0.0.Beta1)
                           (was: 3.0.0.Alpha3)
                           (was: 3.0.0.Alpha2)
                           (was: 2.1.2.GA)
                           (was: 2.1.1.GA)
                           (was: 3.0.0.Alpha1)
                           (was:  2.0.1.GA)
                           (was: 1.2.1)

Just as curiosity.
I saw you have reported the issue even for version 1.2.0 that was released some years ago when LINQ was, perhaps, not even just an idea for some Microsoft guy.
Are you doing it for some special reason or is just to do something cool ?

> Failed to use IGrouping<TKey, TElement>.Contains() from Lookup to make SQL IN statement
> ---------------------------------------------------------------------------------------
>
>                 Key: NH-2762
>                 URL: http://216.121.112.228/browse/NH-2762
>             Project:  NHibernate
>          Issue Type: Bug
>          Components: Linq Provider
>    Affects Versions: 3.1.0
>            Reporter: Mazlan
>            Priority: Minor
>         Attachments: NH2762.zip
>
>
> This bug still happened in current Revision 5914.
> Using array, List or collection does not have a problem to make SQL IN statement by using Contains() method.
> However NHibernate does not generete SQL IN statement from IGrouping<TKey, TElement> type which is mostly used from ILookup<TKey, TElement>.
> It simply pass it to SQL parameter which then will cause GenericADOException.
> Reproduce:
>                 var Emps = (from e in s.Query<Employee>()
>                             select e).ToList();
>                 var EmpsInDept = Emps.ToLookup(e => e.Department, e => e.Id); // e.Department is a type of string.
>                 foreach (var DeptGroup in EmpsInDept)
>                 {
>                     if (DeptGroup.Key == "IT")
>                     {
>                         var firstNameInIT = (from e in s.Query<Employee>()
>                                              where DeptGroup.Contains(e.Id)
>                                              select e.FirstName).ToList();
>                     }
>                 }
> The "DeptGroup.Contains(e.Id)" will throw the exception. Currently convert it to a List temporarily fix it "DeptGroup.ToList().Contains(e.Id)".
> Note:
> IGrouping<TKey, TElement> is also IEnumerable<TElement> which can be used like this:
>                             List<string> list = new List<string>(DeptGroup);
>                             foreach (string dept in DeptGroup){}
> because DeptGroup is also implement IEnumerable<TElement> which is IEnumerable<string>
> Suggestion: to build the SQL IN statement do not only look for collection, List or Array type but also any of IEnumerable<TElement> with method Contains().

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://216.121.112.228/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[nhibernate-issues] [NHJIRA] Updated: (NHE-12) Dynamic Components cause envers to crash on initialization

[Allan R. (JIRA) <nh...@gm...>]

     [ http://216.121.112.228/browse/NHE-12?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Allan Ritchie updated NHE-12:
-----------------------------

    Attachment: DynamicComponent.zip

Failing test

> Dynamic Components cause envers to crash on initialization
> ----------------------------------------------------------
>
>                 Key: NHE-12
>                 URL: http://216.121.112.228/browse/NHE-12
>             Project: NHibernate.Envers
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.0 Beta 2
>            Reporter: Allan Ritchie
>         Attachments: DynamicComponent.zip
>
>
> This is current open in hibernate as well (http://opensource.atlassian.com/projects/hibernate/browse/HHH-6003)
> [NullReferenceException: Object reference not set to an instance of an object.]
>    NHibernate.Envers.Tools.Reflection.<PersistentInfo>d__4.MoveNext() +93
>    NHibernate.Envers.Configuration.Metadata.Reader.AuditedPropertiesReader.AddPropertiesFromClass(Type clazz) +679
>    NHibernate.Envers.Configuration.Metadata.Reader.AuditedPropertiesReader.AddPropertiesFromClass(Type clazz) +530
>    NHibernate.Envers.Configuration.Metadata.Reader.AnnotationsMetadataReader.GetAuditData() +321
> [MappingException: Object reference not set to an instance of an object.]
>    NHibernate.Envers.Configuration.Metadata.Reader.AnnotationsMetadataReader.GetAuditData() +463
>    NHibernate.Envers.Configuration.EntitiesConfigurator.Configure(Configuration cfg, IMetaDataStore metaDataStore, GlobalConfiguration globalCfg, AuditEntitiesConfiguration verEntCfg, IAuditStrategy auditStrategy, XmlDocument revisionInfoXmlMapping, XmlElement revisionInfoRelationMapping) +380
>    NHibernate.Envers.Configuration.AuditConfiguration..ctor(Configuration cfg, IMetaDataProvider metaDataProvider) +466
>    NHibernate.Envers.Configuration.AuditConfiguration.GetFor(Configuration cfg) +206
>    NHibernate.Cfg.NhConfigurationExtension.IntegrateWithEnvers(Configuration configuration, AuditEventListener auditEventListener, IMetaDataProvider metaDataProvider) +164

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://216.121.112.228/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[nhibernate-issues] [NHJIRA] Created: (NHE-12) Dynamic Components cause envers to crash on initialization

[Allan R. (JIRA) <nh...@gm...>]

Dynamic Components cause envers to crash on initialization
----------------------------------------------------------

                 Key: NHE-12
                 URL: http://216.121.112.228/browse/NHE-12
             Project: NHibernate.Envers
          Issue Type: Bug
          Components: Core
    Affects Versions: 1.0 Beta 2
            Reporter: Allan Ritchie


This is current open in hibernate as well (http://opensource.atlassian.com/projects/hibernate/browse/HHH-6003)


[NullReferenceException: Object reference not set to an instance of an object.]
   NHibernate.Envers.Tools.Reflection.<PersistentInfo>d__4.MoveNext() +93
   NHibernate.Envers.Configuration.Metadata.Reader.AuditedPropertiesReader.AddPropertiesFromClass(Type clazz) +679
   NHibernate.Envers.Configuration.Metadata.Reader.AuditedPropertiesReader.AddPropertiesFromClass(Type clazz) +530
   NHibernate.Envers.Configuration.Metadata.Reader.AnnotationsMetadataReader.GetAuditData() +321

[MappingException: Object reference not set to an instance of an object.]
   NHibernate.Envers.Configuration.Metadata.Reader.AnnotationsMetadataReader.GetAuditData() +463
   NHibernate.Envers.Configuration.EntitiesConfigurator.Configure(Configuration cfg, IMetaDataStore metaDataStore, GlobalConfiguration globalCfg, AuditEntitiesConfiguration verEntCfg, IAuditStrategy auditStrategy, XmlDocument revisionInfoXmlMapping, XmlElement revisionInfoRelationMapping) +380
   NHibernate.Envers.Configuration.AuditConfiguration..ctor(Configuration cfg, IMetaDataProvider metaDataProvider) +466
   NHibernate.Envers.Configuration.AuditConfiguration.GetFor(Configuration cfg) +206
   NHibernate.Cfg.NhConfigurationExtension.IntegrateWithEnvers(Configuration configuration, AuditEventListener auditEventListener, IMetaDataProvider metaDataProvider) +164

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://216.121.112.228/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[nhibernate-issues] [NHJIRA] Commented: (NHCH-31) NHibernate.Caches.Velocity - update to AppFabric Caching Services 1.0

[Frantisek J. (JIRA) <nh...@gm...>]

    [ http://216.121.112.228/browse/NHCH-31?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=21273#action_21273 ] 

Frantisek Jandos commented on NHCH-31:
--------------------------------------

I appreciate there is cache provider for AppFavric Cache, but I think that the usage of locks dictionary in VelocityClient is problematic due to following reasons:
 (i) The client class is not thread safe (according to ICache comments should be) as distinct Add, Remove, Count may be performed concurrenctly. This could lead to race condions and unexpected dictionary exceptions.
(ii) If we are in cluster, each node would have its own locks dictionary, which could again lead to potential unlock by put.

> NHibernate.Caches.Velocity - update to AppFabric Caching Services 1.0
> ---------------------------------------------------------------------
>
>                 Key: NHCH-31
>                 URL: http://216.121.112.228/browse/NHCH-31
>             Project: NHibernate.Caches
>          Issue Type: Patch
>          Components: Velocity
>    Affects Versions: 3.0.0.CR
>            Reporter: Paul Duran
>            Priority: Major
>         Attachments: VelocityToAppFabric.patch, VelocityToAppFabric_20101129.patch, VelocityToAppFabricDlls.zip
>
>
> Velocity has been renamed to AppFabric Caching Services. I've taken the suggested updates from this stackoverflow article: http://stackoverflow.com/questions/3233792/appfabric-could-not-contact-the-cache-service and improved them.
> Namely:
>  * lock/unlock are fixed.
>  * exceptions are still swallowed but are now logged
>  * item will now remain locked after a Put() operation if it was locked already - see http://social.msdn.microsoft.com/Forums/en/velocity/thread/2b6df3a7-0bf8-4386-ba2d-884fb1a29e0e for explanation
> Known limitation:
>  * if cache cluster is restarted, we will receive an error "ErrorCode<ERRCA0005>:SubStatus<ES0001>:Region referred to does not exist. Use CreateRegion API to fix the error". Open to options on how to resolve that.
> Please note: as part of applying this patch, the following files may be removed from lib\net\3.5:
>  * CacheBaseLibrary.dll
>  * CacheBaseLibrary.XML
>  * CASBase.dll
>  * CASClient.dll
>  * ClientLibrary.dll
>  * ClientLibrary.XML
>  * FabricCommon.dll

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://216.121.112.228/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[nhibernate-issues] [NHJIRA] Updated: (NH-2762) Failed to use IGrouping<TKey, TElement>.Contains() from Lookup to make SQL IN statement

[Mazlan (JIRA) <nh...@gm...>]

     [ http://216.121.112.228/browse/NH-2762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mazlan updated NH-2762:
-----------------------

    Attachment: NH2762.zip

Here is the test, GroupingContains() will failed while the rest is ok.

> Failed to use IGrouping<TKey, TElement>.Contains() from Lookup to make SQL IN statement
> ---------------------------------------------------------------------------------------
>
>                 Key: NH-2762
>                 URL: http://216.121.112.228/browse/NH-2762
>             Project:  NHibernate
>          Issue Type: Bug
>          Components: Linq Provider
>    Affects Versions: 1.2.1,  2.0.1.GA, 2.1.1.GA, 2.1.2.GA, 3.0.0.Alpha1, 3.0.0.Alpha2, 3.0.0.Alpha3, 3.0.0.Beta1, 3.0.0.Beta2, 3.0.0.CR1, 3.0.0.GA, 3.1.0, 3.2.0Alpha1, 3.2.0Alpha2, 3.2.0Alpha3, 3.2.0Beta1, 3.2.0Beta2
>            Reporter: Mazlan
>            Priority: Minor
>         Attachments: NH2762.zip
>
>
> This bug still happened in current Revision 5914.
> Using array, List or collection does not have a problem to make SQL IN statement by using Contains() method.
> However NHibernate does not generete SQL IN statement from IGrouping<TKey, TElement> type which is mostly used from ILookup<TKey, TElement>.
> It simply pass it to SQL parameter which then will cause GenericADOException.
> Reproduce:
>                 var Emps = (from e in s.Query<Employee>()
>                             select e).ToList();
>                 var EmpsInDept = Emps.ToLookup(e => e.Department, e => e.Id); // e.Department is a type of string.
>                 foreach (var DeptGroup in EmpsInDept)
>                 {
>                     if (DeptGroup.Key == "IT")
>                     {
>                         var firstNameInIT = (from e in s.Query<Employee>()
>                                              where DeptGroup.Contains(e.Id)
>                                              select e.FirstName).ToList();
>                     }
>                 }
> The "DeptGroup.Contains(e.Id)" will throw the exception. Currently convert it to a List temporarily fix it "DeptGroup.ToList().Contains(e.Id)".
> Note:
> IGrouping<TKey, TElement> is also IEnumerable<TElement> which can be used like this:
>                             List<string> list = new List<string>(DeptGroup);
>                             foreach (string dept in DeptGroup){}
> because DeptGroup is also implement IEnumerable<TElement> which is IEnumerable<string>
> Suggestion: to build the SQL IN statement do not only look for collection, List or Array type but also any of IEnumerable<TElement> with method Contains().

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://216.121.112.228/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[nhibernate-issues] [NHJIRA] Created: (NH-2762) Failed to use IGrouping<TKey, TElement>.Contains() from Lookup to make SQL IN statement

[Mazlan (JIRA) <nh...@gm...>]

Failed to use IGrouping<TKey, TElement>.Contains() from Lookup to make SQL IN statement
---------------------------------------------------------------------------------------

                 Key: NH-2762
                 URL: http://216.121.112.228/browse/NH-2762
             Project:  NHibernate
          Issue Type: Bug
          Components: Linq Provider
    Affects Versions: 3.2.0Beta1, 3.2.0Alpha3, 3.2.0Alpha2, 3.2.0Alpha1, 3.1.0, 3.0.0.GA, 3.0.0.CR1, 3.0.0.Beta2, 3.0.0.Beta1, 3.0.0.Alpha3, 3.0.0.Alpha2, 3.0.0.Alpha1, 2.1.2.GA, 2.1.1.GA,  2.0.1.GA, 1.2.1, 3.2.0Beta2
            Reporter: Mazlan
            Priority: Minor


This bug still happened in current Revision 5914.

Using array, List or collection does not have a problem to make SQL IN statement by using Contains() method.
However NHibernate does not generete SQL IN statement from IGrouping<TKey, TElement> type which is mostly used from ILookup<TKey, TElement>.
It simply pass it to SQL parameter which then will cause GenericADOException.

Reproduce:

                var Emps = (from e in s.Query<Employee>()
                            select e).ToList();

                var EmpsInDept = Emps.ToLookup(e => e.Department, e => e.Id); // e.Department is a type of string.

                foreach (var DeptGroup in EmpsInDept)
                {
                    if (DeptGroup.Key == "IT")
                    {
                        var firstNameInIT = (from e in s.Query<Employee>()
                                             where DeptGroup.Contains(e.Id)
                                             select e.FirstName).ToList();
                    }
                }

The "DeptGroup.Contains(e.Id)" will throw the exception. Currently convert it to a List temporarily fix it "DeptGroup.ToList().Contains(e.Id)".

Note:
IGrouping<TKey, TElement> is also IEnumerable<TElement> which can be used like this:
                            List<string> list = new List<string>(DeptGroup);
                            foreach (string dept in DeptGroup){}

because DeptGroup is also implement IEnumerable<TElement> which is IEnumerable<string>

Suggestion: to build the SQL IN statement do not only look for collection, List or Array type but also any of IEnumerable<TElement> with method Contains().

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://216.121.112.228/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[nhibernate-issues] [NHJIRA] Commented: (NH-2099) Linq Expressions and case sensitivity

[Jose F. R. (JIRA) <nh...@gm...>]

    [ http://216.121.112.228/browse/NH-2099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=21271#action_21271 ] 

Jose F. Romaniello commented on NH-2099:
----------------------------------------

i like what fabio said... +1.
but what would be the behaviour with one parameter?

> Linq Expressions and case sensitivity
> -------------------------------------
>
>                 Key: NH-2099
>                 URL: http://216.121.112.228/browse/NH-2099
>             Project:  NHibernate
>          Issue Type: New Feature
>          Components: Linq Provider
>    Affects Versions: 3.0.0.Alpha1
>            Reporter: Jose F. Romaniello
>            Priority: Minor
>
> The following query:
> persons.Where(p => p.Nombre.StartsWith("a"))
> in objects is case-sensitive. And I would like in nhibernate be case sensitive too.
> otherwise:
> persons.Where(p => p.Nombre.StartsWith("a", StringComparison.OrdinalIgnoreCase))
> In sql server it is possible to change the "coalesce" in the where statement. I don't know for other providers.
> The same for others string operators.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://216.121.112.228/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[nhibernate-issues] [NHJIRA] Commented: (NH-2099) Linq Expressions and case sensitivity

[Fabio M. (JIRA) <nh...@gm...>]

    [ http://216.121.112.228/browse/NH-2099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=21270#action_21270 ] 

Fabio Maulo commented on NH-2099:
---------------------------------

Patrick,
what about this:
- StartsWith found with 2 parameters
- second parameter is StringComparison.OrdinalIgnoreCase
then apply "ilike" HQL function.

We have to register "ilike" as default HQL-function in base Dialect and then each dialect can override it with a specific "implementation".

Thoughts ?

> Linq Expressions and case sensitivity
> -------------------------------------
>
>                 Key: NH-2099
>                 URL: http://216.121.112.228/browse/NH-2099
>             Project:  NHibernate
>          Issue Type: New Feature
>          Components: Linq Provider
>    Affects Versions: 3.0.0.Alpha1
>            Reporter: Jose F. Romaniello
>            Priority: Minor
>
> The following query:
> persons.Where(p => p.Nombre.StartsWith("a"))
> in objects is case-sensitive. And I would like in nhibernate be case sensitive too.
> otherwise:
> persons.Where(p => p.Nombre.StartsWith("a", StringComparison.OrdinalIgnoreCase))
> In sql server it is possible to change the "coalesce" in the where statement. I don't know for other providers.
> The same for others string operators.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://216.121.112.228/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira