Menu
▾
▴
nhibernate-issues — Updates to JIRA issues are sent to this list
You can subscribe to this list here.
| 2006 |
Jan
|
Feb
|
Mar
|
Apr
|
May
|
Jun
|
Jul
|
Aug
|
Sep
|
Oct
(110) |
Nov
(296) |
Dec
(107) |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 2007 |
Jan
(212) |
Feb
(263) |
Mar
(161) |
Apr
(183) |
May
(183) |
Jun
(75) |
Jul
(106) |
Aug
(88) |
Sep
(227) |
Oct
(143) |
Nov
(154) |
Dec
(53) |
| 2008 |
Jan
(77) |
Feb
|
Mar
|
Apr
(6) |
May
(103) |
Jun
(296) |
Jul
(54) |
Aug
|
Sep
(379) |
Oct
(283) |
Nov
(224) |
Dec
(214) |
| 2009 |
Jan
(129) |
Feb
(257) |
Mar
(136) |
Apr
(12) |
May
(329) |
Jun
(434) |
Jul
(375) |
Aug
(171) |
Sep
|
Oct
|
Nov
|
Dec
(54) |
| 2010 |
Jan
(198) |
Feb
(76) |
Mar
(3) |
Apr
(1) |
May
|
Jun
(62) |
Jul
(210) |
Aug
(447) |
Sep
(330) |
Oct
(257) |
Nov
(133) |
Dec
(453) |
| 2011 |
Jan
(240) |
Feb
(128) |
Mar
(442) |
Apr
(320) |
May
(428) |
Jun
(141) |
Jul
(13) |
Aug
|
Sep
|
Oct
|
Nov
|
Dec
|
|
From: NHibernate J. <mik...@us...> - 2006-10-24 04:41:42
|
[ http://jira.nhibernate.org/browse/NH-767?page=all ] Sergey Koshcheyev closed NH-767: -------------------------------- Resolution: Fixed This is fixed in the current SVN already. I don't know of a workaround... > Delete fails when using nullable component properties > ----------------------------------------------------- > > Key: NH-767 > URL: http://jira.nhibernate.org/browse/NH-767 > Project: NHibernate > Type: Bug > Components: Core > Versions: 1.2.0.Beta1 > Reporter: Lukas Macedo > Priority: Trivial > > On the AbstractEntityPersister class, the GenerateDeleteStrings(object[] loadedState) method has an issue when dealing with entities that have been mapped with components where component properties can be null. See the code below: > bool include = versionability[i] && > IsPropertyOfTable(i, j); > if (include) > { > // this property belongs to the table and it is not specifically > // excluded from optimistic locking by optimistic-lock="false" > string[] propertyColumnNames = GetPropertyColumnNames(i); > if (loadedState[i] == null) > { > for (int k = 0; k < propertyColumnNames.Length; k++) > { > delete.AddWhereFragment(propertyColumnNames[k] + " is null"); > } > } > else > { > delete.AddWhereFragment(propertyColumnNames, PropertyTypes[i], " = "); > } > } > The problem is that the component property "loadedState[i]" itself will never be null and therefore when using optmistic-lock, it will end up generating a sql statement where fields are compared to null like this one: "field_one = null" this will fail and reported as stale data exception. The same issue applies to the method that generates update string when using optimistic-lock and components. > Is there any workaround? > Thank you, > Lukas -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.nhibernate.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
|
From: NHibernate J. <mik...@us...> - 2006-10-24 01:09:34
|
[ http://jira.nhibernate.org/browse/NH-767?page=comments#action_14157 ] Lukas Macedo commented on NH-767: --------------------------------- I set the priority as trivial, but it should be critical. > Delete fails when using nullable component properties > ----------------------------------------------------- > > Key: NH-767 > URL: http://jira.nhibernate.org/browse/NH-767 > Project: NHibernate > Type: Bug > Components: Core > Versions: 1.2.0.Beta1 > Reporter: Lukas Macedo > Priority: Trivial > > On the AbstractEntityPersister class, the GenerateDeleteStrings(object[] loadedState) method has an issue when dealing with entities that have been mapped with components where component properties can be null. See the code below: > bool include = versionability[i] && > IsPropertyOfTable(i, j); > if (include) > { > // this property belongs to the table and it is not specifically > // excluded from optimistic locking by optimistic-lock="false" > string[] propertyColumnNames = GetPropertyColumnNames(i); > if (loadedState[i] == null) > { > for (int k = 0; k < propertyColumnNames.Length; k++) > { > delete.AddWhereFragment(propertyColumnNames[k] + " is null"); > } > } > else > { > delete.AddWhereFragment(propertyColumnNames, PropertyTypes[i], " = "); > } > } > The problem is that the component property "loadedState[i]" itself will never be null and therefore when using optmistic-lock, it will end up generating a sql statement where fields are compared to null like this one: "field_one = null" this will fail and reported as stale data exception. The same issue applies to the method that generates update string when using optimistic-lock and components. > Is there any workaround? > Thank you, > Lukas -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.nhibernate.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
|
From: NHibernate J. <mik...@us...> - 2006-10-24 01:07:35
|
[ http://jira.nhibernate.org/browse/NH-768?page=comments#action_14156 ] Lukas Macedo commented on NH-768: --------------------------------- I set the priority as trivial, but it should be critical. > Delete fails when using optimistic-lock and bags > ------------------------------------------------ > > Key: NH-768 > URL: http://jira.nhibernate.org/browse/NH-768 > Project: NHibernate > Type: Bug > Components: Core > Versions: 1.2.0.Beta1 > Reporter: Lukas Macedo > Priority: Trivial > > It adds an extra AND without any element or value where the bag is. > For example: > <class name="TABLE" table="TABLENAME"> > <id name="RowId" type="Guid" column="RowId" optimistic-lock="dirty" dynamic-update="true" dynamic-insert="true"> > <generator class="guid" /> > </id> > <bag name="LocationQuantitySummaryList" lazy="true" inverse="true" cascade="none"> > <key column="R_LOCATION"/> > <one-to-many class="LocationQuantitySummary"/> > </bag> > <property name="UserDefinedCode6" column="UserDefinedCode_6"/> > </class> > If you try to delete this entity, it will end up with the following statement: > DELETE FROM TABLENAME WHERE ROWID = 'XXX' AND AND USERDEFINEDCODE_6 = "TEST" > Thanks, > Lukas -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.nhibernate.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
|
From: NHibernate J. <mik...@us...> - 2006-10-24 01:04:35
|
Delete fails when using optimistic-lock and bags
------------------------------------------------
Key: NH-768
URL: http://jira.nhibernate.org/browse/NH-768
Project: NHibernate
Type: Bug
Components: Core
Versions: 1.2.0.Beta1
Reporter: Lukas Macedo
Priority: Trivial
It adds an extra AND without any element or value where the bag is.
For example:
<class name="TABLE" table="TABLENAME">
<id name="RowId" type="Guid" column="RowId" optimistic-lock="dirty" dynamic-update="true" dynamic-insert="true">
<generator class="guid" />
</id>
<bag name="LocationQuantitySummaryList" lazy="true" inverse="true" cascade="none">
<key column="R_LOCATION"/>
<one-to-many class="LocationQuantitySummary"/>
</bag>
<property name="UserDefinedCode6" column="UserDefinedCode_6"/>
</class>
If you try to delete this entity, it will end up with the following statement:
DELETE FROM TABLENAME WHERE ROWID = 'XXX' AND AND USERDEFINEDCODE_6 = "TEST"
Thanks,
Lukas
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.nhibernate.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
|
|
From: NHibernate J. <mik...@us...> - 2006-10-23 21:07:43
|
Delete fails when using nullable component properties
-----------------------------------------------------
Key: NH-767
URL: http://jira.nhibernate.org/browse/NH-767
Project: NHibernate
Type: Bug
Components: Core
Versions: 1.2.0.Beta1
Reporter: Lukas Macedo
Priority: Trivial
On the AbstractEntityPersister class, the GenerateDeleteStrings(object[] loadedState) method has an issue when dealing with entities that have been mapped with components where component properties can be null. See the code below:
bool include = versionability[i] &&
IsPropertyOfTable(i, j);
if (include)
{
// this property belongs to the table and it is not specifically
// excluded from optimistic locking by optimistic-lock="false"
string[] propertyColumnNames = GetPropertyColumnNames(i);
if (loadedState[i] == null)
{
for (int k = 0; k < propertyColumnNames.Length; k++)
{
delete.AddWhereFragment(propertyColumnNames[k] + " is null");
}
}
else
{
delete.AddWhereFragment(propertyColumnNames, PropertyTypes[i], " = ");
}
}
The problem is that the component property "loadedState[i]" itself will never be null and therefore when using optmistic-lock, it will end up generating a sql statement where fields are compared to null like this one: "field_one = null" this will fail and reported as stale data exception. The same issue applies to the method that generates update string when using optimistic-lock and components.
Is there any workaround?
Thank you,
Lukas
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.nhibernate.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
|
|
From: NHibernate J. <mik...@us...> - 2006-10-23 14:09:32
|
[ http://jira.nhibernate.org/browse/NH-766?page=comments#action_14155 ] Kirk Wylie commented on NH-766: ------------------------------- Created Hibernate request http://opensource.atlassian.com/projects/hibernate/browse/HHH-2170 to track. > Avoid joins on <composite-key><key-many-to-one> queries > ------------------------------------------------------- > > Key: NH-766 > URL: http://jira.nhibernate.org/browse/NH-766 > Project: NHibernate > Type: Improvement > Components: Core > Versions: 1.0.2 > Reporter: Kirk Wylie > Priority: Trivial > > This is being promoted from something I posted on the NHibernate forums. > Using NHibernate 1.0.2.0 against Oracle 9. > I'm working with an existing schema which isn't using surrogate keys, and I have a composite key of the form: > <class name="CalculatedRating" ...> > <composite-id> > <key-property name="EffectiveDate" column="EFFECTIVE_DATE"/> > <key-many-to-one name="FdeOrganization" column="ORGANIZATION_ID" .../> > </composite-id> > ... > </class> > Using this query: > from CalculatedRating cr > inner join fetch cr.FdeOrganization fdeOrg > left join fetch fdeOrg.Attributes as attribute > inner join fetch attribute.AttributeType > where cr.EffectiveDate = > (select max(cr2.EffectiveDate) > from CalculatedRating cr2 > where cr2.EffectiveDate >= :EffectiveDate) > order by cr.FdeOrganization.OrgId > NHibernate is quite correctly generating the SQL necessary to completely manifest the CalculatedRating element in a single query. However, after executing that query, it then still proceeds to do the N+1 select on FdeOrganization. > As in this application I'm actually using quite a few cases where I'm successfully using the inner join fetch technique against FdeOrganization, I can only assume that this is a problem related to key-many-to-one rather than many-to-one. > After further investigation, I can establish that Hibernate 3.1.3 exposes the exact same functionality. I'm filing this first against NHibernate since that's where I first discovered it, however, since it affects Hibernate as well it might be better filed against that, and I can do so if needed. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.nhibernate.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
|
From: NHibernate J. <mik...@us...> - 2006-10-23 14:07:35
|
[ http://jira.nhibernate.org/browse/NH-765?page=comments#action_14154 ] Kailuo Wang commented on NH-765: -------------------------------- It will be used when in debug. ToString() helps debugger understand what and how the criteria consists of. > Use "(" and ")" to enclose the ToString of LogicalExpression.cs > --------------------------------------------------------------- > > Key: NH-765 > URL: http://jira.nhibernate.org/browse/NH-765 > Project: NHibernate > Type: Patch > Components: Core > Versions: 1.2.0.Beta1 > Reporter: Kailuo Wang > Priority: Trivial > Fix For: 1.2.0.Beta2 > Attachments: LogicExpressionToString.patch > > - return _lhs.ToString() + ' ' + Op + ' ' + _rhs.ToString(); > + return "(" + _lhs.ToString() + ' ' + Op + ' ' + _rhs.ToString() + ")"; -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.nhibernate.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
|
From: NHibernate J. <mik...@us...> - 2006-10-23 13:56:36
|
[ http://jira.nhibernate.org/browse/NH-766?page=comments#action_14153 ] Sergey Koshcheyev commented on NH-766: -------------------------------------- Hibernate is probably better, once/if it will be fixed in Hibernate I can then port the fix. > Avoid joins on <composite-key><key-many-to-one> queries > ------------------------------------------------------- > > Key: NH-766 > URL: http://jira.nhibernate.org/browse/NH-766 > Project: NHibernate > Type: Improvement > Components: Core > Versions: 1.0.2 > Reporter: Kirk Wylie > Priority: Trivial > > This is being promoted from something I posted on the NHibernate forums. > Using NHibernate 1.0.2.0 against Oracle 9. > I'm working with an existing schema which isn't using surrogate keys, and I have a composite key of the form: > <class name="CalculatedRating" ...> > <composite-id> > <key-property name="EffectiveDate" column="EFFECTIVE_DATE"/> > <key-many-to-one name="FdeOrganization" column="ORGANIZATION_ID" .../> > </composite-id> > ... > </class> > Using this query: > from CalculatedRating cr > inner join fetch cr.FdeOrganization fdeOrg > left join fetch fdeOrg.Attributes as attribute > inner join fetch attribute.AttributeType > where cr.EffectiveDate = > (select max(cr2.EffectiveDate) > from CalculatedRating cr2 > where cr2.EffectiveDate >= :EffectiveDate) > order by cr.FdeOrganization.OrgId > NHibernate is quite correctly generating the SQL necessary to completely manifest the CalculatedRating element in a single query. However, after executing that query, it then still proceeds to do the N+1 select on FdeOrganization. > As in this application I'm actually using quite a few cases where I'm successfully using the inner join fetch technique against FdeOrganization, I can only assume that this is a problem related to key-many-to-one rather than many-to-one. > After further investigation, I can establish that Hibernate 3.1.3 exposes the exact same functionality. I'm filing this first against NHibernate since that's where I first discovered it, however, since it affects Hibernate as well it might be better filed against that, and I can do so if needed. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.nhibernate.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
|
From: NHibernate J. <mik...@us...> - 2006-10-23 13:54:35
|
[ http://jira.nhibernate.org/browse/NH-766?page=comments#action_14152 ] Kirk Wylie commented on NH-766: ------------------------------- I can try to, but extracting one given a relatively proprietary schema (that I had to extract things out of above) might take some time. Given that it affects Hibernate as well, and I'm going to that effort, do you recommend doing that in Hibernate (JUnit) or NHibernate (NUnit)? > Avoid joins on <composite-key><key-many-to-one> queries > ------------------------------------------------------- > > Key: NH-766 > URL: http://jira.nhibernate.org/browse/NH-766 > Project: NHibernate > Type: Improvement > Components: Core > Versions: 1.0.2 > Reporter: Kirk Wylie > Priority: Trivial > > This is being promoted from something I posted on the NHibernate forums. > Using NHibernate 1.0.2.0 against Oracle 9. > I'm working with an existing schema which isn't using surrogate keys, and I have a composite key of the form: > <class name="CalculatedRating" ...> > <composite-id> > <key-property name="EffectiveDate" column="EFFECTIVE_DATE"/> > <key-many-to-one name="FdeOrganization" column="ORGANIZATION_ID" .../> > </composite-id> > ... > </class> > Using this query: > from CalculatedRating cr > inner join fetch cr.FdeOrganization fdeOrg > left join fetch fdeOrg.Attributes as attribute > inner join fetch attribute.AttributeType > where cr.EffectiveDate = > (select max(cr2.EffectiveDate) > from CalculatedRating cr2 > where cr2.EffectiveDate >= :EffectiveDate) > order by cr.FdeOrganization.OrgId > NHibernate is quite correctly generating the SQL necessary to completely manifest the CalculatedRating element in a single query. However, after executing that query, it then still proceeds to do the N+1 select on FdeOrganization. > As in this application I'm actually using quite a few cases where I'm successfully using the inner join fetch technique against FdeOrganization, I can only assume that this is a problem related to key-many-to-one rather than many-to-one. > After further investigation, I can establish that Hibernate 3.1.3 exposes the exact same functionality. I'm filing this first against NHibernate since that's where I first discovered it, however, since it affects Hibernate as well it might be better filed against that, and I can do so if needed. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.nhibernate.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
|
From: NHibernate J. <mik...@us...> - 2006-10-23 13:52:33
|
[ http://jira.nhibernate.org/browse/NH-766?page=comments#action_14151 ] Sergey Koshcheyev commented on NH-766: -------------------------------------- Can you supply a small simple NUnit test case? > Avoid joins on <composite-key><key-many-to-one> queries > ------------------------------------------------------- > > Key: NH-766 > URL: http://jira.nhibernate.org/browse/NH-766 > Project: NHibernate > Type: Improvement > Components: Core > Versions: 1.0.2 > Reporter: Kirk Wylie > Priority: Trivial > > This is being promoted from something I posted on the NHibernate forums. > Using NHibernate 1.0.2.0 against Oracle 9. > I'm working with an existing schema which isn't using surrogate keys, and I have a composite key of the form: > <class name="CalculatedRating" ...> > <composite-id> > <key-property name="EffectiveDate" column="EFFECTIVE_DATE"/> > <key-many-to-one name="FdeOrganization" column="ORGANIZATION_ID" .../> > </composite-id> > ... > </class> > Using this query: > from CalculatedRating cr > inner join fetch cr.FdeOrganization fdeOrg > left join fetch fdeOrg.Attributes as attribute > inner join fetch attribute.AttributeType > where cr.EffectiveDate = > (select max(cr2.EffectiveDate) > from CalculatedRating cr2 > where cr2.EffectiveDate >= :EffectiveDate) > order by cr.FdeOrganization.OrgId > NHibernate is quite correctly generating the SQL necessary to completely manifest the CalculatedRating element in a single query. However, after executing that query, it then still proceeds to do the N+1 select on FdeOrganization. > As in this application I'm actually using quite a few cases where I'm successfully using the inner join fetch technique against FdeOrganization, I can only assume that this is a problem related to key-many-to-one rather than many-to-one. > After further investigation, I can establish that Hibernate 3.1.3 exposes the exact same functionality. I'm filing this first against NHibernate since that's where I first discovered it, however, since it affects Hibernate as well it might be better filed against that, and I can do so if needed. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.nhibernate.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
|
From: NHibernate J. <mik...@us...> - 2006-10-23 13:45:41
|
[ http://jira.nhibernate.org/browse/NH-761?page=all ] Sergey Koshcheyev closed NH-761: -------------------------------- Resolution: Fixed > Change ISession.Get() to initialize a proxy if it returns one, like in H3.2 > --------------------------------------------------------------------------- > > Key: NH-761 > URL: http://jira.nhibernate.org/browse/NH-761 > Project: NHibernate > Type: Improvement > Components: Core > Versions: 1.2.0.Beta1 > Reporter: Sergey Koshcheyev > Priority: Trivial > Fix For: 1.2.0.Beta2 > -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.nhibernate.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
|
From: NHibernate J. <mik...@us...> - 2006-10-23 13:43:36
|
Avoid joins on <composite-key><key-many-to-one> queries
-------------------------------------------------------
Key: NH-766
URL: http://jira.nhibernate.org/browse/NH-766
Project: NHibernate
Type: Improvement
Components: Core
Versions: 1.0.2
Reporter: Kirk Wylie
Priority: Trivial
This is being promoted from something I posted on the NHibernate forums.
Using NHibernate 1.0.2.0 against Oracle 9.
I'm working with an existing schema which isn't using surrogate keys, and I have a composite key of the form:
<class name="CalculatedRating" ...>
<composite-id>
<key-property name="EffectiveDate" column="EFFECTIVE_DATE"/>
<key-many-to-one name="FdeOrganization" column="ORGANIZATION_ID" .../>
</composite-id>
...
</class>
Using this query:
from CalculatedRating cr
inner join fetch cr.FdeOrganization fdeOrg
left join fetch fdeOrg.Attributes as attribute
inner join fetch attribute.AttributeType
where cr.EffectiveDate =
(select max(cr2.EffectiveDate)
from CalculatedRating cr2
where cr2.EffectiveDate >= :EffectiveDate)
order by cr.FdeOrganization.OrgId
NHibernate is quite correctly generating the SQL necessary to completely manifest the CalculatedRating element in a single query. However, after executing that query, it then still proceeds to do the N+1 select on FdeOrganization.
As in this application I'm actually using quite a few cases where I'm successfully using the inner join fetch technique against FdeOrganization, I can only assume that this is a problem related to key-many-to-one rather than many-to-one.
After further investigation, I can establish that Hibernate 3.1.3 exposes the exact same functionality. I'm filing this first against NHibernate since that's where I first discovered it, however, since it affects Hibernate as well it might be better filed against that, and I can do so if needed.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.nhibernate.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
|
|
From: NHibernate J. <mik...@us...> - 2006-10-23 07:11:30
|
[ http://jira.nhibernate.org/browse/NH-765?page=all ] Sergey Koshcheyev closed NH-765: -------------------------------- Fix Version: 1.2.0.Beta2 Resolution: Fixed > Use "(" and ")" to enclose the ToString of LogicalExpression.cs > --------------------------------------------------------------- > > Key: NH-765 > URL: http://jira.nhibernate.org/browse/NH-765 > Project: NHibernate > Type: Patch > Components: Core > Versions: 1.2.0.Beta1 > Reporter: Kailuo Wang > Priority: Trivial > Fix For: 1.2.0.Beta2 > Attachments: LogicExpressionToString.patch > > - return _lhs.ToString() + ' ' + Op + ' ' + _rhs.ToString(); > + return "(" + _lhs.ToString() + ' ' + Op + ' ' + _rhs.ToString() + ")"; -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.nhibernate.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
|
From: NHibernate J. <mik...@us...> - 2006-10-23 07:00:32
|
[ http://jira.nhibernate.org/browse/NH-765?page=comments#action_14150 ] Sergey Koshcheyev commented on NH-765: -------------------------------------- I will add it, but ToString() isn't used anywhere, so I don't understand why you want it changed. > Use "(" and ")" to enclose the ToString of LogicalExpression.cs > --------------------------------------------------------------- > > Key: NH-765 > URL: http://jira.nhibernate.org/browse/NH-765 > Project: NHibernate > Type: Patch > Components: Core > Versions: 1.2.0.Beta1 > Reporter: Kailuo Wang > Priority: Trivial > Attachments: LogicExpressionToString.patch > > - return _lhs.ToString() + ' ' + Op + ' ' + _rhs.ToString(); > + return "(" + _lhs.ToString() + ' ' + Op + ' ' + _rhs.ToString() + ")"; -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.nhibernate.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
|
From: NHibernate J. <mik...@us...> - 2006-10-23 01:49:22
|
[ http://jira.nhibernate.org/browse/NH-765?page=comments#action_14140 ] Kailuo Wang commented on NH-765: -------------------------------- An extremely simple patch :). > Use "(" and ")" to enclose the ToString of LogicalExpression.cs > --------------------------------------------------------------- > > Key: NH-765 > URL: http://jira.nhibernate.org/browse/NH-765 > Project: NHibernate > Type: Patch > Components: Core > Versions: 1.2.0.Beta1 > Reporter: Kailuo Wang > Priority: Trivial > Attachments: LogicExpressionToString.patch > > - return _lhs.ToString() + ' ' + Op + ' ' + _rhs.ToString(); > + return "(" + _lhs.ToString() + ' ' + Op + ' ' + _rhs.ToString() + ")"; -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.nhibernate.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
|
From: NHibernate J. <mik...@us...> - 2006-10-23 01:47:22
|
Use "(" and ")" to enclose the ToString of LogicalExpression.cs
---------------------------------------------------------------
Key: NH-765
URL: http://jira.nhibernate.org/browse/NH-765
Project: NHibernate
Type: Patch
Components: Core
Versions: 1.2.0.Beta1
Reporter: Kailuo Wang
Priority: Trivial
Attachments: LogicExpressionToString.patch
- return _lhs.ToString() + ' ' + Op + ' ' + _rhs.ToString();
+ return "(" + _lhs.ToString() + ' ' + Op + ' ' + _rhs.ToString() + ")";
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.nhibernate.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
|
35 messages has been excluded from this view by a project administrator.
