nhibernate-issues — Updates to JIRA issues are sent to this list

[nhibernate-issues] [NHJIRA] Commented: (NH-2637) NHibernate.Properties.BasicPropertyAccessor.GetSetterOrNull is case sensitive

[Igor K. (JIRA) <nh...@gm...>]

    [ http://216.121.112.228/browse/NH-2637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=20886#action_20886 ] 

Igor Krupin commented on NH-2637:
---------------------------------

No no no! I downloaded source code to NHibernate 2.1 (the one we are using), and here's what I see:

The method is GetSetterOrNull in BasicPropertyAccessor:

// the BindingFlags.IgnoreCase is important here because if type is a struct, the GetProperty method does
// not ignore case by default. If type is a class, it _does_ ignore case... we're better off explicitly
// stating that casing should be ignored so we get the same behavior for both structs and classes
PropertyInfo property = type.GetProperty(propertyName, BindingFlags.Instance | BindingFlags.Public | BindingFlags.NonPublic | BindingFlags.DeclaredOnly | BindingFlags.IgnoreCase);

==================================
Once again, the comment is incorrect, but the code used to work! Why? Because even though the assumption that by default GetProperty is case insensitive is incorrect the flag IgnoreCase has been added anyway.

==================================
This is a breaking change! We cannot upgrade to 3.1 because of this. I read all the change logs and nowhere does it mention that a "new feature" or whatever has been introduced whereby the properties-to-columns are now case sensitive!!!

==================================
"You can specify the alias in your query or you can implement your AliasToEntityResultTransformer." - We have production tables with hundreds of columns, and we have tens of production projects using those tables. We cannot go and change our queries now all over the place, only b/c we want 3.1 to work.

> NHibernate.Properties.BasicPropertyAccessor.GetSetterOrNull is case sensitive
> -----------------------------------------------------------------------------
>
>                 Key: NH-2637
>                 URL: http://216.121.112.228/browse/NH-2637
>             Project:  NHibernate
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 3.1.0
>            Reporter: Igor Krupin
>            Priority: Major
>         Attachments: Capture.PNG
>
>
> We are running NH 2.1 and discovered this bug trying to upgrade to NH 3.1. We do a lot of AliasToBean stuff, mapping tables to DTOs, and AliasToBean will call this method to get the properties. Problem is, it's case sensitive now! Reading code comments i see this:
> ============ <CODE SNIPPET> ================
> 			BindingFlags bindingFlags = BindingFlags.Instance | BindingFlags.Public | BindingFlags.NonPublic | BindingFlags.DeclaredOnly;
> 			if (type.IsValueType)
> 			{
> 				// the BindingFlags.IgnoreCase is important here because if type is a struct, the GetProperty method does
> 				// not ignore case by default. If type is a class, it _does_ ignore case... we're better off explicitly
> 				// stating that casing should be ignored so we get the same behavior for both structs and classes
> 				bindingFlags = bindingFlags | BindingFlags.IgnoreCase;
> 			}
> ============ </CODE SNIPPET> ================
> "If type is a class, it _does_ ignore case..." -- incorrect. By default in classes case will _not_ be ignored, you explicitly have to specify it using a flag, same as you do for value type.
> The fix for this is rather simple, just add the BindingFlags.IgnoreCase flag and all's good. No need for the "if (type.IsValueType)" anymore either. GetGetterOrNull suffers from the same.
> Thank You!!!
> Igor

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://216.121.112.228/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[nhibernate-issues] [NHJIRA] Assigned: (NH-2214) Distinct and Row_number problem

[Julian M. (JIRA) <nh...@gm...>]

     [ http://216.121.112.228/browse/NH-2214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Julian Maughan reassigned NH-2214:
----------------------------------

    Assignee: Julian Maughan

> Distinct and Row_number problem
> -------------------------------
>
>                 Key: NH-2214
>                 URL: http://216.121.112.228/browse/NH-2214
>             Project:  NHibernate
>          Issue Type: Bug
>          Components: DataProviders / Dialects
>    Affects Versions: 2.1.1.GA, 2.1.2.GA
>            Reporter: Carlos Martinez
>            Assignee: Julian Maughan
>            Priority: Major
>         Attachments: MsSql2005Dialect.cs, NH-2214-reproduction.zip, NH-2214.patch, NH-2214.patch, NH-2214.zip
>
>
> Microsoft.NET Framework 3.5
> MSSQL 2008
> Select distinct T.ID, T.Name from T
> inner join T2 on T.ID = T2.TID
> order by T.Name
> With this native query (using ISQLQuery) and the statement "DISTINCT" is necessary because the union wiht T2 produces duplicate results of T. 
> if I use
> SetFirstResult(index)
> SetMaxResults(max)
> It generates the following Query
> Select top max
>   ID,
>   Name  
>   from
>         (select distinct
>           ID,
>           Name,
>           ROW_NUMBER () over (order by T.Name) as __hibernate_sort_row
>           from T
>           inner join T2) as query
>     where __hibernate_sort_row > index
> first results are generated with ROW_NUMER, for example
> T.ID  T.Name   __hibernate_sort_row
> 2     Carlos   1
> 1     Juan     2
> 1     Juan     3
> 3     Paulina  4
> 4     Zunio    5
> 4     Zunio    6
> 4     Zunio    7
> Then "DISTINCT" no longer makes sense, because all records are different due to ROW_NUMBER.
> In version 2.0.1 GA works perfectly

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://216.121.112.228/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[nhibernate-issues] [NHJIRA] Commented: (NH-2587) .Cacheable().Fetch() throws 'Exception occurred getter of xxx' Options

[Mark J. (JIRA) <nh...@gm...>]

    [ http://216.121.112.228/browse/NH-2587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=20885#action_20885 ] 

Mark Jerzykowski commented on NH-2587:
--------------------------------------

I'd just like to add my voice to the raising of the priority of this bug.

It does make using Linq essentially impossible in anything other than simple apps/queries.

> .Cacheable().Fetch() throws 'Exception occurred getter of xxx' Options 
> -----------------------------------------------------------------------
>
>                 Key: NH-2587
>                 URL: http://216.121.112.228/browse/NH-2587
>             Project:  NHibernate
>          Issue Type: Bug
>          Components: Linq Provider
>    Affects Versions: 3.1.0
>            Reporter: Eduardo Segura
>            Priority: Minor
>         Attachments: CacheableFetchTest.zip
>
>
> This query:
> IList<ParentObject> pos = session.Query<ParentObject>().Cacheable().Fetch(po => po.ChildObjects).ToList();
> throws this exception:
> NHibernate.PropertyAccessException: Exception occurred getter of CacheableFetchTest.Entity`1[[System.Guid, mscorlib, Version=2.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089]].Id --->  System.Reflection.TargetException: Object does not match target type.. 
> For a detailed discussion, including full exception stacks, please see:
> http://groups.google.com/group/nhusers/browse_thread/thread/dfdbe987d8450b0a/cb812c856e07ee0a

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://216.121.112.228/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[nhibernate-issues] [NHJIRA] Commented: (NH-2638) Id Property With Private Setter Not Set With Lazy Classes

[Ricardo P. (JIRA) <nh...@gm...>]

    [ http://216.121.112.228/browse/NH-2638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=20884#action_20884 ] 

Ricardo Peres commented on NH-2638:
-----------------------------------

Fabio,
There is no difference. The mapping by code is working well. That is not the problem, you have done an excellent job in that.
The problem I am having seems to me related with lazy entities. NH-2639 is the same, I think.
If you have time, and interest, please check my demo project: http://cid-0450c015fc418de2.office.live.com/self.aspx/.Public/NHTest.zip. I may be doing something wrong, but I don't think so... I have always (since .NET 3.5, that is) used auto properties, even for ids, and I never had this problem. It is not critical to me, so if you have more urgent things do do, it's fine by me! I only wished I had confirmation from someone else that there is a problem.
Thanks!

> Id Property With Private Setter Not Set With Lazy Classes
> ---------------------------------------------------------
>
>                 Key: NH-2638
>                 URL: http://216.121.112.228/browse/NH-2638
>             Project:  NHibernate
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 3.2.0Alpha1
>            Reporter: Ricardo Peres
>         Attachments: Test.cs
>
>
> When I have a class with a private id setter, if the class is lazy, then the id is not set.
> No exception occurs, it simply is not set. Mapping is done with the new mapping by code.
> Tested with the trunk version, as of 00:00.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://216.121.112.228/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[nhibernate-issues] [NHJIRA] Commented: (NH-2638) Id Property With Private Setter Not Set With Lazy Classes

[Fabio M. (JIRA) <nh...@gm...>]

    [ http://216.121.112.228/browse/NH-2638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=20883#action_20883 ] 

Fabio Maulo commented on NH-2638:
---------------------------------

And which is the difference between the mapping through XML and the XML of the mapping by-code ?
To see the XML you can use:
var mapping = mapper.CompileMappingForAllExplicitAddedEntities();
Console.WriteLine(mapping.AsString());

> Id Property With Private Setter Not Set With Lazy Classes
> ---------------------------------------------------------
>
>                 Key: NH-2638
>                 URL: http://216.121.112.228/browse/NH-2638
>             Project:  NHibernate
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 3.2.0
>            Reporter: Ricardo Peres
>         Attachments: Test.cs
>
>
> When I have a class with a private id setter, if the class is lazy, then the id is not set.
> No exception occurs, it simply is not set. Mapping is done with the new mapping by code.
> Tested with the trunk version, as of 00:00.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://216.121.112.228/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[nhibernate-issues] [NHJIRA] Commented: (NH-2638) Id Property With Private Setter Not Set With Lazy Classes

[Ricardo P. (JIRA) <nh...@gm...>]

    [ http://216.121.112.228/browse/NH-2638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=20882#action_20882 ] 

Ricardo Peres commented on NH-2638:
-----------------------------------

Test project is here: http://cid-0450c015fc418de2.office.live.com/self.aspx/.Public/NHTest.zip.

> Id Property With Private Setter Not Set With Lazy Classes
> ---------------------------------------------------------
>
>                 Key: NH-2638
>                 URL: http://216.121.112.228/browse/NH-2638
>             Project:  NHibernate
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 3.2.0
>            Reporter: Ricardo Peres
>         Attachments: Test.cs
>
>
> When I have a class with a private id setter, if the class is lazy, then the id is not set.
> No exception occurs, it simply is not set. Mapping is done with the new mapping by code.
> Tested with the trunk version, as of 00:00.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://216.121.112.228/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[nhibernate-issues] [NHJIRA] Commented: (NH-2639) Collection Is Null In Lazy Class

[Ricardo P. (JIRA) <nh...@gm...>]

    [ http://216.121.112.228/browse/NH-2639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=20881#action_20881 ] 

Ricardo Peres commented on NH-2639:
-----------------------------------

Test project is here: http://cid-0450c015fc418de2.office.live.com/self.aspx/.Public/NHTest.zip.

> Collection Is Null In Lazy Class
> --------------------------------
>
>                 Key: NH-2639
>                 URL: http://216.121.112.228/browse/NH-2639
>             Project:  NHibernate
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 3.2.0
>            Reporter: Ricardo Peres
>         Attachments: Test2.cs
>
>
> A declared is declared as lazy and has a set property also lazy. When loading an entity, the set property is null. Mapping is made with the trunk version of by code mapping.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://216.121.112.228/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[nhibernate-issues] [NHJIRA] Commented: (NH-2639) Collection Is Null In Lazy Class

[Ricardo P. (JIRA) <nh...@gm...>]

    [ http://216.121.112.228/browse/NH-2639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=20880#action_20880 ] 

Ricardo Peres commented on NH-2639:
-----------------------------------

Fabio,
Yes, I am always learning, from you and others, but I know what inverse is... and I don't have inverse=true on both sides. Did you look at the code? Even if I had, that wouldn't explain why it works when the class is not lazy, and not when it is lazy. I asked about this on nhusers, nobody answered.

> Collection Is Null In Lazy Class
> --------------------------------
>
>                 Key: NH-2639
>                 URL: http://216.121.112.228/browse/NH-2639
>             Project:  NHibernate
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 3.2.0
>            Reporter: Ricardo Peres
>         Attachments: Test2.cs
>
>
> A declared is declared as lazy and has a set property also lazy. When loading an entity, the set property is null. Mapping is made with the trunk version of by code mapping.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://216.121.112.228/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[nhibernate-issues] [NHJIRA] Assigned: (NH-2533) Support paging in HQL

[Patrick E. (JIRA) <nh...@gm...>]

     [ http://216.121.112.228/browse/NH-2533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Patrick Earl reassigned NH-2533:
--------------------------------

    Assignee: Patrick Earl

> Support paging in HQL
> ---------------------
>
>                 Key: NH-2533
>                 URL: http://216.121.112.228/browse/NH-2533
>             Project:  NHibernate
>          Issue Type: New Feature
>          Components: Core
>    Affects Versions: 3.0.0.GA
>            Reporter: Patrick Earl
>            Assignee: Patrick Earl
>            Priority: Minor
>
> As per the discussion on the mailing list, this would add [SKIP x] [TAKE y] after the order by clause.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://216.121.112.228/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[nhibernate-issues] [NHJIRA] Commented: (NH-2214) Distinct and Row_number problem

[david (JIRA) <nh...@gm...>]

    [ http://216.121.112.228/browse/NH-2214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=20879#action_20879 ] 

david commented on NH-2214:
---------------------------

Hi, I also notice this in the new version too. 

I still have to use my work around (Custom SQL dialect) to get around this :-(

http://www.webdevbros.net/2010/11/11/nhibernate-returns-duplicate-results-on-paged-data-sets-work-around/

> Distinct and Row_number problem
> -------------------------------
>
>                 Key: NH-2214
>                 URL: http://216.121.112.228/browse/NH-2214
>             Project:  NHibernate
>          Issue Type: Bug
>          Components: DataProviders / Dialects
>    Affects Versions: 2.1.1.GA, 2.1.2.GA
>            Reporter: Carlos Martinez
>            Priority: Major
>         Attachments: MsSql2005Dialect.cs, NH-2214-reproduction.zip, NH-2214.patch, NH-2214.patch, NH-2214.zip
>
>
> Microsoft.NET Framework 3.5
> MSSQL 2008
> Select distinct T.ID, T.Name from T
> inner join T2 on T.ID = T2.TID
> order by T.Name
> With this native query (using ISQLQuery) and the statement "DISTINCT" is necessary because the union wiht T2 produces duplicate results of T. 
> if I use
> SetFirstResult(index)
> SetMaxResults(max)
> It generates the following Query
> Select top max
>   ID,
>   Name  
>   from
>         (select distinct
>           ID,
>           Name,
>           ROW_NUMBER () over (order by T.Name) as __hibernate_sort_row
>           from T
>           inner join T2) as query
>     where __hibernate_sort_row > index
> first results are generated with ROW_NUMER, for example
> T.ID  T.Name   __hibernate_sort_row
> 2     Carlos   1
> 1     Juan     2
> 1     Juan     3
> 3     Paulina  4
> 4     Zunio    5
> 4     Zunio    6
> 4     Zunio    7
> Then "DISTINCT" no longer makes sense, because all records are different due to ROW_NUMBER.
> In version 2.0.1 GA works perfectly

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://216.121.112.228/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[nhibernate-issues] [NHJIRA] Commented: (NH-2634) NHibernate generates wrong select-query

[Kirill M. (JIRA) <nh...@gm...>]

    [ http://216.121.112.228/browse/NH-2634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=20878#action_20878 ] 

Kirill Medvedev commented on NH-2634:
-------------------------------------

Thank you for advice, I've checked it. Removing all collections' mappings didn't make any affect, exception appeared as before. But after removing 

   <many-to-one name="DefaultItemSupplier" class="ItemSupplier" not-null="false" cascade="save-update" update="false" lazy="true">
     <column name="ItemId"/>
     <column name="DefaultSupplierID"/>
   </many-to-one>

query completed without exceptions. Therefore, problem is in this many-to-one mapping part.

The most strange is that query 

   session.QueryOver<Item>().Take(100).List();

generates correct TSQL query and results are correct too. DefaultItemSupplier property is initialized as expected. But if I add Skip() restriction, exception occurs.

> NHibernate generates wrong select-query
> ---------------------------------------
>
>                 Key: NH-2634
>                 URL: http://216.121.112.228/browse/NH-2634
>             Project:  NHibernate
>          Issue Type: Bug
>          Components: Core, QueryOver
>    Affects Versions: 3.1.0
>            Reporter: Kirill Medvedev
>            Priority: Minor
>         Attachments: NH_Bug.zip
>
>
> While transferring legacy project to NHibernate I found a bug... Nhibernate generates wrong SELECT query => GenericADOException occurs. See attachment. Thank you.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://216.121.112.228/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[nhibernate-issues] [NHJIRA] Commented: (NH-2638) Id Property With Private Setter Not Set With Lazy Classes

[Ricardo P. (JIRA) <nh...@gm...>]

    [ http://216.121.112.228/browse/NH-2638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=20877#action_20877 ] 

Ricardo Peres commented on NH-2638:
-----------------------------------

Fabio,
No, I don't: I have specified all five of them (Field, Property, None, NoSetter and ReadOnly), you can try it yourself. The property is never set.
It does work if mapped through hbm.xml, without any problems. It the class is not lazy, then I don't even need to specify the accessor.

> Id Property With Private Setter Not Set With Lazy Classes
> ---------------------------------------------------------
>
>                 Key: NH-2638
>                 URL: http://216.121.112.228/browse/NH-2638
>             Project:  NHibernate
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 3.2.0
>            Reporter: Ricardo Peres
>         Attachments: Test.cs
>
>
> When I have a class with a private id setter, if the class is lazy, then the id is not set.
> No exception occurs, it simply is not set. Mapping is done with the new mapping by code.
> Tested with the trunk version, as of 00:00.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://216.121.112.228/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[nhibernate-issues] [NHJIRA] Commented: (NH-2587) .Cacheable().Fetch() throws 'Exception occurred getter of xxx' Options

[Łukasz P. (J. <nh...@gm...>]

    [ http://216.121.112.228/browse/NH-2587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=20876#action_20876 ] 

Łukasz Podolak commented on NH-2587:
------------------------------------

I am stuck as well. This bug makes in most cases Linq provider useless. What I am doing now is converting all queries that need fetching + cache to QueryOver or Criteria. 
This should definitely not be a Minor

> .Cacheable().Fetch() throws 'Exception occurred getter of xxx' Options 
> -----------------------------------------------------------------------
>
>                 Key: NH-2587
>                 URL: http://216.121.112.228/browse/NH-2587
>             Project:  NHibernate
>          Issue Type: Bug
>          Components: Linq Provider
>    Affects Versions: 3.1.0
>            Reporter: Eduardo Segura
>            Priority: Minor
>         Attachments: CacheableFetchTest.zip
>
>
> This query:
> IList<ParentObject> pos = session.Query<ParentObject>().Cacheable().Fetch(po => po.ChildObjects).ToList();
> throws this exception:
> NHibernate.PropertyAccessException: Exception occurred getter of CacheableFetchTest.Entity`1[[System.Guid, mscorlib, Version=2.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089]].Id --->  System.Reflection.TargetException: Object does not match target type.. 
> For a detailed discussion, including full exception stacks, please see:
> http://groups.google.com/group/nhusers/browse_thread/thread/dfdbe987d8450b0a/cb812c856e07ee0a

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://216.121.112.228/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[nhibernate-issues] [NHJIRA] Updated: (NH-2214) Distinct and Row_number problem

[Mario D. L. (JIRA) <nh...@gm...>]

     [ http://216.121.112.228/browse/NH-2214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mario Dal Lago updated NH-2214:
-------------------------------

    Attachment: NH-2214.zip

Simple test case showing the issue

> Distinct and Row_number problem
> -------------------------------
>
>                 Key: NH-2214
>                 URL: http://216.121.112.228/browse/NH-2214
>             Project:  NHibernate
>          Issue Type: Bug
>          Components: DataProviders / Dialects
>    Affects Versions: 2.1.1.GA, 2.1.2.GA
>            Reporter: Carlos Martinez
>            Priority: Major
>         Attachments: MsSql2005Dialect.cs, NH-2214-reproduction.zip, NH-2214.patch, NH-2214.patch, NH-2214.zip
>
>
> Microsoft.NET Framework 3.5
> MSSQL 2008
> Select distinct T.ID, T.Name from T
> inner join T2 on T.ID = T2.TID
> order by T.Name
> With this native query (using ISQLQuery) and the statement "DISTINCT" is necessary because the union wiht T2 produces duplicate results of T. 
> if I use
> SetFirstResult(index)
> SetMaxResults(max)
> It generates the following Query
> Select top max
>   ID,
>   Name  
>   from
>         (select distinct
>           ID,
>           Name,
>           ROW_NUMBER () over (order by T.Name) as __hibernate_sort_row
>           from T
>           inner join T2) as query
>     where __hibernate_sort_row > index
> first results are generated with ROW_NUMER, for example
> T.ID  T.Name   __hibernate_sort_row
> 2     Carlos   1
> 1     Juan     2
> 1     Juan     3
> 3     Paulina  4
> 4     Zunio    5
> 4     Zunio    6
> 4     Zunio    7
> Then "DISTINCT" no longer makes sense, because all records are different due to ROW_NUMBER.
> In version 2.0.1 GA works perfectly

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://216.121.112.228/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[nhibernate-issues] [NHJIRA] Closed: (NH-2638) Id Property With Private Setter Not Set With Lazy Classes

[Fabio M. (JIRA) <nh...@gm...>]

     [ http://216.121.112.228/browse/NH-2638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Fabio Maulo closed NH-2638.
---------------------------

    Resolution: Not an Issue

Wrong mapping.
You have to specify the accessor of the Id property.

> Id Property With Private Setter Not Set With Lazy Classes
> ---------------------------------------------------------
>
>                 Key: NH-2638
>                 URL: http://216.121.112.228/browse/NH-2638
>             Project:  NHibernate
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 3.2.0
>            Reporter: Ricardo Peres
>         Attachments: Test.cs
>
>
> When I have a class with a private id setter, if the class is lazy, then the id is not set.
> No exception occurs, it simply is not set. Mapping is done with the new mapping by code.
> Tested with the trunk version, as of 00:00.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://216.121.112.228/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[nhibernate-issues] [NHJIRA] Closed: (NH-2637) NHibernate.Properties.BasicPropertyAccessor.GetSetterOrNull is case sensitive

[Fabio M. (JIRA) <nh...@gm...>]

     [ http://216.121.112.228/browse/NH-2637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Fabio Maulo closed NH-2637.
---------------------------

    Resolution: Not an Issue

It is by design because properties and fields are case-sensitive in .NET and if you have a property called "FirstName" with a field called "firstName" the default transformer have to know to which one it have to access. 
You can specify the alias in your query or you can implement your AliasToEntityResultTransformer.

> NHibernate.Properties.BasicPropertyAccessor.GetSetterOrNull is case sensitive
> -----------------------------------------------------------------------------
>
>                 Key: NH-2637
>                 URL: http://216.121.112.228/browse/NH-2637
>             Project:  NHibernate
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 3.1.0
>            Reporter: Igor Krupin
>            Priority: Major
>         Attachments: Capture.PNG
>
>
> We are running NH 2.1 and discovered this bug trying to upgrade to NH 3.1. We do a lot of AliasToBean stuff, mapping tables to DTOs, and AliasToBean will call this method to get the properties. Problem is, it's case sensitive now! Reading code comments i see this:
> ============ <CODE SNIPPET> ================
> 			BindingFlags bindingFlags = BindingFlags.Instance | BindingFlags.Public | BindingFlags.NonPublic | BindingFlags.DeclaredOnly;
> 			if (type.IsValueType)
> 			{
> 				// the BindingFlags.IgnoreCase is important here because if type is a struct, the GetProperty method does
> 				// not ignore case by default. If type is a class, it _does_ ignore case... we're better off explicitly
> 				// stating that casing should be ignored so we get the same behavior for both structs and classes
> 				bindingFlags = bindingFlags | BindingFlags.IgnoreCase;
> 			}
> ============ </CODE SNIPPET> ================
> "If type is a class, it _does_ ignore case..." -- incorrect. By default in classes case will _not_ be ignored, you explicitly have to specify it using a flag, same as you do for value type.
> The fix for this is rather simple, just add the BindingFlags.IgnoreCase flag and all's good. No need for the "if (type.IsValueType)" anymore either. GetGetterOrNull suffers from the same.
> Thank You!!!
> Igor

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://216.121.112.228/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[nhibernate-issues] [NHJIRA] Commented: (NH-2214) Distinct and Row_number problem

[Fabio M. (JIRA) <nh...@gm...>]

    [ http://216.121.112.228/browse/NH-2214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=20872#action_20872 ] 

Fabio Maulo commented on NH-2214:
---------------------------------

@Mario
Perhaps the test ?

> Distinct and Row_number problem
> -------------------------------
>
>                 Key: NH-2214
>                 URL: http://216.121.112.228/browse/NH-2214
>             Project:  NHibernate
>          Issue Type: Bug
>          Components: DataProviders / Dialects
>    Affects Versions: 2.1.1.GA, 2.1.2.GA
>            Reporter: Carlos Martinez
>            Priority: Major
>         Attachments: MsSql2005Dialect.cs, NH-2214-reproduction.zip, NH-2214.patch, NH-2214.patch
>
>
> Microsoft.NET Framework 3.5
> MSSQL 2008
> Select distinct T.ID, T.Name from T
> inner join T2 on T.ID = T2.TID
> order by T.Name
> With this native query (using ISQLQuery) and the statement "DISTINCT" is necessary because the union wiht T2 produces duplicate results of T. 
> if I use
> SetFirstResult(index)
> SetMaxResults(max)
> It generates the following Query
> Select top max
>   ID,
>   Name  
>   from
>         (select distinct
>           ID,
>           Name,
>           ROW_NUMBER () over (order by T.Name) as __hibernate_sort_row
>           from T
>           inner join T2) as query
>     where __hibernate_sort_row > index
> first results are generated with ROW_NUMER, for example
> T.ID  T.Name   __hibernate_sort_row
> 2     Carlos   1
> 1     Juan     2
> 1     Juan     3
> 3     Paulina  4
> 4     Zunio    5
> 4     Zunio    6
> 4     Zunio    7
> Then "DISTINCT" no longer makes sense, because all records are different due to ROW_NUMBER.
> In version 2.0.1 GA works perfectly

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://216.121.112.228/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[nhibernate-issues] [NHJIRA] Closed: (NH-2639) Collection Is Null In Lazy Class

[Fabio M. (JIRA) <nh...@gm...>]

     [ http://216.121.112.228/browse/NH-2639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Fabio Maulo closed NH-2639.
---------------------------

    Resolution: Not an Issue

Wrong mapping.
The relation is mapped if inverse=true in both sides.
Ricardo,
if you are learning NHibernate before use the mapping by XML or by-code you have to read our documentation.
The other possibility is the usage of ConfORM project.

> Collection Is Null In Lazy Class
> --------------------------------
>
>                 Key: NH-2639
>                 URL: http://216.121.112.228/browse/NH-2639
>             Project:  NHibernate
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 3.2.0
>            Reporter: Ricardo Peres
>         Attachments: Test2.cs
>
>
> A declared is declared as lazy and has a set property also lazy. When loading an entity, the set property is null. Mapping is made with the trunk version of by code mapping.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://216.121.112.228/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[nhibernate-issues] [NHJIRA] Commented: (NH-2214) Distinct and Row_number problem

[Mario D. L. (JIRA) <nh...@gm...>]

    [ http://216.121.112.228/browse/NH-2214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=20870#action_20870 ] 

Mario Dal Lago commented on NH-2214:
------------------------------------

In NHibernate 3.0.0.2002 the issue still exists. My question is the same as the last comment. Is there any reason that this patch was not applied to NH 3.xx?

Thanks.

Mario Dal Lago

> Distinct and Row_number problem
> -------------------------------
>
>                 Key: NH-2214
>                 URL: http://216.121.112.228/browse/NH-2214
>             Project:  NHibernate
>          Issue Type: Bug
>          Components: DataProviders / Dialects
>    Affects Versions: 2.1.1.GA, 2.1.2.GA
>            Reporter: Carlos Martinez
>            Priority: Major
>         Attachments: MsSql2005Dialect.cs, NH-2214-reproduction.zip, NH-2214.patch, NH-2214.patch
>
>
> Microsoft.NET Framework 3.5
> MSSQL 2008
> Select distinct T.ID, T.Name from T
> inner join T2 on T.ID = T2.TID
> order by T.Name
> With this native query (using ISQLQuery) and the statement "DISTINCT" is necessary because the union wiht T2 produces duplicate results of T. 
> if I use
> SetFirstResult(index)
> SetMaxResults(max)
> It generates the following Query
> Select top max
>   ID,
>   Name  
>   from
>         (select distinct
>           ID,
>           Name,
>           ROW_NUMBER () over (order by T.Name) as __hibernate_sort_row
>           from T
>           inner join T2) as query
>     where __hibernate_sort_row > index
> first results are generated with ROW_NUMER, for example
> T.ID  T.Name   __hibernate_sort_row
> 2     Carlos   1
> 1     Juan     2
> 1     Juan     3
> 3     Paulina  4
> 4     Zunio    5
> 4     Zunio    6
> 4     Zunio    7
> Then "DISTINCT" no longer makes sense, because all records are different due to ROW_NUMBER.
> In version 2.0.1 GA works perfectly

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://216.121.112.228/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[nhibernate-issues] [NHJIRA] Resolved: (NH-2526) Sybase ASE 15 support

[Julian M. (JIRA) <nh...@gm...>]

     [ http://216.121.112.228/browse/NH-2526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Julian Maughan resolved NH-2526.
--------------------------------

       Resolution: Fixed
    Fix Version/s: 3.2.0
         Assignee:     (was: Julian Maughan)

I've committed a driver and dialect for Sybase ASE 15 (r5649). I spent quite a bit of time messing about with it, and seeing how many tests would pass. One point I'm confused about is that the Hibernate version, and the attached, have support for temporary tables enabled. I found that ASE does not allow temporary tables to be created inside a transaction. This causes many test failures in NH, so I have disabled it in our dialect. See the code for more details.

> Sybase ASE 15 support
> ---------------------
>
>                 Key: NH-2526
>                 URL: http://216.121.112.228/browse/NH-2526
>             Project:  NHibernate
>          Issue Type: Improvement
>          Components: DataProviders / Dialects
>    Affects Versions: 3.0.0.GA
>            Reporter: Jim Hale Jr.
>            Priority: Major
>             Fix For: 3.2.0
>
>         Attachments: SybaseAdoNet2ClientDriver.cs, SybaseAse15Dialect.cs
>
>
> The 3.0.0 release banished Sybase ASE users for reasons unknown to me.  I understand the criticism of the 2.x and 3.0.0 release candidate implementations of the Sybase ASE dialect (yes they were bad), but at least they let ASE users use NHibernate.  Better to have basic but functional support than no support at all.  This is especially important for ASE users considering the lack of Entity support by Sybase for ASE.  Removing ASE support forced NHibernate users to stay with the 2.12 release or pay for an Entity aware provider.  The comments I read regarding the removal of ASE support - specifically regarding the merging of the ASE and ASA dialects - also make no sense to me.  ASA and ASE are two different products with different keywords, SQL syntax, functions, and drivers.  Their dialects cannot be merged!  Same with the supposed support from the MS SQL 2000 dialect - this dialect uses MS keywords like 'TOP' that ASE does not support.
> Attached is a port of the Sybase ASE Dialect from the Java Hibernate project along with support for the ADO.NET driver provided by Sybase.  I am using it in a project currently and it at least appears to work.  I am only using the most basic of NHibernate features though so additional testing would be nice.  But it provides a start.
> Tested against Sybase 15.0.3.0 using .NET 4.0 runtime and Sybase.AdoNet2.AseClient.dll driver (version 1.15.305.0).

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://216.121.112.228/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[nhibernate-issues] [NHJIRA] Resolved: (NH-2514) CLONE -log4net DEBUG enabled and the query parameters Log parameters problem

[Julian M. (JIRA) <nh...@gm...>]

     [ http://216.121.112.228/browse/NH-2514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Julian Maughan resolved NH-2514.
--------------------------------

    Resolution: Cannot Reproduce

> CLONE -log4net DEBUG enabled and the query parameters Log parameters problem
> ----------------------------------------------------------------------------
>
>                 Key: NH-2514
>                 URL: http://216.121.112.228/browse/NH-2514
>             Project:  NHibernate
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 3.0.0.Alpha1
>            Reporter: Joao Braganca
>            Priority: Major
>         Attachments: gorbach-NHibernateSandbox-d80415c.zip
>
>
> Hi,
> You have a problem in for example HQLQueryPlan class for example method void PerformList(QueryParameters queryParameters, ISessionImplementor session, IList results)
> when the log debug is on.
> if (log.IsDebugEnabled)
> {
> 	log.Debug("find: " + SourceQuery);
> 	queryParameters.LogParameters(session.Factory);
> }
> LogParameters method is throwing an exception in certain cases. The exception is the following:
> Could not execute query[SQL: SQL not available]
> NHibernate.Exceptions.GenericADOException: Could not execute query[SQL: SQL not available] ---> System.InvalidCastException: Unable to cast object of type 'System.Int32' to type 'System.String'.
>    at NHibernate.Type.AbstractStringType.ToString(Object val) in C:\Program Files\NHibernatesvn\trunk\nhibernate\src\NHibernate\Type\AbstractStringType.cs:line 32
>    at NHibernate.Type.NullableType.ToLoggableString(Object value, ISessionFactoryImplementor factory) in C:\Program Files\NHibernatesvn\trunk\nhibernate\src\NHibernate\Type\NullableType.cs:line 109
>    at NHibernate.Impl.Printer.ToString(IDictionary`2 namedTypedValues) in C:\Program Files\NHibernatesvn\trunk\nhibernate\src\NHibernate\Impl\Printer.cs:line 71
>    at NHibernate.Engine.QueryParameters.LogParameters(ISessionFactoryImplementor factory) in C:\Program Files\NHibernatesvn\trunk\nhibernate\src\NHibernate\Engine\QueryParameters.cs:line 213
>    at NHibernate.Engine.Query.HQLQueryPlan.PerformList(QueryParameters queryParameters, ISessionImplementor session, IList results) in C:\Program Files\NHibernatesvn\trunk\nhibernate\src\NHibernate\Engine\Query\HQLQueryPlan.cs:line 254
>    at NHibernate.Impl.SessionImpl.List(String query, QueryParameters queryParameters, IList results) in C:\Program Files\NHibernatesvn\trunk\nhibernate\src\NHibernate\Impl\SessionImpl.cs:line 629
>   
> Do you want me to create the unit test? I did not want to since the unit test will simply pass since for it not to pass, you must change the App.config to use the following
> settings:
> <log4net debug="true">
> <root>
> 	<priority value="DEBUG" />
> 	<appender-ref ref="console" />
> </root>

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://216.121.112.228/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[nhibernate-issues] [NHJIRA] Commented: (NH-2514) CLONE -log4net DEBUG enabled and the query parameters Log parameters problem

[Alexey G. (JIRA) <nh...@gm...>]

    [ http://216.121.112.228/browse/NH-2514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=20868#action_20868 ] 

Alexey Gorbach commented on NH-2514:
------------------------------------

I cannot reproduce it on NHibernate 3.1, so it is not obsolete.

> CLONE -log4net DEBUG enabled and the query parameters Log parameters problem
> ----------------------------------------------------------------------------
>
>                 Key: NH-2514
>                 URL: http://216.121.112.228/browse/NH-2514
>             Project:  NHibernate
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 3.0.0.Alpha1
>            Reporter: Joao Braganca
>            Priority: Major
>         Attachments: gorbach-NHibernateSandbox-d80415c.zip
>
>
> Hi,
> You have a problem in for example HQLQueryPlan class for example method void PerformList(QueryParameters queryParameters, ISessionImplementor session, IList results)
> when the log debug is on.
> if (log.IsDebugEnabled)
> {
> 	log.Debug("find: " + SourceQuery);
> 	queryParameters.LogParameters(session.Factory);
> }
> LogParameters method is throwing an exception in certain cases. The exception is the following:
> Could not execute query[SQL: SQL not available]
> NHibernate.Exceptions.GenericADOException: Could not execute query[SQL: SQL not available] ---> System.InvalidCastException: Unable to cast object of type 'System.Int32' to type 'System.String'.
>    at NHibernate.Type.AbstractStringType.ToString(Object val) in C:\Program Files\NHibernatesvn\trunk\nhibernate\src\NHibernate\Type\AbstractStringType.cs:line 32
>    at NHibernate.Type.NullableType.ToLoggableString(Object value, ISessionFactoryImplementor factory) in C:\Program Files\NHibernatesvn\trunk\nhibernate\src\NHibernate\Type\NullableType.cs:line 109
>    at NHibernate.Impl.Printer.ToString(IDictionary`2 namedTypedValues) in C:\Program Files\NHibernatesvn\trunk\nhibernate\src\NHibernate\Impl\Printer.cs:line 71
>    at NHibernate.Engine.QueryParameters.LogParameters(ISessionFactoryImplementor factory) in C:\Program Files\NHibernatesvn\trunk\nhibernate\src\NHibernate\Engine\QueryParameters.cs:line 213
>    at NHibernate.Engine.Query.HQLQueryPlan.PerformList(QueryParameters queryParameters, ISessionImplementor session, IList results) in C:\Program Files\NHibernatesvn\trunk\nhibernate\src\NHibernate\Engine\Query\HQLQueryPlan.cs:line 254
>    at NHibernate.Impl.SessionImpl.List(String query, QueryParameters queryParameters, IList results) in C:\Program Files\NHibernatesvn\trunk\nhibernate\src\NHibernate\Impl\SessionImpl.cs:line 629
>   
> Do you want me to create the unit test? I did not want to since the unit test will simply pass since for it not to pass, you must change the App.config to use the following
> settings:
> <log4net debug="true">
> <root>
> 	<priority value="DEBUG" />
> 	<appender-ref ref="console" />
> </root>

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://216.121.112.228/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[nhibernate-issues] [NHJIRA] Resolved: (NH-2604) Problem with MSTest and Relinq (possibly due to ILMerge)

[Patrick E. (JIRA) <nh...@gm...>]

     [ http://216.121.112.228/browse/NH-2604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Patrick Earl resolved NH-2604.
------------------------------

       Resolution: Fixed
    Fix Version/s: 3.2.0

> Problem with MSTest and Relinq (possibly due to ILMerge)
> --------------------------------------------------------
>
>                 Key: NH-2604
>                 URL: http://216.121.112.228/browse/NH-2604
>             Project:  NHibernate
>          Issue Type: Bug
>          Components: Linq Provider
>    Affects Versions: 3.1.0
>            Reporter: Patrick Earl
>            Assignee: Patrick Earl
>             Fix For: 3.2.0
>
>
> See these discussions.
> https://groups.google.com/group/nhusers/browse_thread/thread/c7729f6d56dc022f?hl=es
> http://groups.google.com/group/nhibernate-development/browse_thread/thread/d120472a38644a8
> This issue needs to be reported to the Remotion team.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://216.121.112.228/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[nhibernate-issues] [NHJIRA] Resolved: (NH-2608) Integrate Remotion 1.13.100 to fix duplicate mscorlib problem

[Patrick E. (JIRA) <nh...@gm...>]

     [ http://216.121.112.228/browse/NH-2608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Patrick Earl resolved NH-2608.
------------------------------

       Resolution: Fixed
    Fix Version/s: 3.2.0

> Integrate Remotion 1.13.100 to fix duplicate mscorlib problem
> -------------------------------------------------------------
>
>                 Key: NH-2608
>                 URL: http://216.121.112.228/browse/NH-2608
>             Project:  NHibernate
>          Issue Type: Task
>          Components: Linq Provider
>    Affects Versions: 3.1.0
>            Reporter: Patrick Earl
>            Assignee: Patrick Earl
>             Fix For: 3.2.0
>
>


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://216.121.112.228/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[nhibernate-issues] [NHJIRA] Created: (NH-2639) Collection Is Null In Lazy Class

[Ricardo P. (JIRA) <nh...@gm...>]

Collection Is Null In Lazy Class
--------------------------------

                 Key: NH-2639
                 URL: http://216.121.112.228/browse/NH-2639
             Project:  NHibernate
          Issue Type: Bug
          Components: Core
    Affects Versions: 3.2.0
            Reporter: Ricardo Peres
         Attachments: Test2.cs

A declared is declared as lazy and has a set property also lazy. When loading an entity, the set property is null. Mapping is made with the trunk version of by code mapping.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://216.121.112.228/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira