nhibernate-issues — Updates to JIRA issues are sent to this list

[nhibernate-issues] [NHJIRA] Commented: (NH-2668) REOPEN: Version properties which are NULL in the database cause exceptions during a delete or update

[Fabio M. (JIRA) <nh...@gm...>]

    [ http://216.121.112.228/browse/NH-2668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=20948#action_20948 ] 

Fabio Maulo commented on NH-2668:
---------------------------------

That is because the version property shouldn't be null.
This is not a bug in NH you have only dirty values, not wrote using NH, in your DB.

> REOPEN: Version properties which are NULL in the database cause exceptions during a delete or update
> ----------------------------------------------------------------------------------------------------
>
>                 Key: NH-2668
>                 URL: http://216.121.112.228/browse/NH-2668
>             Project:  NHibernate
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 2.1.2.GA, 3.0.0.Alpha1, 3.0.0.Alpha2, 3.0.0.Alpha3, 3.0.0.Beta1, 3.0.0.Beta2, 3.0.0.CR1, 3.0.0.GA, 3.1.0, 3.2.0Alpha1, 3.2.0Alpha2
>            Reporter: Mike Pontillo
>            Priority: Major
>         Attachments: NH2667-fix.patch, NH2667-TestCases.patch
>
>
> Reopening NH-2667 as a new defect since it appears that I cannot reopen it myself. NH-2667 was closed before I could even attach the test case. Please don't close this yet; let the test case speak for itself. 
> I tried using unsaved-value and it did not work. There are, in fact, bugs here.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://216.121.112.228/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[nhibernate-issues] [NHJIRA] Updated: (NH-2668) REOPEN: Version properties which are NULL in the database cause exceptions during a delete or update

[Mike P. (JIRA) <nh...@gm...>]

     [ http://216.121.112.228/browse/NH-2668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mike Pontillo updated NH-2668:
------------------------------

    Attachment: NH2667-fix.patch

This is my tentative fix for the problem.

There are three issues:

(1) The IsOptional or IsNullable property needs to be set on the version Mapping.Property, or NHibernate will validate it incorrectly (at least, in my test case) because it thinks there should be a non-NULL constraint on the column. I am not sure what the correct fix is, but adding the line in RootClassBinder worked for me.

(2) Versioning always assumes a non-null version property.

(3) AbstractEntityPersister makes several assumptions that the version property is not null.

> REOPEN: Version properties which are NULL in the database cause exceptions during a delete or update
> ----------------------------------------------------------------------------------------------------
>
>                 Key: NH-2668
>                 URL: http://216.121.112.228/browse/NH-2668
>             Project:  NHibernate
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 2.1.2.GA, 3.0.0.Alpha1, 3.0.0.Alpha2, 3.0.0.Alpha3, 3.0.0.Beta1, 3.0.0.Beta2, 3.0.0.CR1, 3.0.0.GA, 3.1.0, 3.2.0Alpha1, 3.2.0Alpha2
>            Reporter: Mike Pontillo
>            Priority: Major
>         Attachments: NH2667-fix.patch, NH2667-TestCases.patch
>
>
> Reopening NH-2667 as a new defect since it appears that I cannot reopen it myself. NH-2667 was closed before I could even attach the test case. Please don't close this yet; let the test case speak for itself. 
> I tried using unsaved-value and it did not work. There are, in fact, bugs here.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://216.121.112.228/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[nhibernate-issues] [NHJIRA] Created: (NH-2668) REOPEN: Version properties which are NULL in the database cause exceptions during a delete or update

[Mike P. (JIRA) <nh...@gm...>]

REOPEN: Version properties which are NULL in the database cause exceptions during a delete or update
----------------------------------------------------------------------------------------------------

                 Key: NH-2668
                 URL: http://216.121.112.228/browse/NH-2668
             Project:  NHibernate
          Issue Type: Bug
          Components: Core
    Affects Versions: 3.2.0Alpha2, 3.2.0Alpha1, 3.1.0, 3.0.0.GA, 3.0.0.CR1, 3.0.0.Beta2, 3.0.0.Beta1, 3.0.0.Alpha3, 3.0.0.Alpha2, 3.0.0.Alpha1, 2.1.2.GA
            Reporter: Mike Pontillo
            Priority: Major
         Attachments: NH2667-TestCases.patch

Reopening NH-2667 as a new defect since it appears that I cannot reopen it myself. NH-2667 was closed before I could even attach the test case. Please don't close this yet; let the test case speak for itself. 

I tried using unsaved-value and it did not work. There are, in fact, bugs here.


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://216.121.112.228/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[nhibernate-issues] [NHJIRA] Closed: (NH-2665) Formula on Many-to-one pointing to a composite-keyed entity don't work

[Fabio M. (JIRA) <nh...@gm...>]

     [ http://216.121.112.228/browse/NH-2665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Fabio Maulo closed NH-2665.
---------------------------

    Resolution: Not an Issue

You can map the formula per each expected parts of the compisite-id.

<many-to-one name="Blah">
<formula>formula for the first element of the id</formula>
<formula>formula for the second element of the id</formula>
</many-to-one>


> Formula on Many-to-one pointing to a composite-keyed entity don't work
> ----------------------------------------------------------------------
>
>                 Key: NH-2665
>                 URL: http://216.121.112.228/browse/NH-2665
>             Project:  NHibernate
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 3.2.0Alpha2
>            Reporter: Onur Gumus
>            Priority: Major
>
> Hello, it seems the following mapping won't work
> <many-to-one formula="(select top 1 id1, id2 from SomeEntity")/>
> in this case id1 and id2 are composite Id's for SomeEntity. NHibernate will complain it was expecting two columns while validating the mapping.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://216.121.112.228/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[nhibernate-issues] [NHJIRA] Commented: (NH-2666) CLONE -many-to-one with property-ref makes separate select always

[Fabio M. (JIRA) <nh...@gm...>]

    [ http://216.121.112.228/browse/NH-2666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=20945#action_20945 ] 

Fabio Maulo commented on NH-2666:
---------------------------------

If you see the resolution of NH-1583 it is Open

> CLONE -many-to-one with property-ref makes separate select always
> -----------------------------------------------------------------
>
>                 Key: NH-2666
>                 URL: http://216.121.112.228/browse/NH-2666
>             Project:  NHibernate
>          Issue Type: Bug
>          Components: Core
>    Affects Versions:  2.0.1.GA
>            Reporter: Onur Gumus
>            Priority: Major
>
> I have following tables:
>  - transactions:
>       - id (autogenerated in database); PK;
>       - numcode, for example 840 - numeric currency code;
>       - other columns
>  - currencies:
>       - id - PK, autogenerated;
>       - numcode - unique key
>       - alphacode (for example USD)
>       - decnum;
>       - fullname;
> and mapping for transactions table: 
>     <many-to-one name="numcode" column="numcode" property-ref="numcode" />
> When I'm retrieving transactions NHibernate generates a separate select for currencies table for each row from transactions table. This is very inefficient (N+1 problem).
> Solution is to do eager fetching. After specyfying eager fetching I see that transactions and currencies tables are joined, which means that I'm doing that right. However separate additional fetch in currencies is still occuring for each row in transactions table.
> I've tried both criteria API and HQL.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://216.121.112.228/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[nhibernate-issues] [NHJIRA] Closed: (NH-2667) Version properties which are NULL in the database cause exceptions during a delete or update

[Fabio M. (JIRA) <nh...@gm...>]

     [ http://216.121.112.228/browse/NH-2667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Fabio Maulo closed NH-2667.
---------------------------

    Resolution: Won't Fix

The Version can be null or you have to use the "unsaved-value".
Your legacy DB should have consistent data.

> Version properties which are NULL in the database cause exceptions during a delete or update
> --------------------------------------------------------------------------------------------
>
>                 Key: NH-2667
>                 URL: http://216.121.112.228/browse/NH-2667
>             Project:  NHibernate
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 2.1.2.GA, 3.0.0.Alpha1, 3.0.0.Alpha2, 3.0.0.Alpha3, 3.0.0.Beta1, 3.0.0.Beta2, 3.0.0.CR1, 3.0.0.GA, 3.1.0, 3.2.0Alpha1, 3.2.0Alpha2
>            Reporter: Mike Pontillo
>
> I have a legacy database application which NHibernate must operate side-by-side with, against the same database.
> The legacy application sometimes adds NULL values to version columns. When trying to delete or update such a row, NHibernate throws exceptions. The original issue was documented here:
> http://groups.google.com/group/nhusers/browse_thread/thread/637c7e2bf68b7f17/8b9115bd53edfb99?#8b9115bd53edfb99
> Patch with test cases to follow shortly.
> I also have a patch with a tentative fix, but it may need some additional discussion before it is applied.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://216.121.112.228/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[nhibernate-issues] [NHJIRA] Commented: (NH-2665) Formula on Many-to-one pointing to a composite-keyed entity don't work

[Onur G. (JIRA) <nh...@gm...>]

    [ http://216.121.112.228/browse/NH-2665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=20943#action_20943 ] 

Onur Gumus commented on NH-2665:
--------------------------------

Sorry I use attributes normally. 
above case SomeEntity is a table actually also it is an entity with composite ids.
The problem is Mapping validation process assumes if the many-to-one class has a composite id It must have two columns mapped. This check should be skipped if formula is used. I don't have test case right now but i will prepare one.

> Formula on Many-to-one pointing to a composite-keyed entity don't work
> ----------------------------------------------------------------------
>
>                 Key: NH-2665
>                 URL: http://216.121.112.228/browse/NH-2665
>             Project:  NHibernate
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 3.2.0Alpha2
>            Reporter: Onur Gumus
>            Priority: Major
>
> Hello, it seems the following mapping won't work
> <many-to-one formula="(select top 1 id1, id2 from SomeEntity")/>
> in this case id1 and id2 are composite Id's for SomeEntity. NHibernate will complain it was expecting two columns while validating the mapping.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://216.121.112.228/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[nhibernate-issues] [NHJIRA] Created: (NH-2667) Version properties which are NULL in the database cause exceptions during a delete or update

[Mike P. (JIRA) <nh...@gm...>]

Version properties which are NULL in the database cause exceptions during a delete or update
--------------------------------------------------------------------------------------------

                 Key: NH-2667
                 URL: http://216.121.112.228/browse/NH-2667
             Project:  NHibernate
          Issue Type: Bug
          Components: Core
    Affects Versions: 3.2.0Alpha2, 3.2.0Alpha1, 3.1.0, 3.0.0.GA, 3.0.0.CR1, 3.0.0.Beta2, 3.0.0.Beta1, 3.0.0.Alpha3, 3.0.0.Alpha2, 3.0.0.Alpha1, 2.1.2.GA
            Reporter: Mike Pontillo


I have a legacy database application which NHibernate must operate side-by-side with, against the same database.

The legacy application sometimes adds NULL values to version columns. When trying to delete or update such a row, NHibernate throws exceptions. The original issue was documented here:

http://groups.google.com/group/nhusers/browse_thread/thread/637c7e2bf68b7f17/8b9115bd53edfb99?#8b9115bd53edfb99

Patch with test cases to follow shortly.

I also have a patch with a tentative fix, but it may need some additional discussion before it is applied.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://216.121.112.228/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[nhibernate-issues] [NHJIRA] Commented: (NH-2666) CLONE -many-to-one with property-ref makes separate select always

[Onur G. (JIRA) <nh...@gm...>]

    [ http://216.121.112.228/browse/NH-2666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=20942#action_20942 ] 

Onur Gumus commented on NH-2666:
--------------------------------

If you read the comments on the other issue, it seemed to be fixed. Maybe this is a regression. I was just going to update that issue for affected  versions but couldnt do it.

> CLONE -many-to-one with property-ref makes separate select always
> -----------------------------------------------------------------
>
>                 Key: NH-2666
>                 URL: http://216.121.112.228/browse/NH-2666
>             Project:  NHibernate
>          Issue Type: Bug
>          Components: Core
>    Affects Versions:  2.0.1.GA
>            Reporter: Onur Gumus
>            Priority: Major
>
> I have following tables:
>  - transactions:
>       - id (autogenerated in database); PK;
>       - numcode, for example 840 - numeric currency code;
>       - other columns
>  - currencies:
>       - id - PK, autogenerated;
>       - numcode - unique key
>       - alphacode (for example USD)
>       - decnum;
>       - fullname;
> and mapping for transactions table: 
>     <many-to-one name="numcode" column="numcode" property-ref="numcode" />
> When I'm retrieving transactions NHibernate generates a separate select for currencies table for each row from transactions table. This is very inefficient (N+1 problem).
> Solution is to do eager fetching. After specyfying eager fetching I see that transactions and currencies tables are joined, which means that I'm doing that right. However separate additional fetch in currencies is still occuring for each row in transactions table.
> I've tried both criteria API and HQL.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://216.121.112.228/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[nhibernate-issues] [NHJIRA] Closed: (NH-2406) OnPreUpdate event listener doesn't work properly on parent class

[Fabio M. (JIRA) <nh...@gm...>]

     [ http://216.121.112.228/browse/NH-2406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Fabio Maulo closed NH-2406.
---------------------------

    Resolution: Not an Issue

see NH-2596

> OnPreUpdate event listener doesn't work properly on parent class
> ----------------------------------------------------------------
>
>                 Key: NH-2406
>                 URL: http://216.121.112.228/browse/NH-2406
>             Project:  NHibernate
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 3.0.0.Beta2
>            Reporter: Erh-Wen,Kuo
>            Priority: Minor
>
> Parent Class (Properties: Title, CreatedBy, CreatedOn, LastModifiedBy, LastModifiedOn)
>   + Child Class (inherit Parent Class) (Property: Description)
> When an update action only affects "Child Class" for example "Description", even "LastModifiedBy" and "LastModifiedOn" is changed via OnPreUpdateEvent listener, NHibernate will only issue sql to update "Child Class - Description" property. The "LastModifiedBy" and "LastModifiedOn" property in "Parent" class would not be updated.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://216.121.112.228/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[nhibernate-issues] [NHJIRA] Updated: (NH-2535) Patch to always quote aliases in select statements

[Fabio M. (JIRA) <nh...@gm...>]

     [ http://216.121.112.228/browse/NH-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Fabio Maulo updated NH-2535:
----------------------------

    Issue Type: Improvement  (was: Bug)

Please attach something to test what you would have in NH.

> Patch to always quote aliases in select statements
> --------------------------------------------------
>
>                 Key: NH-2535
>                 URL: http://216.121.112.228/browse/NH-2535
>             Project:  NHibernate
>          Issue Type: Improvement
>          Components: DataProviders / Dialects
>    Affects Versions: 3.0.0.GA
>            Reporter: David Schmitt
>            Priority: Minor
>         Attachments: quote-aliases-in-select.patch
>
>
> please find attached a patch to always quote aliases in select statements. I need this to get non-ascii column names (which are re-used in aliases) to work, when running against postgresql-8.4.5 running on windows7.
> In this version/platform, aliases containing non-ascii characters are corrupted on the network stream: the non-ascii character is garbled.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://216.121.112.228/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[nhibernate-issues] [NHJIRA] Commented: (NH-1940) NHibernate.Bytecode inconsistently named

[Fabio M. (JIRA) <nh...@gm...>]

    [ http://216.121.112.228/browse/NH-1940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=20939#action_20939 ] 

Fabio Maulo commented on NH-1940:
---------------------------------

No, as most it can be "Obsolete" because we have removed all ByteCode providers.

> NHibernate.Bytecode inconsistently named
> ----------------------------------------
>
>                 Key: NH-1940
>                 URL: http://216.121.112.228/browse/NH-1940
>             Project:  NHibernate
>          Issue Type: Improvement
>          Components: ByteCode providers, Core
>    Affects Versions: 2.1.0.GA
>            Reporter: Nick Aceves
>
> The NHibernate.Bytecode namespace is not named consistently between NHibernate.dll and NHibernate.ByteCode.Castle.dll.
> NHibernate.dll calls it "NHibernate.Bytecode".
> NHibernate.ByteCode.Castle.dll calls it "NHibernate.ByteCode".
> The only difference between them is the capitalization of the "c" in "Bytecode".
> This has some interesting interplay with what seems to be a bug in ReSharper. ReSharper will only show NHibernate.Bytecode in intellisense, even when NHibernate.ByteCode.Castle.dll is referenced, which led to me spending about 15 minutes figuring out why I couldn't find the Castle ProxyFactoryFactory class.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://216.121.112.228/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[nhibernate-issues] [NHJIRA] Reopened: (NH-2661) NHibernate cannot handle SQL Server TIME columns when built with the .NET 4 framework

[Fabio M. (JIRA) <nh...@gm...>]

     [ http://216.121.112.228/browse/NH-2661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Fabio Maulo reopened NH-2661:
-----------------------------


> NHibernate cannot handle SQL Server TIME columns when built with the .NET 4 framework
> -------------------------------------------------------------------------------------
>
>                 Key: NH-2661
>                 URL: http://216.121.112.228/browse/NH-2661
>             Project:  NHibernate
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 3.1.0
>            Reporter: Neal Groothuis
>            Priority: Minor
>         Attachments: NHibernate.Test-2661.zip
>
>
> In .NET 4, setting a SqlParameter's DbType to Time does not work; it will be set to DateTime instead.  (http://msdn.microsoft.com/en-us/library/system.data.dbtype%28v=VS.100%29.aspx , c.f. http://msdn.microsoft.com/en-us/library/system.data.dbtype%28v=VS.90%29.aspx ).  To set a SqlParameter's DbType to Time, you actually have to set the SqlDbType property to SqlDbType.Time.  
> Unfortunately, this renders NHibernate unable to access TIME columns in the database if being used in .NET 4.0.  

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://216.121.112.228/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[nhibernate-issues] [NHJIRA] Commented: (NH-2665) Formula on Many-to-one pointing to a composite-keyed entity don't work

[Fabio M. (JIRA) <nh...@gm...>]

    [ http://216.121.112.228/browse/NH-2665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=20938#action_20938 ] 

Fabio Maulo commented on NH-2665:
---------------------------------

What you mean ?
where are you using that mapping line where is the mapping of "SomeEntity" ?
many-to-one has <formula> tag (not attribute) and you should use it in case of composite-id.
please attach a failing tests case. 

> Formula on Many-to-one pointing to a composite-keyed entity don't work
> ----------------------------------------------------------------------
>
>                 Key: NH-2665
>                 URL: http://216.121.112.228/browse/NH-2665
>             Project:  NHibernate
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 3.2.0Alpha2
>            Reporter: Onur Gumus
>            Priority: Major
>
> Hello, it seems the following mapping won't work
> <many-to-one formula="(select top 1 id1, id2 from SomeEntity")/>
> in this case id1 and id2 are composite Id's for SomeEntity. NHibernate will complain it was expecting two columns while validating the mapping.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://216.121.112.228/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[nhibernate-issues] [NHJIRA] Closed: (NH-2666) CLONE -many-to-one with property-ref makes separate select always

[Fabio M. (JIRA) <nh...@gm...>]

     [ http://216.121.112.228/browse/NH-2666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Fabio Maulo closed NH-2666.
---------------------------

    Resolution: Duplicate

In your opinion, what mean a clone of a open issue ?

> CLONE -many-to-one with property-ref makes separate select always
> -----------------------------------------------------------------
>
>                 Key: NH-2666
>                 URL: http://216.121.112.228/browse/NH-2666
>             Project:  NHibernate
>          Issue Type: Bug
>          Components: Core
>    Affects Versions:  2.0.1.GA
>            Reporter: Onur Gumus
>            Priority: Major
>
> I have following tables:
>  - transactions:
>       - id (autogenerated in database); PK;
>       - numcode, for example 840 - numeric currency code;
>       - other columns
>  - currencies:
>       - id - PK, autogenerated;
>       - numcode - unique key
>       - alphacode (for example USD)
>       - decnum;
>       - fullname;
> and mapping for transactions table: 
>     <many-to-one name="numcode" column="numcode" property-ref="numcode" />
> When I'm retrieving transactions NHibernate generates a separate select for currencies table for each row from transactions table. This is very inefficient (N+1 problem).
> Solution is to do eager fetching. After specyfying eager fetching I see that transactions and currencies tables are joined, which means that I'm doing that right. However separate additional fetch in currencies is still occuring for each row in transactions table.
> I've tried both criteria API and HQL.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://216.121.112.228/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[nhibernate-issues] [NHJIRA] Closed: (NH-2663) Extension method to generate the Xml-string version of an HbmMapping

[Fabio M. (JIRA) <nh...@gm...>]

     [ http://216.121.112.228/browse/NH-2663?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Fabio Maulo closed NH-2663.
---------------------------

    Resolution: Not an Issue

NHibernate.Mapping.ByCode.MappingsExtensions

> Extension method to generate the Xml-string version of an HbmMapping
> --------------------------------------------------------------------
>
>                 Key: NH-2663
>                 URL: http://216.121.112.228/browse/NH-2663
>             Project:  NHibernate
>          Issue Type: New Feature
>          Components: Core
>    Affects Versions: 3.2.0Alpha2
>            Reporter: Jose F. Romaniello
>
> I think it will be a good idea to add an extension method (or a method) in HbmMapping to generate the XmlVersion of the mappings;
> Otherwise i have write this code lot of times.. for testing-debugging purposes:
> public static class HbmMappingsExtensions
>     {
>         public static string ToXmlString(this HbmMapping mappings)
>         {
>             using (var ms = new MemoryStream())
>             {
>                 var serializer = new XmlSerializer(typeof(HbmMapping));
>                 serializer.Serialize(ms, mappings);
>                 ms.Position = 0;
>                 using (var streamReader = new StreamReader(ms))
>                 {
>                     return streamReader.ReadToEnd();
>                 }
>             }
>         }
>     }

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://216.121.112.228/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[nhibernate-issues] [NHJIRA] Commented: (NH-2577) nhibernate parameters binding order bug

[Patrick E. (JIRA) <nh...@gm...>]

    [ http://216.121.112.228/browse/NH-2577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=20935#action_20935 ] 

Patrick Earl commented on NH-2577:
----------------------------------

There are a lot of votes on this issue, can somebody provide a test case?

> nhibernate parameters binding order bug
> ---------------------------------------
>
>                 Key: NH-2577
>                 URL: http://216.121.112.228/browse/NH-2577
>             Project:  NHibernate
>          Issue Type: Bug
>          Components: Linq Provider
>    Affects Versions: 3.0.0.GA
>            Reporter: sm
>            Priority: Major
>
> I am using latest nhibernate 3, my query:
> iqt = rps.Terminals.GetQuery().Where(x => x.NetProtocol.Id == 4);
> var res = iqt.OrderBy(x => x.Attributes[124]).ToList(); 
> //ITerminal have IDictionary<long,string>
> When i look to the log file i see generated sql:
> SELECT terminal0_.ID       AS ID4_        ,
>   terminal0_.ALIAS          AS ALIAS4_     ,
>   terminal0_.TTYPE_ID       AS TTYPE3_4_   ,
>   terminal0_.IP_ADDRESS     AS IP4_4_      ,
>   terminal0_.STREET         AS STREET4_    ,
>   terminal0_.LOCATION       AS LOCATION4_  ,
>   terminal0_.MODEL_ID       AS MODEL7_4_   ,
>   terminal0_.NODE_ID        AS NODE8_4_    ,
>   terminal0_.NETPROTOCOL_ID AS NETPROTO9_4_,
>   (SELECT (xml_desc(terminal0_.street,'UA'))
>      FROM terminals
>     WHERE terminals.id =terminal0_.Id
>   ) AS formula1_,
>   (SELECT (xml_desc(terminal0_.location,'UA'))
>      FROM terminals
>     WHERE terminals.id =terminal0_.Id
>   ) AS formula2_,
>   (SELECT (xml_desc(terminal_models.description,'EN'))
>      FROM terminal_models
>     WHERE terminal_models.id = terminal0_.MODEL_ID
>   ) AS formula3_
>    FROM TERMINALS terminal0_,
>   TERM_ATTRIBUTES attributes1_
>   WHERE terminal0_.ID        =attributes1_.TERM_ID
> AND attributes1_.ATTR_ID     = :p0
> AND terminal0_.NETPROTOCOL_ID=:p1 //-> bug here it bind p1 with 124 value but correct p0
> ORDER BY attributes1_.VALUE ASC;
> :p0 = 4 [Type: Int64 (0)],
> :p1 = 124 [Type: Int64 (0)]
> I think nhibernate could not correctly resolve parameters bind order with sub selects.
> Thanks a lot

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://216.121.112.228/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[nhibernate-issues] [NHJIRA] Commented: (NH-2648) HQL with joins in sub-select creates wrong SQL

[Harald M. M. (J. <nh...@gm...>]

    [ http://216.121.112.228/browse/NH-2648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=20934#action_20934 ] 

Harald M. Müller commented on NH-2648:
--------------------------------------

Unfortunately, this bug is already in Hibernate. I have opened issue HHH-6151 there.

> HQL with joins in sub-select creates wrong SQL
> ----------------------------------------------
>
>                 Key: NH-2648
>                 URL: http://216.121.112.228/browse/NH-2648
>             Project:  NHibernate
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 3.2.0Alpha2
>            Reporter: Harald M. Müller
>            Priority: Critical
>         Attachments: ASTForSubqueryFrom.gif, FromElementsForSubqueryFrom.gif, HQL_MissingJoinInExists.zip
>
>
> The following query is translated to wrong SQL - the join is missing from the sub-select:
>     SELECT ROOT FROM NHibernate.Test.NHSpecificTest.HQL_MissingJoinInExists.Sheet AS ROOT 
>                             WHERE (EXISTS (FROM NHibernate.Test.NHSpecificTest.HQL_MissingJoinInExists.Shelf AS inv  
>                                            JOIN ROOT.Folder AS ROOT_Folder 
>                                            WHERE (((ROOT_Folder.Shelf) = (inv) AND inv.Id = 1)) )) 
>                                   AND ROOT.Name = 'SomeName'
> (The query was created by a HQL generator of ours - hence the superfluous parentheses). The exceotion is:
> NHibernate.Exceptions.GenericADOException : could not execute query
> [ select sheet0_.Id as Id2_, sheet0_.Name as Name2_, sheet0_.Folder as Folder2_ from Sheet sheet0_ where (exists (select shelf1_.Id from Shelf shelf1_ where folder2_.Shelf=shelf1_.Id and shelf1_.Id=1)) and sheet0_.Name='SomeName' ]
> [SQL: select sheet0_.Id as Id2_, sheet0_.Name as Name2_, sheet0_.Folder as Folder2_ from Sheet sheet0_ where (exists (select shelf1_.Id from Shelf shelf1_ where folder2_.Shelf=shelf1_.Id and shelf1_.Id=1)) and sheet0_.Name='SomeName']
>   ----> System.Data.SqlClient.SqlException : The multi-part identifier "folder2_.Shelf" could not be bound.
> Since NHib 0.99 and in Hibernate, it has been possible to use joins inside subqueries. HQL allows it, and therefore, it should produce correct SQL (both syntactically and semantically). Actually, joins in subqueries are *necessary* if there are OR or NOT operators inside the subquery (some simpler queries can be rewritten with all Joins at top-level).
> I consider this bug critical because there is no workaround for
> * HQL generated for earlier NHib versions
> * manual HQL that needs OR or NOT inside a subquery
> * (I assume) the correct translation of Linq's .Any in the NHib.Linq provider
> I have attached a test case that shows the behavior.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://216.121.112.228/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[nhibernate-issues] [NHJIRA] Commented: (NH-2666) CLONE -many-to-one with property-ref makes separate select always

[Onur G. (JIRA) <nh...@gm...>]

    [ http://216.121.112.228/browse/NH-2666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=20933#action_20933 ] 

Onur Gumus commented on NH-2666:
--------------------------------

I still see this issue in NH 3.1

> CLONE -many-to-one with property-ref makes separate select always
> -----------------------------------------------------------------
>
>                 Key: NH-2666
>                 URL: http://216.121.112.228/browse/NH-2666
>             Project:  NHibernate
>          Issue Type: Bug
>          Components: Core
>    Affects Versions:  2.0.1.GA
>            Reporter: Onur Gumus
>            Priority: Major
>
> I have following tables:
>  - transactions:
>       - id (autogenerated in database); PK;
>       - numcode, for example 840 - numeric currency code;
>       - other columns
>  - currencies:
>       - id - PK, autogenerated;
>       - numcode - unique key
>       - alphacode (for example USD)
>       - decnum;
>       - fullname;
> and mapping for transactions table: 
>     <many-to-one name="numcode" column="numcode" property-ref="numcode" />
> When I'm retrieving transactions NHibernate generates a separate select for currencies table for each row from transactions table. This is very inefficient (N+1 problem).
> Solution is to do eager fetching. After specyfying eager fetching I see that transactions and currencies tables are joined, which means that I'm doing that right. However separate additional fetch in currencies is still occuring for each row in transactions table.
> I've tried both criteria API and HQL.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://216.121.112.228/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[nhibernate-issues] [NHJIRA] Created: (NH-2666) CLONE -many-to-one with property-ref makes separate select always

[Onur G. (JIRA) <nh...@gm...>]

CLONE -many-to-one with property-ref makes separate select always
-----------------------------------------------------------------

                 Key: NH-2666
                 URL: http://216.121.112.228/browse/NH-2666
             Project:  NHibernate
          Issue Type: Bug
          Components: Core
    Affects Versions:  2.0.1.GA
            Reporter: Onur Gumus
            Priority: Major


I have following tables:
 - transactions:
      - id (autogenerated in database); PK;
      - numcode, for example 840 - numeric currency code;
      - other columns
 - currencies:
      - id - PK, autogenerated;
      - numcode - unique key
      - alphacode (for example USD)
      - decnum;
      - fullname;
and mapping for transactions table: 
    <many-to-one name="numcode" column="numcode" property-ref="numcode" />

When I'm retrieving transactions NHibernate generates a separate select for currencies table for each row from transactions table. This is very inefficient (N+1 problem).
Solution is to do eager fetching. After specyfying eager fetching I see that transactions and currencies tables are joined, which means that I'm doing that right. However separate additional fetch in currencies is still occuring for each row in transactions table.
I've tried both criteria API and HQL.


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://216.121.112.228/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[nhibernate-issues] [NHJIRA] Created: (NHSR-38) FullTextQuery with field projections doesn't populate fields from IndexEmbedded components or classes

[Vasile B. (JIRA) <nh...@gm...>]

FullTextQuery with field projections doesn't populate fields from IndexEmbedded components or classes
-----------------------------------------------------------------------------------------------------

                 Key: NHSR-38
                 URL: http://216.121.112.228/browse/NHSR-38
             Project: NHibernate.Search
          Issue Type: Bug
          Components: Core
    Affects Versions: 2.0.1
            Reporter: Vasile Bujac
            Assignee: Paul Hatcher
            Priority: Minor


This is actually a very nice feature of NHibernate.Search, because it allows you to query against an lucene index without touching the database if one needs only stored fields from an entity. 
Consider the following model:

    [Indexed]
    public class Document
    {
        [DocumentId]
        public virtual Guid Id { get; set; }

        [Field(Index.Tokenized, Store = NHibernate.Search.Attributes.Store.Yes)]        
        public virtual string Title { get; set; }

        [Field(Index.Tokenized, Store = NHibernate.Search.Attributes.Store.No)]
        public virtual string Body { get; set; }

        [IndexedEmbedded(Prefix = "User.")]
        public virtual UserDetails User { get; set; }
    }

    public class UserDetails
    {
        [Field(Store = NHibernate.Search.Attributes.Store.Yes)]
        public virtual string Username { get; set; }

        [Field(Store = NHibernate.Search.Attributes.Store.Yes)]
        public virtual string FullName { get; set; }
    }

I would like to perform a fulltext query and I need only Id, Title, User.FullName fields from this document

                var results = session.CreateFullTextQuery<Document>("Title:django")
                    .SetProjection("Id", "Title", "User.FullName")
                    .SetMaxResults(5)
                    .List();
 The problem is a result item does not containt the "User.FullName" field. It seems that the problem is in the DocumentBuilder.ProcessFieldsForProjection private method. This method calls itself for each embedded mapping, but never uses the "Prefix" property of the embeddedmapping class. ITwoWayFieldBridge.Get("User.FullName", document) is ok, however


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://216.121.112.228/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[nhibernate-issues] [NHJIRA] Updated: (NH-2664) Linq, cannot query dynamic-component

[Daniel G. (JIRA) <nh...@gm...>]

     [ http://216.121.112.228/browse/NH-2664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Guenter updated NH-2664:
-------------------------------

    Attachment: NH2664_failing_test_case.patch

> Linq, cannot query dynamic-component
> ------------------------------------
>
>                 Key: NH-2664
>                 URL: http://216.121.112.228/browse/NH-2664
>             Project:  NHibernate
>          Issue Type: Bug
>          Components: Linq Provider
>    Affects Versions: 3.1.0
>            Reporter: Daniel Guenter
>            Priority: Major
>         Attachments: NH2664_failing_test_case.patch
>
>
> Querying a dynamic-component using ling results in an exception
> System.InvalidCastException : Unable to cast object of type 'NHibernate.Type.ComponentType' to type 'NHibernate.Type.CollectionType'.
> From
> NHibernate.Hql.Ast.ANTLR.Tree.DotNode.ResolveIndex(IASTNode parent) in DotNode.cs: line 141
> at NHibernate.Hql.Ast.ANTLR.Tree.IndexNode.Resolve(Boolean generateJoin, Boolean implicitJoin, String classAlias, IASTNode parent) in IndexNode.cs: line 47
> at NHibernate.Hql.Ast.ANTLR.Tree.FromReferenceNode.Resolve(Boolean generateJoin, Boolean implicitJoin, String classAlias) in FromReferenceNode.cs: line 57
> at NHibernate.Hql.Ast.ANTLR.Tree.FromReferenceNode.Resolve(Boolean generateJoin, Boolean implicitJoin) in FromReferenceNode.cs: line 62
> at NHibernate.Hql.Ast.ANTLR.HqlSqlWalker.ProcessIndex(IASTNode indexOp) in HqlSqlWalker.cs: line 821

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://216.121.112.228/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[nhibernate-issues] [NHJIRA] Created: (NH-2665) Formula on Many-to-one pointing to a composite-keyed entity don't work

[Onur G. (JIRA) <nh...@gm...>]

Formula on Many-to-one pointing to a composite-keyed entity don't work
----------------------------------------------------------------------

                 Key: NH-2665
                 URL: http://216.121.112.228/browse/NH-2665
             Project:  NHibernate
          Issue Type: Bug
          Components: Core
    Affects Versions: 3.2.0Alpha2
            Reporter: Onur Gumus
            Priority: Major


Hello, it seems the following mapping won't work

<many-to-one formula="(select top 1 id1, id2 from SomeEntity")/>

in this case id1 and id2 are composite Id's for SomeEntity. NHibernate will complain it was expecting two columns while validating the mapping.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://216.121.112.228/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[nhibernate-issues] [NHJIRA] Created: (NH-2664) Linq, cannot query dynamic-component

[Daniel G. (JIRA) <nh...@gm...>]

Linq, cannot query dynamic-component
------------------------------------

                 Key: NH-2664
                 URL: http://216.121.112.228/browse/NH-2664
             Project:  NHibernate
          Issue Type: Bug
          Components: Linq Provider
    Affects Versions: 3.1.0
            Reporter: Daniel Guenter
            Priority: Major


Querying a dynamic-component using ling results in an exception

System.InvalidCastException : Unable to cast object of type 'NHibernate.Type.ComponentType' to type 'NHibernate.Type.CollectionType'.

From

NHibernate.Hql.Ast.ANTLR.Tree.DotNode.ResolveIndex(IASTNode parent) in DotNode.cs: line 141
at NHibernate.Hql.Ast.ANTLR.Tree.IndexNode.Resolve(Boolean generateJoin, Boolean implicitJoin, String classAlias, IASTNode parent) in IndexNode.cs: line 47
at NHibernate.Hql.Ast.ANTLR.Tree.FromReferenceNode.Resolve(Boolean generateJoin, Boolean implicitJoin, String classAlias) in FromReferenceNode.cs: line 57
at NHibernate.Hql.Ast.ANTLR.Tree.FromReferenceNode.Resolve(Boolean generateJoin, Boolean implicitJoin) in FromReferenceNode.cs: line 62
at NHibernate.Hql.Ast.ANTLR.HqlSqlWalker.ProcessIndex(IASTNode indexOp) in HqlSqlWalker.cs: line 821

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://216.121.112.228/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[nhibernate-issues] [NHJIRA] Created: (NH-2663) Extension method to generate the Xml-string version of an HbmMapping

[Jose F. R. (JIRA) <nh...@gm...>]

Extension method to generate the Xml-string version of an HbmMapping
--------------------------------------------------------------------

                 Key: NH-2663
                 URL: http://216.121.112.228/browse/NH-2663
             Project:  NHibernate
          Issue Type: New Feature
          Components: Core
    Affects Versions: 3.2.0Alpha2
            Reporter: Jose F. Romaniello


I think it will be a good idea to add an extension method (or a method) in HbmMapping to generate the XmlVersion of the mappings;

Otherwise i have write this code lot of times.. for testing-debugging purposes:
public static class HbmMappingsExtensions
    {
        public static string ToXmlString(this HbmMapping mappings)
        {
            using (var ms = new MemoryStream())
            {
                var serializer = new XmlSerializer(typeof(HbmMapping));
                serializer.Serialize(ms, mappings);

                ms.Position = 0;
                using (var streamReader = new StreamReader(ms))
                {
                    return streamReader.ReadToEnd();
                }
            }
        }
    }

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://216.121.112.228/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira