ngspice ngspice-web

Brought to you by: dwarning, h_vogt, nicolati, pnenzi

ngspice-web Merge Request #1: Tutorial ngspice-tutorial.html updates (open)

Merging...

Merged

Something went wrong. Please, merge manually

Checking if merge is possible...

Something went wrong. Please, merge manually

kjslkfjsd wants to merge 5 commits from /u/sadkjfewroiu/ngspice/ to master, 2020-10-26

Commit	Date
[af284b] (ngspice-tutorial_updates) by Christopher Buckley Added links to manual for more coherent understanding	2020-09-24 03:44:24	Tree
[f4e842] by Christopher Buckley removed a bunch of dangling closure tags	2020-09-24 02:49:35	Tree
[bc69fb] by Christopher Buckley Pycharm autoindent lines	2020-09-24 02:45:39	Tree
[4b12da] by Christopher Buckley added missing </div> closures	2020-09-24 02:44:36	Tree
[bcf1f3] by Christopher Buckley Added numbers to menulist ids to prevent duplicate ids	2020-09-24 02:38:36	Tree

Discussion

kjslkfjsd - 2020-10-01

@h_vogt just checking in to see if you've had time to look this over and if I should make any changes to meet any project standards.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

kjslkfjsd - 2020-10-23

Approaching a month, so just checking in again if there is anything I can do to ease this merge request? I thought most of the commits were fairly straightfoward, but let me know if you disagree with anything and I can revise.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Holger Vogt - 2020-10-23

In your patch your are linking to the xhtml ngspice manual. The links in the manual seem to be auto-generated.

Are you sure that these links are stable, for example when we add something to the manual, maybe even a chapter, subchapter or so?

If they are not stble the linking would create another dependency which need continuous maitenance. I want to avoid that.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

kjslkfjsd - 2020-10-26

Thats a good point. I'm not familiar with how the manual auto-generates the html sections, but based on the naming, it would appear the ones without a dedicated subsection name (e.g. magicparlabel-####)to be volitile like you stated, whereas the ones with what appears to be a manually labeled name (e.g. #subsec__OP__Operating_Point) to be more stable.

I will read through and get more familiar with the manual repo and add a possible fixup for your review later.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Log in to post a comment.