Re: [Ngspice-devel] [PATCH]Fix many string memory leaks

[Stefan J. <ste...@mu...>]

Dear all,

Here is part two of the memory leak fix-ups.

It should be applied on top of the last patch I sent ( which should be
applied on top of 0.2.12 )

With these patches valgrind reports a maximum leak of about 1k when
parsing a 51k line spice deck ( mostly L, C K, R). I will leave the
leaks due to reading a spice deck at that.

If anyone finds any leaky operations, feel free to send me the spice
deck and scripts (for tclspice) to trigger it and I will try to fix. (or
just the back trace of the malloc )

There patches will, of course, have a high possibility of triggering a
coredump somewhere; if so send a back trace and i will fix.

( tclspice-0.2.13 will be soon, when I merge things and add any quick
features, with 13 this time definitely being unlucky for some user ... )

( for your information here are the leaks I cannot track down:

wordlist goes missing ...
==18864== 869 bytes in 116 blocks are definitely lost in loss record 70
of 83
==18864==    at 0x4014DC31: calloc (in /usr/lib/valgrind/valgrind.so)
==18864==    by 0x82511EF: tmalloc (alloc.c:41)
==18864==    by 0x822DE8B: cp_lexer (lexical.c:103)
==18864==    by 0x805DAD7: inp_dodeck (inp.c:669)
==18864==    by 0x805D4E1: inp_spsource (inp.c:497)
==18864==    by 0x804B24A: main (main.c:651)
==18864==    by 0x480047A6: __libc_start_main (in /lib/libc-2.3.2.so)
==18864==    by 0x804AA30: (within
/home/saj/projects/tclspice/src/ngspice)
 
end = alloc(struct line) thing -- does the list gets shortened??
==18554== 1373 bytes in 215 blocks are definitely lost in loss record 73
of 83
==18554==    at 0x4014DC31: calloc (in /usr/lib/valgrind/valgrind.so)
==18554==    by 0x82511EF: tmalloc (alloc.c:41)
==18554==    by 0x805E723: inp_readall (inpcom.c:278)
==18554==    by 0x805D0F3: inp_spsource (inp.c:308)
==18554==    by 0x804B24A: main (main.c:651)
==18554==    by 0x480047A6: __libc_start_main (in /lib/libc-2.3.2.so)
==18554==    by 0x804AA30: (within
/home/saj/projects/tclspice/src/ngspice)

)

-- 
Stefan Jones <ste...@mu...>
Multigig Ltd