Menu

#353 ngspice-27 test failures: empty-1.cir resume-1.cir

v1.0 (example)
closed-fixed
None
5
2018-03-16
2017-12-28
Marek Szuba
No

Running tests on the release tarball of ngspice-27 produces failures in regression/misc/empty-1.cir and regression/misc/resume-1.cir. The problem seems to be simply that ngspice writes its simulation progress to the output files (attached), which confuses the test framework; the results themselves appear to be correct.

2 Attachments

Discussion

  • Holger Vogt

    Holger Vogt - 2017-12-28

    Do you have the flag 'ngdebug' enabled by
    set ngdebug
    in spinit or .spiceinit?
    This causes printing of the progress.

    Holger

     
    • Holger Vogt

      Holger Vogt - 2017-12-28

      Marek,

      somewhat off-topic here:

      May I suggest you replace
      --enable-ndev
      by
      --disable-ndev

      in https://github.com/gentoo/gentoo/blob/master/sci-electronics/ngspice/ngspice-27.ebuild

      This has not been used for many years, is not maintained and is said to cause potential trouble.

      Holger

       
    • Marek Szuba

      Marek Szuba - 2017-12-28

      Not to my knowledge, no. Moreover, I have also seen this in a Docker container which is guaranteed not to have had ngspice installed prior to the test run.

      As for ndev, I have seen your comments regarding it on the mailing list but we wanted to keep the initial 27 ebuild functionally as close to the 26 one as possible. Switching off ndev is scheduled for 27-r1, which includes several other functionality changes and is undergoing testing as we speak.

       

      Last edit: Marek Szuba 2017-12-28
  • Robert Larice

    Robert Larice - 2017-12-28

    On what platform did this happen ? sharedpsice ?, mingw ?, windows ?, visualc ? ...
    The problem is obviously simply a "progress" report, which is unexpectedly spilled
    to the stdout stream, I don't have this issue here on linux.

     
    • Marek Szuba

      Marek Szuba - 2017-12-28

      Linux, specifically amd64 Gentoo Linux using the ebuild you mentioned a few comments ago. Happens regardless of whether debug features are enabled at compilation time or not. It isn't just me either, we have already had an external bug report about this: https://bugs.gentoo.org/642460 .

      By the way, although explicitly putting "unset ngdebug" in ~testuser/.spiceinit does allow the two tests to pass there are then failures in all 4 tests in regression/lib-processing/ - at a glance again due to excessive output. I have attached the diff for ex1a, for the other three the only difference is some of the numerical values.

       
      • Holger Vogt

        Holger Vogt - 2017-12-28

        "chk for convergence ..."
        is put out when --enable-stepdebug
        is set during compilation.

         
      • Holger Vogt

        Holger Vogt - 2017-12-28

        The "progress" report is enabled, when
        --enable-ndev
        is set.

        See ngspice\src\spicelib\analysis\dctran.c, line 880 ff.

        We have never experienced this because we never, never use this option.

         
  • Marek Szuba

    Marek Szuba - 2017-12-29

    Thank you for checking this! NDEV support has just been switched off so I guess I'll just have the ebuild print a warning instead of executing tests when debug mode has been enabled.

     
  • Holger Vogt

    Holger Vogt - 2018-03-16
    • status: open --> closed-fixed
    • assigned_to: Holger Vogt
     

Log in to post a comment.

MongoDB Logo MongoDB