#327 Header files are installed in /usr/share/ngspice/include/ngspice

[Maciej Suminski]

The usual location for header files is /usr/include/{optional_name}.
What do you think about conforming to the mentioned location? I am no autotools expert, but likely it is enough to change $(pkgdatadir)/include to $(includedir) in one of Makefile.am files [1].

Regards,
Orson

1. https://sourceforge.net/p/ngspice/ngspice/ci/master/tree/src/include/ngspice/Makefile.am#l3

[Robert Larice]

Hello,
your suggestion leads to a recursive definition error for includedir.
perhaps the diff below will do what you want.
can you check it, and consider a bit exceptional conditions, for example
having several different ngspice versions concurrently installed ?
Regards.

:::diff
--- a/src/include/ngspice/Makefile.am
+++ b/src/include/ngspice/Makefile.am
@@ -1,11 +1,9 @@
 ## Process this file with automake to produce Makefile.in

-includedir = $(pkgdatadir)/include/ngspice
-
-nodist_include_HEADERS = \
+nodist_pkginclude_HEADERS = \
    config.h

-include_HEADERS = \
+pkginclude_HEADERS = \
    tclspice.h  \
    acdefs.h    \
    bdrydefs.h  \

[Maciej Suminski]

Hi Robert,

Thank you, your patch solves the problem. Currently it installs header files to ${PREFIX}/include/ngspice which is the expected location. I doubt this way it could handle several ngspice versions installed, but is it a requirement? When I want to have a few versions of a library, I simply install them with different prefixes and point software that uses it to the right directory.

Regards,
Orson

[Robert Larice]

Hello,

Thank you for report and test.
I can't see a problem either,
And configure --incluedir=/foo/baz works well too.

It is on a side branch now,
Regards,
Robert