Menu

#13 Dreadnought Audio Lib Vulnerability

open
nobody
None
2
2007-01-12
2006-12-13
Jason
No

src/audio_lib/extra/ directory, lines 110-114:

------------------------------------------------
int SPK_Init(int period, int bass)
{
SDL_AudioSpec as;

delaybuf = calloc(65536, sizeof(short));
------------------------------------------------

We should use something other than calloc for this, it's not secure.

Discussion

  • Chris Nystrom

    Chris Nystrom - 2006-12-13

    Logged In: YES
    user_id=914661
    Originator: NO

    I believe the extra stuff in here is not compiled in at this time. The stuff in here is so the newio can have its own built in easy to use tone generator, but it is not currently used because I was not sure how to integrate it with the other audio code.

     
  • Chris Nystrom

    Chris Nystrom - 2007-01-12
    • priority: 5 --> 2
     

Log in to post a comment.