[Neuclear-develop] neuclear-id/src/java/org/neuclear/id/jce NeuClearCertificateFactory.java,1.6,1.7

[<pe...@us...>]

Update of /cvsroot/neuclear/neuclear-id/src/java/org/neuclear/id/jce
In directory sc8-pr-cvs1:/tmp/cvs-serv10855/src/java/org/neuclear/id/jce

Modified Files:
	NeuClearCertificateFactory.java 
Log Message:
EncryptedFileStore now works. It uses the PBECipher with DES3 afair.
Otherwise You will Finaliate.
Anything that can be final has been made final throughout everyting. We've used IDEA's Inspector tool to find all instance of variables that could be final.
This should hopefully make everything more stable (and secure).

Index: NeuClearCertificateFactory.java
===================================================================
RCS file: /cvsroot/neuclear/neuclear-id/src/java/org/neuclear/id/jce/NeuClearCertificateFactory.java,v
retrieving revision 1.6
retrieving revision 1.7
diff -C2 -d -r1.6 -r1.7
*** NeuClearCertificateFactory.java	18 Nov 2003 15:45:09 -0000	1.6
--- NeuClearCertificateFactory.java	21 Nov 2003 04:45:11 -0000	1.7
***************
*** 35,38 ****
--- 35,44 ----
  $Id$
  $Log$
+ Revision 1.7  2003/11/21 04:45:11  pelle
+ EncryptedFileStore now works. It uses the PBECipher with DES3 afair.
+ Otherwise You will Finaliate.
+ Anything that can be final has been made final throughout everyting. We've used IDEA's Inspector tool to find all instance of variables that could be final.
+ This should hopefully make everything more stable (and secure).
+ 
  Revision 1.6  2003/11/18 15:45:09  pelle
  FileStoreTest now passes. FileStore works again.
***************
*** 74,84 ****
   * Time: 4:39:08 PM
   */
! public class NeuClearCertificateFactory extends CertificateFactorySpi {
!     final public Certificate engineGenerateCertificate(InputStream inputStream) throws CertificateException {
          try {
              //Identity id=(Identity) VerifyingReader.getInstance().read(inputStream);
!             BufferedReader d = new BufferedReader(new InputStreamReader(inputStream));
              if (d.ready()) {
!                 String name = d.readLine();
                  if (name==null)
                      throw new CertificateEncodingException("Certificate is empty");
--- 80,90 ----
   * Time: 4:39:08 PM
   */
! public final class NeuClearCertificateFactory extends CertificateFactorySpi {
!     final public Certificate engineGenerateCertificate(final InputStream inputStream) throws CertificateException {
          try {
              //Identity id=(Identity) VerifyingReader.getInstance().read(inputStream);
!             final BufferedReader d = new BufferedReader(new InputStreamReader(inputStream));
              if (d.ready()) {
!                 final String name = d.readLine();
                  if (name==null)
                      throw new CertificateEncodingException("Certificate is empty");
***************
*** 99,104 ****
      }
  
!     final public Collection engineGenerateCertificates(InputStream inputStream) throws CertificateException {
!         List list=new LinkedList();
          try {
              while(inputStream.available()>0) {
--- 105,110 ----
      }
  
!     final public Collection engineGenerateCertificates(final InputStream inputStream) throws CertificateException {
!         final List list=new LinkedList();
          try {
              while(inputStream.available()>0) {
***************
*** 111,119 ****
      }
  
!     final public CRL engineGenerateCRL(InputStream inputStream) throws CRLException {
          return null;
      }
  
!     final public Collection engineGenerateCRLs(InputStream inputStream) throws CRLException {
          return new ArrayList(0);
      }
--- 117,125 ----
      }
  
!     final public CRL engineGenerateCRL(final InputStream inputStream) throws CRLException {
          return null;
      }
  
!     final public Collection engineGenerateCRLs(final InputStream inputStream) throws CRLException {
          return new ArrayList(0);
      }