Re: [Nettle-users] Libssh2 support

[Alex M. S. <no...@ar...>]

On 09/06/2010 04:10, James Bursa wrote:
> On Monday 07 June 2010, Alex Macfarlane Smith wrote:
>> On 06/06/2010 23:40, James Bursa wrote:
>>> I have started implementing SSH support in Nettle using libssh2,
>>> http://www.libssh2.org/
>>>
>>> The basics are working in my tests connecting to two Linux hosts. Please
>>> see the attached patch.
>>>
>>> A build of this is at http://zamez.org/nettlejcb.zip
>>>
>>> It's built using gccsdk. Some minor changes that aren't in the patch were
>>> required to make it compile with gcc.
>>
>> Yeah, I did start working on getting libssh2 working with Norcroft, but
>> got sidetracked :) It all builds now IIRC, but there were some Unixy
>> symbols that weren't in the Norcroft unixlib etc. libraries, and I
>> haven't yet got around to 'fixing' those.
>
> Hi Alex,
>
> Thanks for looking at it. Do you mean that you got libssh2 compiling, but not
> a fully linked Nettle yet?
>
Yeah, it all seemed to build OK, I just need to sort out the missing 
library symbol issues. Will maybe get some time this weekend.

> Are there any changes I should make before this can be checked in?
>
> James
>

I'd probably suggest ifdeffing your changes so we can still build 
without SSH - 1. because Norcroft builds of it won't work just yet, 2. I 
seem to recall PuTTY does something similar because of issues with using 
SSH in certain countries, so can ship both an SSH and non-SSH version.

May also be worthwhile thinking about committing a separate Makefile 
etc. for building with gcc? (if that's feasible)

Cheers,

Alex.