[Netnice-kernels] Bug report

[Takashi O. <ta...@cs...>]

Dear netnice kernel developers,


As you might have realized by the commit log, I found several bugs
in FreeBSD4/5 Netnice. Fortunately, they are minor ones, and do not
make big difference to most users...

And, I will write to the related lists, regarding Netnice-2.2
release and the hacking camp, shortly.


thanks,

-- taka@pittsburgh

 - nnfs_netnice.c:nnfs_donetnice()

       use of nnfs_getuserstr at "case Pvif_filter" of nnfs_donetnice()
       is inapropriate, because it is for string data. It requires
       larger buffer size (+1) for string termination, and also
       modifies the data content. Accordingly, we need to use another
       function nnfs_getuserdt(), which is added in nnfs_subr.c.

 - nnfs_vnops.c:nnfs_getattr()

       in the calculation of vap->va_nlink at "case Pvif_dir",
       a nvif_target, which is not actually used, is also counted.
       we need to properly subtract the number of entries not used.

 - nnfs_vnops.c:nnfs_readdir.c()

       same as above. the number of entries is not appropriate.
       similarly to the vap->va_nlink calculation above, we need to
       appropriately count the number of the entries, and need to
       skip the extra entries. otherwise, it would use another
       entry at the end of the list multiple times.

 - vif_input.c:vif_enqueue() of FreeBSD 4.11

       a closing bracket is missing... (L.723)

EoF