Re: [Netnice-kernels] Linux NNFS API nearing completion

[Scott B. <sco...@ve...>]

On Thu, 28 Oct 2004, Takashi Okumura wrote:

> hi scott,
> 
> here is my feedback. i checked out the code this afternoon, and used VMware.
> it took me quite long to configure the system, since i'm novice at linux.
> i updated the wiki based on my experience and put a short note about how
> to configure the Linux/Netnice. if you guys have anything to add, or 
> anything you want to modify, please feel free to make any change.
> 
> overall, i was impressed by the implementation. it is working!
> my feedback follows. 
> 

Thanks for the good credit.  I have enjoyed working on this project
and have learned a lot.  I have done this work a quickly as I could
trying to get the basic API features working in one month.


>  - Directory: /nnfs/procs/[pid]
>                
> is it easy to change the directory for the process-dependent files to
> the location, /nnfs/[pid]? this is just to keep the comatibility between
> implementations. if it is too time consuming, you may keep it as is,
> for now. just let me know your position.
> 

This can be changed.

>  - Directory: /nnfs/procs/[pid]/*
> 
> this issue is not serious, but, you will add other control files, right?
> since priority of this part is low, we may skip this part, for now, also.
> 

On Linux the standard process control files appear under /proc.  If
there are others needed for netnice then I missed them.  Could you
specify, which control files are needed that appear under FreeBSD and
that don't have a similar implementation under Linux /proc or
/proc/<pid> ?


>  - Directory: /nnfs/procs/[pid]/*/sockets/
> 
> cann't we cd to the link?
> 
> 	$ cd lo
> 	lo: Not a directory
> 	$
> 
> on FreeBSD system, we can change dir to the link file. if this is Linux's
> specification, that is okay. i just want to know if it is possible, or not.
> 

I did not implement the followlink inode operation, however, I can
attempt to implement this.  I did not think it was necessary as part
of the basic API and you can cd to /nnfs/network/lo.

>  - Directory: /nnfs/network/lo
> 
> i tried parameter setting under lo directory. is this expected behavior?
> i felt it is not, though i also felt it is easy to fix.
> 
>                 $ cat type
>                 Non Work Conserving
> 
>                 $ echo 1 > type; cat type
>                 Block
> 

I will need to investigate this to see what is going on.  On FreeBSD this
should say Weighted Fair Queuing.


>  - Directory: /nnfs/network/lo
> 
>         mkdir of VIF dir:               OK
>         rmdir of VIF dir:               NG?
>                 directory not empty error.
> 

The error message is correct because the vif directory contains
control files that need to be removed first.  The command:

# rm -r vif

should be used to recursively remove it and the control files and it
will. However, even though the vif subdirectory is removed this too
will produce an error message.  The rmdir inode operation is not
implemented due to a non-functioning vif_rm and vif_free.  The
directory is being removed from the filesystem but the underlying vif
is not.  This can be fixed when the internals are working more
completely.

>  - Directory: /nnfs/procs/[pid]/*/sockets/
> 
>         rm of a link to a VIF dir:      OK
>         ln to a VIF dir:                OK
> 
>  - Kernel build
> 
> 	can we merge CONFIG_NNFS and CONFIG_NETNICE?
> 	or, do you think we may leave them, for now?
> 	on FreeBSD, we merged the options.
> 	what do you recommend?
> 

Yes, these can be integrated together where. However, it is good to be able
to specify CONFIG_NNFS as a module instead of a builtin during development
work, that way a reboot is not necessary to make a change.

>  - net/core/vif_subr.c
> 
> 	we completely rewritten vif_rm(). we'll need to fix this,
> 	based on net/vif_suvr.c of FreeBSD5.3.
> 
> thanks!
> 
> 
> -- taka
> 


Thanks,


Scott Brumbaugh