Re: [Netnice-kernels] Linux NNFS API nearing completion

[Takashi O. <ta...@cs...>]

hi scott,

here is my feedback. i checked out the code this afternoon, and used VMware.
it took me quite long to configure the system, since i'm novice at linux.
i updated the wiki based on my experience and put a short note about how
to configure the Linux/Netnice. if you guys have anything to add, or 
anything you want to modify, please feel free to make any change.

overall, i was impressed by the implementation. it is working!
my feedback follows. 

 - Directory: /nnfs/procs/[pid]
               
is it easy to change the directory for the process-dependent files to
the location, /nnfs/[pid]? this is just to keep the comatibility between
implementations. if it is too time consuming, you may keep it as is,
for now. just let me know your position.

 - Directory: /nnfs/procs/[pid]/*

this issue is not serious, but, you will add other control files, right?
since priority of this part is low, we may skip this part, for now, also.

 - Directory: /nnfs/procs/[pid]/*/sockets/

cann't we cd to the link?

	$ cd lo
	lo: Not a directory
	$

on FreeBSD system, we can change dir to the link file. if this is Linux's
specification, that is okay. i just want to know if it is possible, or not.

 - Directory: /nnfs/network/lo

i tried parameter setting under lo directory. is this expected behavior?
i felt it is not, though i also felt it is easy to fix.

                $ cat type
                Non Work Conserving

                $ echo 1 > type; cat type
                Block

 - Directory: /nnfs/network/lo

        mkdir of VIF dir:               OK
        rmdir of VIF dir:               NG?
                directory not empty error.

 - Directory: /nnfs/procs/[pid]/*/sockets/

        rm of a link to a VIF dir:      OK
        ln to a VIF dir:                OK

 - Kernel build

	can we merge CONFIG_NNFS and CONFIG_NETNICE?
	or, do you think we may leave them, for now?
	on FreeBSD, we merged the options.
	what do you recommend?

 - net/core/vif_subr.c

	we completely rewritten vif_rm(). we'll need to fix this,
	based on net/vif_suvr.c of FreeBSD5.3.

thanks!


-- taka

Scott Brumbaugh wrote:
> 
> I have fixed the so_vifnet pointer dereference problem.  The problem
> seems to have been due to uninitialized pointers in the sock_alloc and
> sock_alloc_inode functions in socket.c.  This change is in CVS.
> 
> After fixing this I was able to implement the readdir and lookup
> operations under /nnfs/procs/<pid>/sockets/<fd>.  I have also
> completed the readlink, unlink operations there which are working so
> far.  The symlink operation itself, which will allow the changing of
> pvifs on a socket is still incomplete but should not take very long to
> implement.