Re: [Netnice-developer] Re: small fixes in netniced

[Takashi O. <ta...@cs...>]

hi Sergei and Nico,

thank you for your contribution. 

since netniced is in a active phase of its development these days,
and mike is about to make some hack on the daemon's code,
i think it would be better to move to the netniced ML.

regarding the sprintf issue, i think sergei's suggestion is reasonable :-)


thanks!

-- taka

Sergei Matusevich wrote:
> 
> op...@so... wrote:
> 
> > Hi Sergei,
> > That's great. Also, all the sprintf() must be replaced with snprintf()
> > I think I fixed some of these on my obsd port. But since I am still working
> > on the kernel I didn't have time to commit any changes to netnice and
> > netniced. I just got them to compile and that was it. If you can take a
> > look at those, it will be great.
> 
> Hi Nico,
> 
> Absolutely, we need to do that. The reason I have not done it yet is
> that I am considering some more optimizations in s[n]printf() usage. For
> example, it looks like that Process.pid member variable never changes
> during the Process object lifecycle. Yet we call
>    sprintf(path, "/proc/%d/sockets", this->pid);
> in many places. Doing it once in Process' constructor will cost a little
>   memory, but is a good performance improvement. Process.pid also begs
> to be a constant IMHO.
> 
> I plan to do some changes like this one in a few days, if you guys don't
> mind. I will keep you posted.
> 
> Have a great weekend,
> Sergei.
> 
> -------------------------------------------------------
> This SF.net email is sponsored by: SF.net Giveback Program.
> Does SourceForge.net help you be more productive?  Does it
> help you create better code?  SHARE THE LOVE, and help us help
> YOU!  Click Here: http://sourceforge.net/donate/
> _______________________________________________
> Netnice-developer mailing list
> Net...@li...
> https://lists.sourceforge.net/lists/listinfo/netnice-developer