Re: [Netnice-developer] another team member (if you guys don't mind :-))
Status: Alpha
Brought to you by:
taost6
From: Takashi O. <ta...@cs...> - 2003-11-10 16:28:46
|
hi sergei, thank you for your interest in our project. linux porting is on almost top of my todo list, but, due to time and resource constraint, it has been deferred, unwillingly. thus, it would be great if you take part in the process. i really appreciate your help. i admit that netnice applications need code-cleaning and more testing. actually, even the netnice command needs more work. my excuse is, again, time constraint. since there is limited amount of time, i've been laid emphasis on the kernel part. so, i appreciate your suggestions, and it would be also great if the netnice applications become lint-free. i included your account into our developers. my suggestions about the applications are described in the sub-project description pages, and they might be useful for you. since i've been working on kernel, particularly, the reference implementation on FreeBSD, you may modify any part of the applications for now. (one exception is netniced, on which mike is/will be working. you'll need proper coordination. actually, "openfile" feature is the one that i do not like most about the netniced implementation. it should use structures for data passing, and netniced have to be modified accordingly.) anyway. welcome to the netnice developers community (it's so small now!), and, again, thank you for your interest and help! -- taka p.s. can you tell me how you found the project and what part of netnice interested you. the information is used to improve our homepage and public relations. thanks! Sergei Matusevich wrote: > > Dear netnice team, > > My name is Sergei, and I am a C++ developer from New Jersey. I am a > Linux guy, currently using Debian/unstable with 2.4.23 kernel and gcc > 3.3.2. I think I can help the project with Linux porting and testing. I > will be also happy to work on general code optimization and > beautification, i.e. make it more standard-conforming, lint-free, > improve const correctness, exception safety, etc. > > For instance: there are places in the netnice code where strings are > passed by value rather than by reference; using typedef Boolean instead > of the standard boolean type seems a little bit obsolete IMHO; many > things are done in C way where C++/STL can be a better solution, and so on. > > e.g. in vif::select_by_openfile() method, there is a buf[MAX_PATH_LEN] > array, and in the STR_GET macro we have code > > r = fread(dst, sizeof(char), MAX_PATH_LEN, fp); > *(dst + r) = '\0'; > > That is, we write '\0' at buf[MAX_PATH_LEN], right AFTER the last > element of buf[]. The program does not crash just because there are > other variables on stack after buf[]. > > Don't get me wrong: the project is great, that's why I have chosen it > out of 320+ others that also seek for developers on SF. What I want to > say is that I really like the team and the attitude here on netnice, I > see a great potential and room for improvement in the code, and I will > be happy to join the crew and help making the project better. > > As for my technical qualification, please look at my resume online at > http://motus.kiev.ua/motus2/Work/cv_matusevich.html > > PS. my SF login is 'motus'. > > Thank you and have a great day, > Sergei. > > ------------------------------------------------------- > This SF.Net email sponsored by: ApacheCon 2003, > 16-19 November in Las Vegas. Learn firsthand the latest > developments in Apache, PHP, Perl, XML, Java, MySQL, > WebDAV, and more! http://www.apachecon.com/ > _______________________________________________ > Netnice-developer mailing list > Net...@li... > https://lists.sourceforge.net/lists/listinfo/netnice-developer |