[Netnice-developer] another team member (if you guys don't mind :-))
Status: Alpha
Brought to you by:
taost6
From: Sergei M. <mo...@op...> - 2003-11-10 15:53:05
|
Dear netnice team, My name is Sergei, and I am a C++ developer from New Jersey. I am a Linux guy, currently using Debian/unstable with 2.4.23 kernel and gcc 3.3.2. I think I can help the project with Linux porting and testing. I will be also happy to work on general code optimization and beautification, i.e. make it more standard-conforming, lint-free, improve const correctness, exception safety, etc. For instance: there are places in the netnice code where strings are passed by value rather than by reference; using typedef Boolean instead of the standard boolean type seems a little bit obsolete IMHO; many things are done in C way where C++/STL can be a better solution, and so on. e.g. in vif::select_by_openfile() method, there is a buf[MAX_PATH_LEN] array, and in the STR_GET macro we have code r = fread(dst, sizeof(char), MAX_PATH_LEN, fp); *(dst + r) = '\0'; That is, we write '\0' at buf[MAX_PATH_LEN], right AFTER the last element of buf[]. The program does not crash just because there are other variables on stack after buf[]. Don't get me wrong: the project is great, that's why I have chosen it out of 320+ others that also seek for developers on SF. What I want to say is that I really like the team and the attitude here on netnice, I see a great potential and room for improvement in the code, and I will be happy to join the crew and help making the project better. As for my technical qualification, please look at my resume online at http://motus.kiev.ua/motus2/Work/cv_matusevich.html PS. my SF login is 'motus'. Thank you and have a great day, Sergei. |