[Netnice-daemon] Re: [Netnice-developer] select_all() problem update

[Sergei M. <mo...@mo...>]

Michael L. Gualtieri wrote:

> I tracked down the bug.  In the file vif.cc in the methods:
> 
> vif::select_all()
> vif::select_by_file(String filename)
> vif::nselect_by_file(String filename)
> 
> They each have the line:
> 	if ( !( isRegularDir(dir)
> 
> This should be changed to:
> 	if ( ( isRegularDir(dir)
> 
> I'm not sure why it was the other way.  Prehaps this is a bug that
> propagated?  If I remove the "not" the methods seem to work.  Should I
> commit this change, or do one of you who have it "checked out" want to
> commit this change with the next release?

Hi Michael,

Looks like it's my fault. isRegularDir() was introduced to wrap some 
things for Linux portability, so it must be not only vif but other 
netniced classes as well. I will fix it in a few seconds, sorry.

PS. Let's move this discussion to the netnice-daemon ML - I will post a 
message there when I'll be done with the fix.

Thanks,
Sergei.