#66 Fix display of vlan membership

[Oliver Gorwits]

Agreed on IRC between jeneric, oliver and LT:

"Native VLAN" UI Device Ports col should show device_port.pvid DB column.

"Tagged VLANs" UI Device Ports col should be renamed to "VLAN Membership" and display all relevant rows from device_port_vlan, highlighting in some way those where native=false.

Alter the Primary Key on device_port_vlan to include the native column.

[Oliver Gorwits]

http://lists.cluenet.de/pipermail/ipv6-ops/2013-December/009645.html

[Oliver Gorwits]

[Robert Kerr]

Don't think the device_port_vlan primary key should include the native column?

Netdisco decides whether native is t or f based on i_vlan. As i_vlan will always be the same for a given port at a given time it's impossible for both a native=t and native=f entry to exist for a given (ip,port,vlan) combination?

[Oliver Gorwits]

Also agreed on IRC:

We're going to store the same data to both the pvid and vlan fields of the device_port table (that is, i_vlan), but only ever use the pvid col in ND2 code. The vlan field will remain for legacy/3rd-party apps support.

It would also be nice to rename the "native" boolean field of device_port_vlan to be "untagged" (more IEEEish). Unfortunately this would break compatibility with 3rd party apps using the schema.

DBIx::Class does support alternate accessor names for DB fields, but the original DB field name must still be used in search constraints. I'll probably add the accessor.