Re: [Netatalk-devel] [Netatalk-cvs] netatalk/include/atalk volume.h, 1.13, 1.14

[Frank L. <fra...@go...>]

2010/2/19 didier gautheron <di...@us...>:
> Update of /cvsroot/netatalk/netatalk/include/atalk
> In directory sfp-cvsdas-3.v30.ch3.sourceforge.com:/tmp/cvs-serv9758/include/atalk
>
> Modified Files:
>        volume.h
> Log Message:
> use volume real path for chdir
>
> Index: volume.h
> ===================================================================
> RCS file: /cvsroot/netatalk/netatalk/include/atalk/volume.h,v
> retrieving revision 1.13
> retrieving revision 1.14
> diff -C2 -d -r1.13 -r1.14
> *** volume.h    8 Feb 2010 10:29:22 -0000       1.13
> --- volume.h    19 Feb 2010 01:26:03 -0000      1.14
> ***************
> *** 26,29 ****
> --- 26,30 ----
>      int             v_flags;
>      char            *v_path;
> +     char            *v_realpath; /* canonical path */
>      struct dir      *v_dir, *v_root;
>      struct dir      *v_curdir;  /* cache */

Why another struct member? Imo we should just normalize the volume
name from AppleVolumes.default and store that in v_path. If we add
another struct member, from now in 4 years later nobody remembers the
semantics and has to start banging his head hardly and repeatadly
against the code in order to get the different use cases. Been there,
done that, no good.