FCE version 1 packets are broken

Brought to you by: franklahm, himasaram, mgkeller, morgana, and 2 others

This project can now be found here.

#603 FCE version 1 packets are broken

Milestone: None

Status: closed

Owner: Ralph Böhme

Labels: None

Priority: 5

Updated: 2026-07-07

Created: 2015-11-20

Creator: Ralph Böhme

Private: No

FCE version 2 broke version 1 marshalling:

version is always set to 1
several version 2 fields are also put into v1 packets

Discussion

Daniel Markstedt - 2026-07-06

status: open --> closed
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Daniel Markstedt - 2026-07-06

this was patched by Ralph in https://github.com/Netatalk/netatalk/commit/940ca0175b on Dec 16, 2015 and included in v3.1.8

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Daniel Markstedt - 2026-07-07

there was one straggler instance in send_fce_event() where the lookup was against FCE_PACKET_VERSION and not obj->fce_version -- this has been fixed in https://github.com/Netatalk/netatalk/pull/3153

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Log in to post a comment.