#1371 Fixed nsDebug token settings

[Anders Wallin]

• removed faulty comment
• set correct table name
• including all debug tokens
• setting correct off value to 2 instead of 0

This solves https://sourceforge.net/p/net-snmp/bugs/2874/

[Bart Van Assche]

The last part of this patch looks suspicious to me. Are you sure the following changes are correct?

             if (!debug_entry)
                 continue;
-           status = (debug_entry->enabled ? RS_ACTIVE : RS_NOTINSERVICE);
+           status = debug_entry->enabled;
            snmp_set_var_typed_value(request->requestvb, ASN_INTEGER,
                                      (u_char*)&status, sizeof(status));

                 if (debug_entry)
-                    debug_entry->enabled =
-                        (*request->requestvb->val.integer == RS_ACTIVE);
+                   debug_entry->enabled = *request->requestvb->val.integer;
                break

[Anders Wallin]

It' sort of correct, BUT appended is a much simplier patch fixing the problem at the root.

[Anders Wallin]

Is the last version of the patch OK?

[Bart Van Assche]

Thanks for the patch. It has been applied on the v5.8 and master branches.