Re: netsnmp_register_mib() error handling

[Wes H. <har...@us...>]

>>>>> On Tue, 17 Jan 2012 10:50:44 +0100, Jan Safranek <jsa...@re...> said:

JS> It's not that easy, agent_registry.c:1164 was only an example. There are
JS> other places, where the reginfo is not freed before returning error from
JS> this function.

Ok, where are the others?  We can fix them too of course.

The documentation has still clearly stated that it'll be freed, which
makes this:

JS> In addition, Coverity tells me that there some callers use reginfo when
JS> netsnmp_register_mib() fails (-> sigsegv), again, one example for all:
JS> hrSWInstalledTable.c:143: freed_arg: "netsnmp_register_table" frees "reg".
JS> hrSWInstalledTable.c:167: double_free: Calling
JS> "netsnmp_handler_registration_free" frees pointer "reg" which has
JS> already been freed.

clearly a mistake.
-- 
Wes Hardaker
Please mail all replies to net...@li...