Menu
▾
▴
[Net-snmp-patches] [ net-snmp-Patches-2835550 ] Don't use NETSNMP_INLINE
|
From: SourceForge.net <no...@so...> - 2009-08-11 13:54:27
|
Patches item #2835550, was opened at 2009-08-11 15:19 Message generated for change (Comment added) made by bvassche You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=312694&aid=2835550&group_id=12694 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Bart Van Assche (bvassche) Assigned to: Nobody/Anonymous (nobody) Summary: Don't use NETSNMP_INLINE Initial Comment: I'm minimizing the number of compiler warnings generated during compilation of the Net-SNMP trunk. One of the warnings that is printed multiple times by gcc is that inlining failed. This is because several large functions have been declared inline explicitly. When compiling C or C++ source code with a recent GCC compiler there is no need to declare functions explicitly inline: * GCC is able to inline both functions that have been declared static and functions that have not been declared static, at least if both functions have been defined in the same compilation unit. * When a function is both inline and static, if all calls to the function have been integrated into the caller, and the function's address is never used, then GCC does not actually output assembler code for the function (unless the option -fkeep-inline-functions has been specified). * Recent gcc versions are better at deciding which functions should be inlined and which ones not. In some cases better performance is obtained by not inlining a function. See also http://gcc.gnu.org/onlinedocs/gcc/Inline.html. ---------------------------------------------------------------------- >Comment By: Bart Van Assche (bvassche) Date: 2009-08-11 15:54 Message: Notes: - The first version of the attached patch only removed NETSNMP_INLINE from .c files. - The second version of the attached patch also removes NETSNMP_STATIC_INLINE from .c files. - Some header files use NETSNMP_STATIC_INLINE. The attached patch doesn't modify any .h file. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=312694&aid=2835550&group_id=12694 |