Re: -Dlinux=linux

[Thomas A. <tho...@bl...>]

Magnus Fromreide wrote:
> After the change to set the value of the define linux to linux the compiler
> complains:
> 
> <command line>:1:1: warning: "linux" redefined
> <built-in>: warning: this is the location of the previous definition
> 
> When I read the description of the change I got the impression that the symbols
> shouldn't be defined if the already were defined?

"linux" is defined built-in (as 1) when compiling on Linux, so our
addition of "-Dlinux=linux" to CFLAGS (which we consider a safer define
for platform names in general) triggers the above warning in MAIN.

Using "-Ulinux -Dlinux=linux" will fix the warning for gcc, but won't
work for all compilers. I've checked in a fix that adds "-U..." if we're
compiling with gcc which should fix the issue for you. If someone could
come up with a proper configure test that checks if "-U..." works as
intended, that'd be even better, of course.


+Thomas

-- 
Thomas Anders (thomas.anders at blue-cable.de)