Menu

#11 pci_set_power_state fix

closed
nobody
None
5
2014-08-20
2005-08-27
No

pci_set_power_state() takes a pci_power_t as the second
parameter but ndiswrapper is passing PMSG_ON and
PMSG_SUSPEND which are of type pm_message_t. This works
fine for older kernels as the underlying data type is
the same and the compiler casts them transparently but
it breaks with newer kernels.

Discussion

  • Florin Malita

    Florin Malita - 2005-08-27

    Fix pci_set_power_state() types

     
  • Giridhar Pemmasani

    Logged In: YES
    user_id=918798

    While this patch may work for new kernels, it won't work for older
    kernels (all 2.6 and at least post 2.4.21). Current CVS works with
    main line kernels. When pci_power_t makes it into main line
    kernel, I will apply necessary changes. However, if you can submit a
    patch that will work for all the kernels, I will gladly apply.

    Thanks for the patch.

     
  • Giridhar Pemmasani

    Logged In: YES
    user_id=918798

    Current CVS has proper fix for this issue that works for all kernels.

     

Log in to post a comment.