#12 Doubled CID lines if cidnoname set and NAME present

[davepickles]

I'm using ncid 1.0 in the UK with a Zoom 3095 USB modem. The BT telephone system doesn't use the NAME field so I 'set cidnoname = 1' in ncidd.conf. This works fine with incoming calls with normal CID, however if I gat a call with 'number withheld', the modem helpfully adds a NAME field with the name WITHHELD. This causes ncidd to emit two CID entries thus:

MESG = 110101
DATE = 1110
TIME = 1438
NMBR = P
CID: DATE11102014TIME1438LINEPOTSNMBRPRIVATEMESG110101NAMENO NAME
NAME = WITHHELD
RING
CIDINFO: LINEPOTSRING1TIME14:38:49
CID: DATE11102014TIME1438LINEPOTSNMBRNO NUMBERMESGNONENAMEWITHHELD*

I believe this patch will fix the problem, by completely ignoring the NAME field if cidnoname is set.

--- ncidd.c.orig 2014-11-10 17:50:42.297899990 +0000
+++ ncidd.c 2014-11-10 17:55:56.329383106 +0000
@@ -2275,8 +2275,9 @@
*/
else if ((ptr = strstr(buf, "NAME")))
{

• / Ignore any name sent if cidnoname=1 /
  / if NAME already sent, discard the second one /
• if (!(cid.status & CIDNAME))
• if (!cidnoname && !(cid.status & CIDNAME))
  {
  / remove any trailing spaces /
  for (sptr = buf; *sptr; ++sptr);

[Todd Andrews]

Thank you, Dave! We'll make sure your patch gets into NCID's source.

[John L. Chmielewski]

Nice fix. Included it in the source for release 1.1.