Menu

Test plugin with primefaces 4: test01 primefaces-4.0-20130711.071416-4.jar

Javier
2013-08-18
2013-08-19
  • Javier

    Javier - 2013-08-18

    I started to test the plugin with primefaces 4 with nbpfcrudgen-0.15.2-7.3.1impl.zip.

    SNAPSHOT dir:
    primefaces/4.0-SNAPSHOT

    Necessary files:

    nbpfcrudgen-0.15.2-src_test01.zip
    primefaces-4.0-20130711.071416-4.jar
    commons-fileupload-1.3-bin.zip
    primefacesTestDatabase.png
    primeFacesDatabaseTest.sql

    Environment:
    Glassfish 4.0
    Mojarra 2.2.0
    Firefox 23.0

    Changes for test:

    Version.java:
    Lines: 87-89
    // if (!version.matches(ACCEPTED_VERSION_PATTERN)) {
    // throw new IllegalArgumentException("Invalid version format");
    // }

    list.ftl:
    line150-153-156: button's-> PF('widgetName').show();
    replaced binding... =converterId="${entityDescriptor.valuesConverter}"

    create.ftl:
    line132: type="button" PF('${entityName}CreateDialog').hide()
    replaced binding... =converterId="${entityDescriptor.valuesConverter}"

    edit.ftl:
    line135: type="button" PF('${entityName}EditDialog').hide()
    replaced binding... =converterId="${entityDescriptor.valuesConverter}"

    view.ftl:
    line105: PF('${entityName}ViewDialog').hide()
    replaced binding... =converterId="${entityDescriptor.valuesConverter}"

    converter.ftl: Solved problem converter-id, see topic
    replaced import-> javax.inject.Named; by import javax.faces.convert.FacesConverter;
    @FacesConverter(value="${converterClassName?uncap_first}")

    Bugs found:

    1. Dialog behind overlay:
      primeFaces4Test_2013-08-18 12:52:55.png

    2. I changed modal="false" to continue with test's.
      The dialog no close when you insert or edit new customer successfully. The function handleSubmit(xhr, status, args, dialog) of pfcrud.js no works properly, no close, no shake.
      primeFaces4Test_2013-08-18 13:06:10.png

    3. Buttons outside the table.
      buttonsOutsideTable.png

    Any help is appreciated, thanks.

     

    Last edit: Javier 2013-08-18
  • Kay Wrobel

    Kay Wrobel - 2013-08-18

    Thank you for spending some time on this. I am currently strapped for time and really appreciate you looking at this problem. Also, I don't have access to the Primefaces snapshot as I am not a Pro member. So thanks again for testing.

    I noticed already the buttons outside the table issue with PF 3.5. Not sure if this is something PF did on a release change. The most recent one I had tested with was 3.4 and it was fine.

    Thanks for providing the links above. I will take a look at this when I get some time in between. If you figure this out, I can try to add you as a developer for this project.

     
  • Kay Wrobel

    Kay Wrobel - 2013-08-18

    Javier,
    I added you as a developer to this project. I changed the permissions of "Developers" to read, update, and create. I also changed you to be the owner of this ticket. Hope that's ok with you.

     
  • Kay Wrobel

    Kay Wrobel - 2013-08-18

    Feel free to use the GIT repository for sharing your findings. We should create a branch for testing.

     
  • Javier

    Javier - 2013-08-19

    I agree with you. Ok, first of all I will check it out Git to learn.

     

Anonymous
Anonymous

Add attachments
Cancel