Re: [Nbd] [PATCHv6] Remove NBD_OPT_BLOCK_SIZE; add specific requests to NBD_OPT_INFO

[Alex B. <al...@al...>]

On 28 Apr 2016, at 17:54, Wouter Verhelst <w...@ut...> wrote:

> 
> [...]
>> +      request block size constraints using `NBD_INFO_BLOCK_SIZE` prior
>> +      to entering transmission phase, because the server will be using
>> +      non-default block sizes constraints. The server MUST NOT send this
>> +      error if block size constraints were requested with
>> +      `NBD_INFO_BLOCK_SIZE` with the `NBD_OPT_INFO` or `NBD_OPT_GO`
> 
> only NBD_OPT_GO here?

No I think that one is right.

You can't send NBD_REP_ERR_BLOCK_SIZE_REQD in response to an NBD_OPT_INFO
if it's asked for NBD_INFO_BLOCK_SIZE.

If it has not asked for NBD_INFO_BLOCK_SIZE it is legitimate to error
the NBD_OPT_INFO with NBD_REP_ERR_BLOCK_SIZE_REQD so that the client knows
that if sends an NBD_OPT_GO with the same parameters it would get that
error, and hence it should either ask for block size constraints or
give up.

I'm going to apply v6 with your and Eric's changes (plus or minus
a couple of tiny grammar nits).

-- 
Alex Bligh