On Tue, Apr 29, 2008 at 7:44 PM, Zoran Vasiljevic
<vas...@us...> wrote:
> Update of /cvsroot/naviserver/naviserver/nsd
> In directory sc8-pr-cvs16.sourceforge.net:/tmp/cvs-serv1402/nsd
>
> Modified Files:
> tcljob.c
> Log Message:
> nsd/tcljob.c: Fixed wrong access to queuePtr variable
> in the worker thread (Bug introduced 2008-04-26). Made
> LookupQueue errors trigger Fatal exceptions when run
> from within the worker threads.
>
>
> --- 1239,1242 ----
> ***************
> *** 1330,1334 ****
> while (!done && jobPtr != NULL) {
>
> ! LookupQueue(NULL, jobPtr->queueId, &queuePtr, 1);
>
> /*
> --- 1331,1337 ----
> while (!done && jobPtr != NULL) {
>
> ! if (LookupQueue(NULL, jobPtr->queueId, &queuePtr, 1) != TCL_OK) {
> ! Ns_Log(Fatal, "cannot find queue: %s", jobPtr->queueId);
> ! }
>
> /*
> ***************
Should call Ns_Fatal() here, not Ns_Log(Fatal, ...)
(Ns_Log(Fatal, ) is kind of a hidden implementation detail)
|
