yes, i was confued with that function as well.
if it is not used we better rename/drop it, i agree about using V but
that was the best i was able to come up with:-)))
Stephen Deasey wrote:
> On 6/28/05, Vlad Seryakov <ser...@us...> wrote:
>
>>Update of /cvsroot/naviserver/naviserver/include
>>In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv3191/include
>>
>>Modified Files:
>> ns.h
>>Log Message:
>>Added Ns_ConnVSetHeaders function to add headers to the output in printf-style way
>>Added support for Range: header for returning partial content
>>
>>
>>Index: ns.h
>>===================================================================
>>RCS file: /cvsroot/naviserver/naviserver/include/ns.h,v
>>retrieving revision 1.27
>>retrieving revision 1.28
>>diff -C2 -d -r1.27 -r1.28
>>*** ns.h 13 Jun 2005 06:14:26 -0000 1.27
>>--- ns.h 28 Jun 2005 20:15:43 -0000 1.28
>>***************
>>*** 1014,1017 ****
>>--- 1014,1018 ----
>> NS_EXTERN int Ns_ConnFlushHeaders(Ns_Conn *conn, int status);
>> NS_EXTERN void Ns_ConnSetHeaders(Ns_Conn *conn, char *field, char *value);
>>+ NS_EXTERN void Ns_ConnVSetHeaders(Ns_Conn *conn, char *field, char *fmt,...);
>> NS_EXTERN void Ns_ConnCondSetHeaders(Ns_Conn *conn, char *field, char *value);
>> NS_EXTERN void Ns_ConnReplaceHeaders(Ns_Conn *conn, Ns_Set *newheaders);
>
>
>
> The 'V' in Ns_ConnVSetHeaders() suggests it takes a va_list, as in
> Ns_DStringVPrintf() used in the implementation.
>
> Unfortunately, Ns_ConnPrintfHeader() already exists. It prints
> directly to the output stream which looks pretty silly. The function
> is unused.
>
> How about we rename your function Ns_ConnPrintfHeaders and drop
> Ns_ConnPrintfHeader? Does anyone think that will be a problem?
>
>
> -------------------------------------------------------
> SF.Net email is sponsored by: Discover Easy Linux Migration Strategies
> from IBM. Find simple to follow Roadmaps, straightforward articles,
> informative Webcasts and more! Get everything you need to get up to
> speed, fast. http://ads.osdn.com/?ad_idt77&alloc_id492&opÌk
> _______________________________________________
> naviserver-devel mailing list
> nav...@li...
> https://lists.sourceforge.net/lists/listinfo/naviserver-devel
--
Vlad Seryakov
571 262-8608 office
vl...@cr...
http://www.crystalballinc.com/vlad/
|
