From: Zoran V. <zv...@ar...> - 2005-03-04 19:51:44
|
Hi! I'm going thru the module we wrote some times ago which augment core server commands, and I spotted two of them: ns_conn discardcontent ns_conn headers status ?type? ?length?" The first one discards the entire content of the request. The second one sets required output headers w/o sending any content to the remote peer. Question: is there anything in the server as-is which would allow me to do this now? Cheer's Zoran |
From: Vlad S. <vl...@cr...> - 2005-03-04 20:02:23
|
With headers you can pretty much use ns_set set h [ns_conn outputheaders] ns_set truncate $h ns_set put $h Content-Type text/html ... But there is not way to set status without using one of the ns_return... command. It would be nice to use ns_conn status for returning current status and ns_conn status newstatus for setting new status directly Zoran Vasiljevic wrote: > Hi! > > I'm going thru the module we wrote some times ago which augment > core server commands, and I spotted two of them: > > ns_conn discardcontent > ns_conn headers status ?type? ?length?" > > The first one discards the entire content of the request. > The second one sets required output headers w/o sending > any content to the remote peer. > > Question: is there anything in the server as-is which would > allow me to do this now? > > Cheer's > Zoran > > > ------------------------------------------------------- > SF email is sponsored by - The IT Product Guide > Read honest & candid reviews on hundreds of IT Products from real users. > Discover which products truly live up to the hype. Start reading now. > http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click > _______________________________________________ > naviserver-devel mailing list > nav...@li... > https://lists.sourceforge.net/lists/listinfo/naviserver-devel -- Vlad Seryakov 571 262-8608 office vl...@cr... http://www.crystalballinc.com/vlad/ |
From: Stephen D. <sd...@gm...> - 2005-03-05 00:33:39
|
I added the function Ns_ConnSetResponseStatus() for the protocols stuff, but I didn't add the Tcl equivalent to ns_conn. I aggree with Vlad that ns_conn status ?newStatus? would be a good addition (which requires that we drop connid :-) Does ns_respond do what you need? ns_respond ?-status status? ?-type type? \ { ?-string string? | ?-file filename? | ?-fileid fileid? } \ ?-length length? ?-headers setid? What is [ns_conn discardcontent] used for? On Fri, 04 Mar 2005 14:59:22 -0500, Vlad Seryakov <vl...@cr...> wrote: > With headers you can pretty much use ns_set > set h [ns_conn outputheaders] > ns_set truncate $h > ns_set put $h Content-Type text/html > ... > > But there is not way to set status without using one of the ns_return... > command. > > It would be nice to use > ns_conn status for returning current status and > ns_conn status newstatus for setting new status directly > > Zoran Vasiljevic wrote: > > Hi! > > > > I'm going thru the module we wrote some times ago which augment > > core server commands, and I spotted two of them: > > > > ns_conn discardcontent > > ns_conn headers status ?type? ?length?" > > > > The first one discards the entire content of the request. > > The second one sets required output headers w/o sending > > any content to the remote peer. > > > > Question: is there anything in the server as-is which would > > allow me to do this now? > > > > Cheer's > > Zoran |
From: Zoran V. <zv...@ar...> - 2005-03-05 09:42:32
|
On Saturday 05 March 2005 01:33, Stephen Deasey wrote: > Does ns_respond do what you need? > > ns_respond ?-status status? ?-type type? \ > { ?-string string? | ?-file filename? | ?-fileid fileid? } \ > ?-length length? ?-headers setid? The main reason for such mechanism for me is: I would like to prepare a http response and send it ultimately to the client (w/o closing the connection to the client and w/o sending any content bytes). When the client makes a request to the server, the server will resond with proper headers and leave the content handling to me. For this purppose I have made the [ns_conn channel] which I can use to handle the content myself. So it goes this way: server accepts a http regular connection server formats a proper http response server sends the response to client but does not close the connetion server gives me the connection socket [ns_conn channel] my custom proc takes the socket and does things my custom proc closes the socket when finished So, basically, what I miss in the current implementation is a way to create and send a proper http request including headers and status. To set output headers, there is a way, but to set the proper response status there isn't. If I do: ns_respond ?-status status? ?-type type? ?-headers setid? would it do the right thing? If I have my [ns_conn channel] command (RFE) I'd do: set chan [ns_conn channel] ns_respond -status 200 -type myown/mimetype dothings $chan The client will get proper http response (ns_respond) and I will keep the conn socket open (ns_conn channel). My (dothings) proc will then handle the body and ultimaltey close the channel, which will then tear down the socket and the connection to the client. Look at this example... On the client-side (this can be another server instance): set chan [httpget /some/url/on/server] domyprotocol $chan And on the server (handler for the /some/url/on/server URL) set chan [ns_conn channel] ns_respond -status 200 -type myown/mimetype domyprotocol $chan The "httpget" on the client is clever. It sends the requests and processes only up to returned headers. For the body part, it just returns the comm socket to the caller. The server part accepts a valid http requests, prepares the proper http response and passes the conn channel to the caller. After that, "domyprotocol" on the server and on the client can do whatever they like on the $chan. This way we have implemented many services in our product. We only use port 80 and http connection establishment to get a pipe between peers. Thereafter, we use this pipe for whole lotta things absolutely unrelated to the http protocol and page-serving at all. Do you follow? > > > > What is [ns_conn discardcontent] used for? This I have made some years ago and it may not be needed anymore today (not sure). What I ment with that is: by processing the incoming request, I look into http headers. If I decide to drop the request because there is something in the headers I don't like, I will handle all of the incoming data from the client and just discard everything. This is important for keepalive connections because you have to be careful and read exactly the contentLength bytes from the peer. I somehow could not do that using existing ns_ commands so I invented my own. Question: is there another way of doing this? Look at the implementation I have now: static int NsxDiscardCmd (cl, interp, objc, objv) ClientData cl; Tcl_Interp * interp; int objc; Tcl_Obj * CONST objv[]; { size_t buflen; int nb; char *buf; Ns_Conn *conn; /* * Syntax: nsx discardcontent */ conn = Ns_TclGetConn(interp); if (conn == NULL) { Tcl_AppendResult(interp, "no connection", NULL); return TCL_ERROR; } buflen = 32*1024; buf = (char*)Tcl_Alloc(buflen); /* * Sink conn->contentLength bytes from connection */ while(conn->contentLength > 0) { nb = (conn->contentLength < buflen) ? conn->contentLength : buflen; nb = Ns_ConnRead(conn, buf, nb); if (nb == NS_ERROR) { break; } conn->contentLength -= nb; } Tcl_Free((char*)buf); return TCL_OK; } |
From: Vlad S. <vl...@cr...> - 2005-03-05 17:37:00
|
ns_respond closes the connection, so you cannot use it, still need ns_conn status newstatus command. Zoran Vasiljevic wrote: > On Saturday 05 March 2005 01:33, Stephen Deasey wrote: > > >>Does ns_respond do what you need? >> >>ns_respond ?-status status? ?-type type? \ >> { ?-string string? | ?-file filename? | ?-fileid fileid? } \ >> ?-length length? ?-headers setid? > > > > The main reason for such mechanism for me is: > I would like to prepare a http response and send it > ultimately to the client (w/o closing the connection > to the client and w/o sending any content bytes). > > When the client makes a request to the server, the server > will resond with proper headers and leave the content > handling to me. For this purppose I have made the > [ns_conn channel] which I can use to handle the content > myself. So it goes this way: > > server accepts a http regular connection > server formats a proper http response > server sends the response to client but does not close the connetion > server gives me the connection socket [ns_conn channel] > my custom proc takes the socket and does things > my custom proc closes the socket when finished > > So, basically, what I miss in the current implementation > is a way to create and send a proper http request > including headers and status. To set output headers, > there is a way, but to set the proper response status > there isn't. > > If I do: > > ns_respond ?-status status? ?-type type? ?-headers setid? > > would it do the right thing? > If I have my [ns_conn channel] command (RFE) I'd do: > > set chan [ns_conn channel] > ns_respond -status 200 -type myown/mimetype > dothings $chan > > The client will get proper http response (ns_respond) > and I will keep the conn socket open (ns_conn channel). > My (dothings) proc will then handle the body > and ultimaltey close the channel, which will then tear > down the socket and the connection to the client. > > Look at this example... > > On the client-side (this can be another server instance): > > set chan [httpget /some/url/on/server] > domyprotocol $chan > > And on the server (handler for the /some/url/on/server URL) > > set chan [ns_conn channel] > ns_respond -status 200 -type myown/mimetype > domyprotocol $chan > > The "httpget" on the client is clever. It sends > the requests and processes only up to returned headers. > For the body part, it just returns the comm socket to > the caller. > > The server part accepts a valid http requests, prepares > the proper http response and passes the conn channel to > the caller. > > After that, "domyprotocol" on the server and on the client > can do whatever they like on the $chan. This way we have > implemented many services in our product. We only use port > 80 and http connection establishment to get a pipe between > peers. Thereafter, we use this pipe for whole lotta things > absolutely unrelated to the http protocol and page-serving > at all. > > Do you follow? > > >> >> >>What is [ns_conn discardcontent] used for? > > > This I have made some years ago and it may not be > needed anymore today (not sure). What I ment with > that is: by processing the incoming request, I > look into http headers. If I decide to drop the > request because there is something in the headers > I don't like, I will handle all of the incoming > data from the client and just discard everything. > This is important for keepalive connections because > you have to be careful and read exactly the > contentLength bytes from the peer. I somehow could > not do that using existing ns_ commands so I invented > my own. Question: is there another way of doing this? > Look at the implementation I have now: > > > static int > NsxDiscardCmd (cl, interp, objc, objv) > ClientData cl; > Tcl_Interp * interp; > int objc; > Tcl_Obj * CONST objv[]; > { > size_t buflen; > int nb; > char *buf; > Ns_Conn *conn; > > /* > * Syntax: nsx discardcontent > */ > > conn = Ns_TclGetConn(interp); > if (conn == NULL) { > Tcl_AppendResult(interp, "no connection", NULL); > return TCL_ERROR; > } > > buflen = 32*1024; > buf = (char*)Tcl_Alloc(buflen); > > /* > * Sink conn->contentLength bytes from connection > */ > > while(conn->contentLength > 0) { > nb = (conn->contentLength < buflen) ? conn->contentLength : buflen; > nb = Ns_ConnRead(conn, buf, nb); > if (nb == NS_ERROR) { > break; > } > conn->contentLength -= nb; > } > > Tcl_Free((char*)buf); > > return TCL_OK; > } > > > > ------------------------------------------------------- > SF email is sponsored by - The IT Product Guide > Read honest & candid reviews on hundreds of IT Products from real users. > Discover which products truly live up to the hype. Start reading now. > http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click > _______________________________________________ > naviserver-devel mailing list > nav...@li... > https://lists.sourceforge.net/lists/listinfo/naviserver-devel -- Vlad Seryakov 571 262-8608 office vl...@cr... http://www.crystalballinc.com/vlad/ |
From: Stephen D. <sd...@gm...> - 2005-03-08 05:02:27
|
I don't think you need this. In 4.x all content is read fromt the network and buffered before your code ever runs. You're just copying it from one buffer to another. On Sat, 5 Mar 2005 10:38:09 +0100, Zoran Vasiljevic <zv...@ar...> wrote: > > What is [ns_conn discardcontent] used for? > > This I have made some years ago and it may not be > needed anymore today (not sure). What I ment with > that is: by processing the incoming request, I > look into http headers. If I decide to drop the > request because there is something in the headers > I don't like, I will handle all of the incoming > data from the client and just discard everything. > This is important for keepalive connections because > you have to be careful and read exactly the > contentLength bytes from the peer. I somehow could > not do that using existing ns_ commands so I invented > my own. Question: is there another way of doing this? > Look at the implementation I have now: > > static int > NsxDiscardCmd (cl, interp, objc, objv) > ClientData cl; > Tcl_Interp * interp; > int objc; > Tcl_Obj * CONST objv[]; > { > size_t buflen; > int nb; > char *buf; > Ns_Conn *conn; > > /* > * Syntax: nsx discardcontent > */ > > conn = Ns_TclGetConn(interp); > if (conn == NULL) { > Tcl_AppendResult(interp, "no connection", NULL); > return TCL_ERROR; > } > > buflen = 32*1024; > buf = (char*)Tcl_Alloc(buflen); > > /* > * Sink conn->contentLength bytes from connection > */ > > while(conn->contentLength > 0) { > nb = (conn->contentLength < buflen) ? conn->contentLength : buflen; > nb = Ns_ConnRead(conn, buf, nb); > if (nb == NS_ERROR) { > break; > } > conn->contentLength -= nb; > } > > Tcl_Free((char*)buf); > > return TCL_OK; > } |
From: Zoran V. <zv...@ar...> - 2005-03-08 08:14:31
|
On Tuesday 08 March 2005 06:02, Stephen Deasey wrote: > 2005-03-08 06:02 >=20 > I don't think you need this. =A0In 4.x all content is read fromt the > network and buffered before your code ever runs. =A0You're just copying > it from one buffer to another. OK. I did not know that. This command is still there from the 3.0 in one of my modules. I can just scrap it then. Zoran |
From: Zoran V. <zv...@ar...> - 2005-03-05 12:37:05
|
On Saturday 05 March 2005 01:33, Stephen Deasey wrote: > I added the function Ns_ConnSetResponseStatus() for the protocols > stuff, but I didn't add the Tcl equivalent to ns_conn. =A0I aggree with > Vlad that ns_conn status ?newStatus? would be a good addition (which > requires that we drop connid :-) Drop the connid.=20 ns_conn status ?newStatus? is perfectly OK. Zoran |
From: Vlad S. <vl...@cr...> - 2005-03-05 17:37:39
Attachments:
diff
|
Patch is attached, if everybody is Okay with it i will commit it Zoran Vasiljevic wrote: > On Saturday 05 March 2005 01:33, Stephen Deasey wrote: > >>I added the function Ns_ConnSetResponseStatus() for the protocols >>stuff, but I didn't add the Tcl equivalent to ns_conn. I aggree with >>Vlad that ns_conn status ?newStatus? would be a good addition (which >>requires that we drop connid :-) > > > Drop the connid. > > ns_conn status ?newStatus? > > is perfectly OK. > > Zoran > > > ------------------------------------------------------- > SF email is sponsored by - The IT Product Guide > Read honest & candid reviews on hundreds of IT Products from real users. > Discover which products truly live up to the hype. Start reading now. > http://ads.osdn.com/?ad_ide95&alloc_id396&opÌk > _______________________________________________ > naviserver-devel mailing list > nav...@li... > https://lists.sourceforge.net/lists/listinfo/naviserver-devel -- Vlad Seryakov 571 262-8608 office vl...@cr... http://www.crystalballinc.com/vlad/ |
From: Zoran V. <zv...@ar...> - 2005-03-05 17:54:21
|
On Saturday 05 March 2005 18:36, Vlad Seryakov wrote: > Patch is attached, if everybody is Okay with it i will commit it Do not forget to update include/ns.h=20 and put the prototype there! >=20 > Zoran Vasiljevic wrote: > > On Saturday 05 March 2005 01:33, Stephen Deasey wrote: > >=20 > >>I added the function Ns_ConnSetResponseStatus() for the protocols > >>stuff, but I didn't add the Tcl equivalent to ns_conn. I aggree with > >>Vlad that ns_conn status ?newStatus? would be a good addition (which > >>requires that we drop connid :-) > >=20 > >=20 > > Drop the connid.=20 > >=20 > > ns_conn status ?newStatus? > >=20 > > is perfectly OK. > >=20 > > Zoran > >=20 > >=20 > > ------------------------------------------------------- > > SF email is sponsored by - The IT Product Guide > > Read honest & candid reviews on hundreds of IT Products from real users. > > Discover which products truly live up to the hype. Start reading now. > > http://ads.osdn.com/?ad_ide95&alloc_id396&op=CCk > > _______________________________________________ > > naviserver-devel mailing list > > nav...@li... > > https://lists.sourceforge.net/lists/listinfo/naviserver-devel >=20 > --=20 > Vlad Seryakov > 571 262-8608 office > vl...@cr... > http://www.crystalballinc.com/vlad/ >=20 |
From: Vlad S. <vl...@cr...> - 2005-03-05 18:23:15
|
I know, it is just the core of the update to be approved Zoran Vasiljevic wrote: > On Saturday 05 March 2005 18:36, Vlad Seryakov wrote: > >>Patch is attached, if everybody is Okay with it i will commit it > > > Do not forget to update include/ns.h > and put the prototype there! > > > >>Zoran Vasiljevic wrote: >> >>>On Saturday 05 March 2005 01:33, Stephen Deasey wrote: >>> >>> >>>>I added the function Ns_ConnSetResponseStatus() for the protocols >>>>stuff, but I didn't add the Tcl equivalent to ns_conn. I aggree with >>>>Vlad that ns_conn status ?newStatus? would be a good addition (which >>>>requires that we drop connid :-) >>> >>> >>>Drop the connid. >>> >>> ns_conn status ?newStatus? >>> >>>is perfectly OK. >>> >>>Zoran >>> >>> >>>------------------------------------------------------- >>>SF email is sponsored by - The IT Product Guide >>>Read honest & candid reviews on hundreds of IT Products from real users. >>>Discover which products truly live up to the hype. Start reading now. >>>http://ads.osdn.com/?ad_ide95&alloc_id396&opÌk >>>_______________________________________________ >>>naviserver-devel mailing list >>>nav...@li... >>>https://lists.sourceforge.net/lists/listinfo/naviserver-devel >> >>-- >>Vlad Seryakov >>571 262-8608 office >>vl...@cr... >>http://www.crystalballinc.com/vlad/ >> > > > > > ------------------------------------------------------- > SF email is sponsored by - The IT Product Guide > Read honest & candid reviews on hundreds of IT Products from real users. > Discover which products truly live up to the hype. Start reading now. > http://ads.osdn.com/?ad_ide95&alloc_id396&opÌk > _______________________________________________ > naviserver-devel mailing list > nav...@li... > https://lists.sourceforge.net/lists/listinfo/naviserver-devel -- Vlad Seryakov 571 262-8608 office vl...@cr... http://www.crystalballinc.com/vlad/ |
From: Stephen D. <sd...@gm...> - 2005-03-08 04:44:33
|
The comment for Ns_ConnSetResponseStatus() says that it reurns the previous status. It actually returns the current, just-set status. So does ns_conn status. I don't think it's neccessary. The other simillar functions in that file have no return value. (Ns_ConnSetUrlEncoding(), Ns_ConnSetWriteEncodedFlag()...) Added six weeks ago to AOLserver cvs: Ns_ConnSetStatus(), Ns_ConnGetStatus() http://cvs.sourceforge.net/viewcvs.py/naviserver/naviserver/nsd/conn.c?r1=1.1&r2=1.2 On Sat, 05 Mar 2005 13:22:31 -0500, Vlad Seryakov <vl...@cr...> wrote: > I know, it is just the core of the update to be approved > > Zoran Vasiljevic wrote: > > On Saturday 05 March 2005 18:36, Vlad Seryakov wrote: > > > >>Patch is attached, if everybody is Okay with it i will commit it > > > > > > Do not forget to update include/ns.h > > and put the prototype there! |
From: Vlad S. <vl...@cr...> - 2005-03-08 04:54:21
|
Oops, i was thinking to retern previous status but then change my mind, comment left, i will correct it. Stephen Deasey wrote: > The comment for Ns_ConnSetResponseStatus() says that it reurns the > previous status. It actually returns the current, just-set status. > So does ns_conn status. > > I don't think it's neccessary. The other simillar functions in that > file have no return value. (Ns_ConnSetUrlEncoding(), > Ns_ConnSetWriteEncodedFlag()...) > > > Added six weeks ago to AOLserver cvs: Ns_ConnSetStatus(), Ns_ConnGetStatus() > > http://cvs.sourceforge.net/viewcvs.py/naviserver/naviserver/nsd/conn.c?r1=1.1&r2=1.2 > > > > > On Sat, 05 Mar 2005 13:22:31 -0500, Vlad Seryakov > <vl...@cr...> wrote: > >>I know, it is just the core of the update to be approved >> >>Zoran Vasiljevic wrote: >> >>>On Saturday 05 March 2005 18:36, Vlad Seryakov wrote: >>> >>> >>>>Patch is attached, if everybody is Okay with it i will commit it >>> >>> >>>Do not forget to update include/ns.h >>>and put the prototype there! > > > > ------------------------------------------------------- > SF email is sponsored by - The IT Product Guide > Read honest & candid reviews on hundreds of IT Products from real users. > Discover which products truly live up to the hype. Start reading now. > http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click > _______________________________________________ > naviserver-devel mailing list > nav...@li... > https://lists.sourceforge.net/lists/listinfo/naviserver-devel -- Vlad Seryakov 571 262-8608 office vl...@cr... http://www.crystalballinc.com/vlad/ |
From: Stephen D. <sd...@gm...> - 2005-03-08 04:57:18
|
How about removing the comment, marking the function void, and changing the naming to match the addtions to AOLserver? On Mon, 07 Mar 2005 23:53:35 -0500, Vlad Seryakov <vl...@cr...> wrote: > Oops, i was thinking to retern previous status but then change my mind, > comment left, i will correct it. > > Stephen Deasey wrote: > > The comment for Ns_ConnSetResponseStatus() says that it reurns the > > previous status. It actually returns the current, just-set status. > > So does ns_conn status. > > > > I don't think it's neccessary. The other simillar functions in that > > file have no return value. (Ns_ConnSetUrlEncoding(), > > Ns_ConnSetWriteEncodedFlag()...) > > > > > > Added six weeks ago to AOLserver cvs: Ns_ConnSetStatus(), Ns_ConnGetStatus() > > > > http://cvs.sourceforge.net/viewcvs.py/naviserver/naviserver/nsd/conn.c?r1=1.1&r2=1.2 > > > > > > > > > > On Sat, 05 Mar 2005 13:22:31 -0500, Vlad Seryakov > > <vl...@cr...> wrote: > > > >>I know, it is just the core of the update to be approved > >> > >>Zoran Vasiljevic wrote: > >> > >>>On Saturday 05 March 2005 18:36, Vlad Seryakov wrote: > >>> > >>> > >>>>Patch is attached, if everybody is Okay with it i will commit it > >>> > >>> > >>>Do not forget to update include/ns.h > >>>and put the prototype there! > > > > > > > > ------------------------------------------------------- > > SF email is sponsored by - The IT Product Guide > > Read honest & candid reviews on hundreds of IT Products from real users. > > Discover which products truly live up to the hype. Start reading now. > > http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click > > _______________________________________________ > > naviserver-devel mailing list > > nav...@li... > > https://lists.sourceforge.net/lists/listinfo/naviserver-devel > > -- > Vlad Seryakov > 571 262-8608 office > vl...@cr... > http://www.crystalballinc.com/vlad/ > > ------------------------------------------------------- > SF email is sponsored by - The IT Product Guide > Read honest & candid reviews on hundreds of IT Products from real users. > Discover which products truly live up to the hype. Start reading now. > http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click > _______________________________________________ > naviserver-devel mailing list > nav...@li... > https://lists.sourceforge.net/lists/listinfo/naviserver-devel > |
From: Vlad S. <vl...@cr...> - 2005-03-08 05:06:59
|
Done except naming, it is different in AS 4.1 CVS and 4.0.x, does it really matter much? But i am not insisting. Stephen Deasey wrote: > How about removing the comment, marking the function void, and > changing the naming to match the addtions to AOLserver? > > > On Mon, 07 Mar 2005 23:53:35 -0500, Vlad Seryakov > <vl...@cr...> wrote: > >>Oops, i was thinking to retern previous status but then change my mind, >>comment left, i will correct it. >> >>Stephen Deasey wrote: >> >>>The comment for Ns_ConnSetResponseStatus() says that it reurns the >>>previous status. It actually returns the current, just-set status. >>>So does ns_conn status. >>> >>>I don't think it's neccessary. The other simillar functions in that >>>file have no return value. (Ns_ConnSetUrlEncoding(), >>>Ns_ConnSetWriteEncodedFlag()...) >>> >>> >>>Added six weeks ago to AOLserver cvs: Ns_ConnSetStatus(), Ns_ConnGetStatus() >>> >>>http://cvs.sourceforge.net/viewcvs.py/naviserver/naviserver/nsd/conn.c?r1=1.1&r2=1.2 >>> >>> >>> >>> >>>On Sat, 05 Mar 2005 13:22:31 -0500, Vlad Seryakov >>><vl...@cr...> wrote: >>> >>> >>>>I know, it is just the core of the update to be approved >>>> >>>>Zoran Vasiljevic wrote: >>>> >>>> >>>>>On Saturday 05 March 2005 18:36, Vlad Seryakov wrote: >>>>> >>>>> >>>>> >>>>>>Patch is attached, if everybody is Okay with it i will commit it >>>>> >>>>> >>>>>Do not forget to update include/ns.h >>>>>and put the prototype there! >>> >>> >>> >>>------------------------------------------------------- >>>SF email is sponsored by - The IT Product Guide >>>Read honest & candid reviews on hundreds of IT Products from real users. >>>Discover which products truly live up to the hype. Start reading now. >>>http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click >>>_______________________________________________ >>>naviserver-devel mailing list >>>nav...@li... >>>https://lists.sourceforge.net/lists/listinfo/naviserver-devel >> >>-- >>Vlad Seryakov >>571 262-8608 office >>vl...@cr... >>http://www.crystalballinc.com/vlad/ >> >>------------------------------------------------------- >>SF email is sponsored by - The IT Product Guide >>Read honest & candid reviews on hundreds of IT Products from real users. >>Discover which products truly live up to the hype. Start reading now. >>http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click >>_______________________________________________ >>naviserver-devel mailing list >>nav...@li... >>https://lists.sourceforge.net/lists/listinfo/naviserver-devel >> > > > > ------------------------------------------------------- > SF email is sponsored by - The IT Product Guide > Read honest & candid reviews on hundreds of IT Products from real users. > Discover which products truly live up to the hype. Start reading now. > http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click > _______________________________________________ > naviserver-devel mailing list > nav...@li... > https://lists.sourceforge.net/lists/listinfo/naviserver-devel -- Vlad Seryakov 571 262-8608 office vl...@cr... http://www.crystalballinc.com/vlad/ |
From: Stephen D. <sd...@gm...> - 2005-03-08 05:21:45
|
It looks like the change was added to cvs-HEAD ~6 weeks ago, so this probably wont find it's way to 4.0.10 at all... I was just thinking we should keep parity with AOLserver here. The new driver code promised for AOLserver might depend upon it and it might start to get messy when we merge with 4.1 if we have to rename everything. On Tue, 08 Mar 2005 00:06:19 -0500, Vlad Seryakov <vl...@cr...> wrote: > Done except naming, it is different in AS 4.1 CVS and 4.0.x, does it > really matter much? But i am not insisting. > > Stephen Deasey wrote: > > How about removing the comment, marking the function void, and > > changing the naming to match the addtions to AOLserver? > > > > > > On Mon, 07 Mar 2005 23:53:35 -0500, Vlad Seryakov > > <vl...@cr...> wrote: > > > >>Oops, i was thinking to retern previous status but then change my mind, > >>comment left, i will correct it. > >> > >>Stephen Deasey wrote: > >> > >>>The comment for Ns_ConnSetResponseStatus() says that it reurns the > >>>previous status. It actually returns the current, just-set status. > >>>So does ns_conn status. > >>> > >>>I don't think it's neccessary. The other simillar functions in that > >>>file have no return value. (Ns_ConnSetUrlEncoding(), > >>>Ns_ConnSetWriteEncodedFlag()...) > >>> > >>> > >>>Added six weeks ago to AOLserver cvs: Ns_ConnSetStatus(), Ns_ConnGetStatus() > >>> > >>>http://cvs.sourceforge.net/viewcvs.py/naviserver/naviserver/nsd/conn.c?r1=1.1&r2=1.2 > >>> > >>> > >>> > >>> > >>>On Sat, 05 Mar 2005 13:22:31 -0500, Vlad Seryakov > >>><vl...@cr...> wrote: > >>> > >>> > >>>>I know, it is just the core of the update to be approved > >>>> > >>>>Zoran Vasiljevic wrote: > >>>> > >>>> > >>>>>On Saturday 05 March 2005 18:36, Vlad Seryakov wrote: > >>>>> > >>>>> > >>>>> > >>>>>>Patch is attached, if everybody is Okay with it i will commit it > >>>>> > >>>>> > >>>>>Do not forget to update include/ns.h > >>>>>and put the prototype there! > >>> > >>> > >>> > >>>------------------------------------------------------- > >>>SF email is sponsored by - The IT Product Guide > >>>Read honest & candid reviews on hundreds of IT Products from real users. > >>>Discover which products truly live up to the hype. Start reading now. > >>>http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click > >>>_______________________________________________ > >>>naviserver-devel mailing list > >>>nav...@li... > >>>https://lists.sourceforge.net/lists/listinfo/naviserver-devel > >> > >>-- > >>Vlad Seryakov > >>571 262-8608 office > >>vl...@cr... > >>http://www.crystalballinc.com/vlad/ > >> > >>------------------------------------------------------- > >>SF email is sponsored by - The IT Product Guide > >>Read honest & candid reviews on hundreds of IT Products from real users. > >>Discover which products truly live up to the hype. Start reading now. > >>http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click > >>_______________________________________________ > >>naviserver-devel mailing list > >>nav...@li... > >>https://lists.sourceforge.net/lists/listinfo/naviserver-devel > >> > > > > > > > > ------------------------------------------------------- > > SF email is sponsored by - The IT Product Guide > > Read honest & candid reviews on hundreds of IT Products from real users. > > Discover which products truly live up to the hype. Start reading now. > > http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click > > _______________________________________________ > > naviserver-devel mailing list > > nav...@li... > > https://lists.sourceforge.net/lists/listinfo/naviserver-devel > > -- > Vlad Seryakov > 571 262-8608 office > vl...@cr... > http://www.crystalballinc.com/vlad/ > > ------------------------------------------------------- > SF email is sponsored by - The IT Product Guide > Read honest & candid reviews on hundreds of IT Products from real users. > Discover which products truly live up to the hype. Start reading now. > http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click > _______________________________________________ > naviserver-devel mailing list > nav...@li... > https://lists.sourceforge.net/lists/listinfo/naviserver-devel > |
From: Vlad S. <vl...@cr...> - 2005-03-08 15:00:52
|
New driver looks interesting but nothing major different from 4.0 except limit pools, and the driver code/logic looks even more complex. Connection and Sock separation is good but still except dynamic limits i do not see advantages of the new driver, of course it is not finished yet but i heard that AOL is going to start testing 4.1 already, so it looks like 4.1 will have what we can see in CVS and something more flexible for new protocols might be there by the next year only. I wouldn't wait for them. Stephen Deasey wrote: > It looks like the change was added to cvs-HEAD ~6 weeks ago, so this > probably wont find it's way to 4.0.10 at all... > > I was just thinking we should keep parity with AOLserver here. The > new driver code promised for AOLserver might depend upon it and it > might start to get messy when we merge with 4.1 if we have to rename > everything. > > -- Vlad Seryakov 571 262-8608 office vl...@cr... http://www.crystalballinc.com/vlad/ |