naviserver-devel — Developer discussion

Re: [naviserver-devel] Bug in fastpath cache causes info leak

[Jeff R. <dv...@di...>]

Brett Schwarz wrote:
> Wow, I am amazed at the different reactions to this issue between
> this list and the aolserver list. Makes me want to switch to
> naviserver even more now...

90% of the difference is that the issue was introduced here by someone
saying "I contributed a patch."  That in itself gets a better reaction 
than hyperbole and insisting that everyone else doesn't know what 
they're talking about.  On the flipside, some of the reactions were 
overly harsh and dismissive.

BTW, the solution in the patch of adding the filename to the hash key
was rejected by the OP.

After all the discussion there, I am generally in agreement that there 
is no real problem other than insufficient documentation, caveats, and 
examples.  But some options to make the cache less aggressive when 
necessary can be a good thing.  Other than adding in the filename (which 
causes more memory to be used) a way to avoid the caching in the first 
place could be good; either a -nocache flag to ns_returnfile or a 
different command (to still get the performance of mmap-ing) or my other 
suggestion of skipping caching for files matching certain patterns 
(e.g., under a particular directory like /tmp, /var/tmp, or whatever) 
would avoid uselessly using up the cache memory in the first place.

As far as the performance impact (of mmap or fastpath in the first 
place) numbers speak louder than speculation, and testing it isn't that 
hard.


-J

Re: [naviserver-devel] Bug in fastpath cache causes info leak

[Brett S. <bre...@ya...>]

Wow, I am amazed at the different reactions to this issue between this list and the aolserver list. Makes me want to switch to naviserver even more now...



----- Original Message ----
From: Vlad Seryakov <vl...@cr...>
To: nav...@li...
Sent: Tuesday, August 19, 2008 5:12:44 PM
Subject: Re: [naviserver-devel] Bug in fastpath cache causes info leak

I agree with this assessment. Nobody's fault in particular but 
unfortunate circumstances. Still the fix is good  and naviserver has 
fastpath cache disabled as oppose to aolserver.

Stephen Deasey wrote:
> fyi, there's talk of a bug in the fastpath cache on the aolserver
> list. I agree with the reporter, John: it's totally busted. I
> committed a fix last night, but if you're not on the commits list you
> won't have seen it. Heads up.
> 
> The fix was to lookup objects in the cache using the file name, as the
> windows code did, and not use the two-stage file name to inode, inode
> to object lookups.
> 
> The only down side might be that if you have files known by more than
> one name, eg symlinks, the cache will hold duplicates and be less
> efficient. But that may not be a great idea anyway: with symlinks,
> user-agents will use different URLs to request the same file, so HTTP
> caching can't be used.
> 
> Also, it seems to me that the problem has nothing to do with dynamic
> content or temp files or the programmer doing anything wrong. You
> could be unlucky with your timing and have random content appear
> instead of the file you expected. For example, two programmers could
> log in to one machine and edit two html documents live. If they happen
> to save at the same time, and there happens to be requests for those
> files which cause them to be cached, and the OS chooses to recycle
> inodes unfavourably, then the contents of either of the files might
> appear to be any other file that has previously been cached by
> fastpath.  Ouch.
> 
> -------------------------------------------------------------------------
> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
> Build the coolest Linux based applications with Moblin SDK & win great prizes
> Grand prize is a trip for two to an Open Source event anywhere in the world
> http://moblin-contest.org/redirect.php?banner_id=100&url=/
> _______________________________________________
> naviserver-devel mailing list
> nav...@li...
> https://lists.sourceforge.net/lists/listinfo/naviserver-devel
> 

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
naviserver-devel mailing list
nav...@li...
https://lists.sourceforge.net/lists/listinfo/naviserver-devel



      

Re: [naviserver-devel] Bug in fastpath cache causes info leak

[Vlad S. <vl...@cr...>]

I agree with this assessment. Nobody's fault in particular but 
unfortunate circumstances. Still the fix is good  and naviserver has 
fastpath cache disabled as oppose to aolserver.

Stephen Deasey wrote:
> fyi, there's talk of a bug in the fastpath cache on the aolserver
> list. I agree with the reporter, John: it's totally busted. I
> committed a fix last night, but if you're not on the commits list you
> won't have seen it. Heads up.
> 
> The fix was to lookup objects in the cache using the file name, as the
> windows code did, and not use the two-stage file name to inode, inode
> to object lookups.
> 
> The only down side might be that if you have files known by more than
> one name, eg symlinks, the cache will hold duplicates and be less
> efficient. But that may not be a great idea anyway: with symlinks,
> user-agents will use different URLs to request the same file, so HTTP
> caching can't be used.
> 
> Also, it seems to me that the problem has nothing to do with dynamic
> content or temp files or the programmer doing anything wrong. You
> could be unlucky with your timing and have random content appear
> instead of the file you expected. For example, two programmers could
> log in to one machine and edit two html documents live. If they happen
> to save at the same time, and there happens to be requests for those
> files which cause them to be cached, and the OS chooses to recycle
> inodes unfavourably, then the contents of either of the files might
> appear to be any other file that has previously been cached by
> fastpath.  Ouch.
> 
> -------------------------------------------------------------------------
> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
> Build the coolest Linux based applications with Moblin SDK & win great prizes
> Grand prize is a trip for two to an Open Source event anywhere in the world
> http://moblin-contest.org/redirect.php?banner_id=100&url=/
> _______________________________________________
> naviserver-devel mailing list
> nav...@li...
> https://lists.sourceforge.net/lists/listinfo/naviserver-devel
> 

Re: [naviserver-devel] CVS, just keep it?

[Vlad S. <vl...@cr...>]

Oh, yes, i got used to deal with CVS and even i remembered about hg, 
first priority was CVS and then hg updated slipped and got forgotten.
I like it but in reality, we need just one repository and if we do 
switch then completely. We can still stick with CVS, but i am ready to 
switch to anything else.

Stephen Deasey wrote:
> So what's the verdict on switching from cvs to mercurial? Or git or whatever?
> 
> Vlad is the only one who gave it a try, but he switched back to cvs.
> 
> There's an orphan commit to mercurial now that isn't in cvs. Here's the patch:
> 
>   http://naviserver.sourceforge.net/hg/naviserver/rev/e5f41846eef4
> 
> 
> I think it's probably better to stay with the familiar cvs. It doesn't
> scare anyone, SF handles everything, and patches are probably too
> infrequent to for the vcs to make much difference anyway.
> 
> Agree?
> 
> -------------------------------------------------------------------------
> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
> Build the coolest Linux based applications with Moblin SDK & win great prizes
> Grand prize is a trip for two to an Open Source event anywhere in the world
> http://moblin-contest.org/redirect.php?banner_id=100&url=/
> _______________________________________________
> naviserver-devel mailing list
> nav...@li...
> https://lists.sourceforge.net/lists/listinfo/naviserver-devel
> 

[naviserver-devel] Bug in fastpath cache causes info leak

[Stephen D. <sd...@gm...>]

fyi, there's talk of a bug in the fastpath cache on the aolserver
list. I agree with the reporter, John: it's totally busted. I
committed a fix last night, but if you're not on the commits list you
won't have seen it. Heads up.

The fix was to lookup objects in the cache using the file name, as the
windows code did, and not use the two-stage file name to inode, inode
to object lookups.

The only down side might be that if you have files known by more than
one name, eg symlinks, the cache will hold duplicates and be less
efficient. But that may not be a great idea anyway: with symlinks,
user-agents will use different URLs to request the same file, so HTTP
caching can't be used.

Also, it seems to me that the problem has nothing to do with dynamic
content or temp files or the programmer doing anything wrong. You
could be unlucky with your timing and have random content appear
instead of the file you expected. For example, two programmers could
log in to one machine and edit two html documents live. If they happen
to save at the same time, and there happens to be requests for those
files which cause them to be cached, and the OS chooses to recycle
inodes unfavourably, then the contents of either of the files might
appear to be any other file that has previously been cached by
fastpath.  Ouch.

[naviserver-devel] CVS, just keep it?

[Stephen D. <sd...@gm...>]

So what's the verdict on switching from cvs to mercurial? Or git or whatever?

Vlad is the only one who gave it a try, but he switched back to cvs.

There's an orphan commit to mercurial now that isn't in cvs. Here's the patch:

  http://naviserver.sourceforge.net/hg/naviserver/rev/e5f41846eef4


I think it's probably better to stay with the familiar cvs. It doesn't
scare anyone, SF handles everything, and patches are probably too
infrequent to for the vcs to make much difference anyway.

Agree?

Re: [naviserver-devel] How to http proxy?

[Vasiljevic Z. <zv...@ar...>]

On 20.08.2008, at 00:05, Stephen Deasey wrote:

> naviserver/tcl/http.tcl
>
> ns_proxy_handler_http

great!
tx

Re: [naviserver-devel] How to http proxy?

[Stephen D. <sd...@gm...>]

On Tue, Aug 19, 2008 at 3:43 PM, Vasiljevic Zoran <zv...@ar...> wrote:
> Hi !
>
> I would need to make a GET/POST/HEAD proxy module for
> HTTP and I recall that somebody did that (Vlad?) but
> I cannot find it in the code (OK I did not look very
> deep). Can somebody point me where to look, quickly?


naviserver/tcl/http.tcl

ns_proxy_handler_http

[naviserver-devel] How to http proxy?

[Vasiljevic Z. <zv...@ar...>]

Hi !

I would need to make a GET/POST/HEAD proxy module for
HTTP and I recall that somebody did that (Vlad?) but
I cannot find it in the code (OK I did not look very
deep). Can somebody point me where to look, quickly?

Thanks
Zoran

[naviserver-devel] TCL 2008 Last Call for participation and papers

[<aku...@sh...>]

*****  TCL 2008 Last Call for participation and papers ******

Note extension of abstract deadline.


http://www.tcl.tk/community/tcl2008/


On October 20-24, 2008,  the city of Manassas, VA will play host to Tcl 
2008.
Join us for what promises to be a memorable, informative and fun 
conference.

Tcl 2008 will be held at the Comfort Suites in Manassas, VA; about 30 miles
outside of Washington DC .   Tutorial sessions on various topics will be
held October 20 and 21.  The technical sessions will run October 22 through
October 24.

*** If you are a student check out the special student rates
*** at the conference website:
*** http://www.tcl.tk/community/tcl2008/ click Registration

If you have an interesting Tcl paper to contribute, a tutorial to offer,
a suggestion to give, submit it to the Tcl 2008 program commitee:
"tcl2008 at tcl dot tk".  Pretty much anything Tcl/Tk is acceptable.
In the past we have had papers on:

* Application of Tcl/Tk in industries as diverse as engineering,
   science, industrial controls, broadcasting, financial services,
   medical   and electronic design
* Networking with Tcl/Tk, including distributed applications and
   network management
* Object frameworks for Tcl/Tk
* New widgets and techniques for GUI design with Tk
* Simulation and application steering with Tcl/Tk
* Tcl/Tk on handheld and embedded devices
* New Tcl extensions and add-ons, including Tcllib and Tklib
* Tcl/Tk centric operating environments
* Tcl/Tk in education and learning environments.


This year is the first year that the Tcl community is participating
in the Google Summer of Code.  The conference program committee
would like to encourage submissions that report on the Tcl projects
selected for Google SOC 2008.

Author Schedule:
* Submit abstracts and tutorial proposals to Tcl2008 at Tcl dot tk by
   August 22, 2008
* Authors will be informed of acceptance by September 7
* Author materials should be submitted to the proceedings editor
   by October 15, 2008

This year we will be making the conference proceedings available as
a published book.  This may impact our plans for when author materials
must be submitted.  Watch future call for participation for more.

Tcl 2008 provides an unparalleled opportunity to discuss your Tcl
projects with some of the world's top Tcl experts.  Past conferences
have included notables like:

* Jeff Hobbs: The Tcl Guy and ActiveState's point man for Tcl
   development and support.
* Clif Flynt: Author of _Tcl/Tk:_A_Developer's_Guide_,  as well
   as the popular TclTutor application.
* Donal Fellows Author of TCL OO.
* Miguel Sofer, Tcl Core team member and byte code compiler expert.
* D. Richard Hipp, Tcl Core Team member and author of sqlite.
* Mike Doyle: Director of Eolas.
* Joe English, Author of the ttk toolkit formerly (and still)
   known as Tile.
* Sean "Hypnotoad" Woods, author of 'that other' Tao.

Confirmed Speakers:
* Jeff Hobbs will present the annual ActiveState of Tcl talk.

Conference Committee:

Local Site:
===========
                       Affiliation
Sean Woods            Test and Evaluation
                       Solutions  LLC              Facilities chair
Clif Flynt            Noumena Corp.               General Chair


Program Committee:

Sean Woods            Test and Evaluations Solutions LLC
Clif Flynt            Noumena Corp.
Steve Redler  IV      SR Technology
Steve Landers         Digital Smarties
Cyndy Lilagan         Iomas Research
Kevin B. Kenny        G.E. Global Research Center.
Jeffrey Hobbs         ActiveState Software Inc.
Andreas Kupries       ActiveState Software Inc.
Ron Fox               NSCL Michigan State University
Donal Fellows         University of Manchester
Larry Virden          Tcl FAQ Maintainer
Mike Doyle            Iomas Research
Matthew M. Burke      George Washington University
Gerald Lester         TicketSwitch USA LLC
Richard Suchenwirth   Siemens Industrial Solutions
                       and Services Postal Automation
                       Division


Tcl 2008 would like to thank those who are sponsoring the conference:

ActiveState Software Inc.
Noumena Corp.
SR Technology
Tcl Association


--
Sincerely,
	Andreas Kupries <aku...@sh...>
			<http://www.purl.org/NET/akupries/>
-------------------------------------------------------------------------------

[naviserver-devel] New PHP module

[Vlad S. <vl...@cr...>]

Summary of new features (from README)



PDO driver for ns_db
---------------------------------------------

This module implemnts internal PDO driver which uses the same ns_db 
handles and pools as
the rest of Naviserver.

To allocate DB handle use:

$db = new PDO("naviserver:poolname");

   where naviserver is PDO driver name and poolname is any pool defined
   in nsd.tcl. After that is works the same way as other PHP PDO drivers.

   The limitations are:
      - all values are strings
      - no native bind parameters, it uses PHP/PDO bind emulation



New native PHP functions
-----------------------------------------


   ns_header name

      Returns HTTP header

   ns_eval(Tcl_script);

      Evaluate Tcl code from PHP script and return result as string

   ns_log(severity, string);

      Put string in the server log, severity is one of
      'Notice', 'Warning', 'Error', 'Debug', 'Fatal'

   ns_info(name);

      Returns information, name can be one of:
         address, boottime, builddate, threads,
         config, home, hostname, locks, log,
         major, minor, name, nsd, pageroot, patchlevel,
         pid, platform, tag, uptime, version, winnt

   ns_conn(name);

     Returns info about current connection, name can be one of:
         authpassword, authuser, close, content, contentlength,
	copy, driver, encoding, flags,
	host, id, isconnected, location, method,
	peeraddr, peerport, port, protocol, query, request,
         server, sock, start, status, url, urlc, urlencoding,
         urlv, version,

   ns_headers();

     Returns input headrs as an array

   ns_outputheaders();

     Returns output headers as an array


   ns_returnredirect(url);

     Performs HTTP redirection


   ns_returndata(status, type, data);
   ns_returnfile(status, type, file);

     Return data or file contents, status is HTTP status like 200, type
     is content type like text/html


   ns_queryexists name

     Returns 1 if query parameter exists in the request

   ns_queryget name

     Returns value of the query parameter

   ns_querygetall

     Returns all query parameters as an array

   ns_nsvget(array, key);
   ns_nsvset(array, key, value);
   ns_nsvincr(array, key, count);
   ns_nsvappend(array, key, value);
   ns_nsvexists(array, key)
   ns_nsv_unset(array, key);

     Interface to NSV arrays of the Naviserver, array is name of the 
array, all
     functions except last 2 will create array if it does not exists. 
Values in NSV arrays
     can be shared with Tcl and other connections.



-- 
Vlad Seryakov
vl...@cr...
http://www.crystalballinc.com/vlad/

Re: [naviserver-devel] Fortran, Oberan, GW-BASIC and ...

[Vlad S. <vl...@cr...>]

I used to be big fan of Python and a long time ago i played with python 
in aolserver. The problem is that Python has one global lock that 
prevents several interpreters running simultaneously. For playing it was 
fun, i guess for not very busy sites it will work fine as well, but for 
high load it is no-go.

Bernd Eidenschink wrote:
> Hi there!
> 
> Anyone ever tried Python with AOLserver/Naviserver?
> 
> Those projects seem stalled, but look(ed) very advanced:
> 
> http://sourceforge.net/projects/pywx/
> http://www.rexx.com/~dkuhlman/aolserver_howto.html
> 
> Just out of curiosity.
> 
> Bernd.
> 
> -------------------------------------------------------------------------
> Check out the new SourceForge.net Marketplace.
> It's the best place to buy or sell services for
> just about anything Open Source.
> http://sourceforge.net/services/buy/index.php
> _______________________________________________
> naviserver-devel mailing list
> nav...@li...
> https://lists.sourceforge.net/lists/listinfo/naviserver-devel
> 

[naviserver-devel] Fortran, Oberan, GW-BASIC and ...

[Bernd E. <eid...@we...>]

Hi there!

Anyone ever tried Python with AOLserver/Naviserver?

Those projects seem stalled, but look(ed) very advanced:

http://sourceforge.net/projects/pywx/
http://www.rexx.com/~dkuhlman/aolserver_howto.html

Just out of curiosity.

Bernd.

[naviserver-devel] nsdbi 0.2 released

[Stephen D. <sd...@gm...>]

Changes and downloads:

    http://sourceforge.net/project/shownotes.php?release_id=605838&group_id=130646

(you'll also need the updated driver)


There are some more inline examples in the man page:

    http://www.groks.org/nsdbi.n.html

Re: [naviserver-devel] Mercurial: naviserver.sourceforge.net/hg/

[Stephen D. <sd...@gm...>]

On Mon, Jun 2, 2008 at 2:08 AM, Vlad Seryakov <vl...@cr...> wrote:
> I decided to try, followed all the instructions.
> First impression is very positive, it was easy. I commited my latest
> changes into hg, so now both repos are in sync.
> I will try to maintain both for a while and see how it goes and will
> import all the modules one by one.


Groovy.

Looks like the commit email got lost somewhere :-/   I thought I had
that sorted...

Also, double-check your ui.username in ~/.hgrc

  [ui]
  username = Vlad Seryakov <vlad@...>

  http://naviserver.sourceforge.net/hg/naviserver/


If you're going to try a conversion, you might want to do something
like rsync the sf cvs repo to your local machine, for speed. The hg
convert command wants to be pointed at a checkout, but it reaches back
into the repo for history.

  rsync -avz --delete \
      rsync://naviserver.cvs.sourceforge.net/cvsroot/naviserver/  \
      ~/in/naviserver-CVSROOT

  cvs -d ~/in/naviserver-CVSROOT co -d ~/co/nsmemcache-HEAD modules/nsmemcache

  echo "seryakov=Vlad Seryakov <vlad@crystal...>" > ~/authors

  hg convert -A ~/authors --config config.hg.usebranchnames=0 --config
config.hg.clonebranches=1 \
      ~/co/nsmemcache-HEAD ~/co/nsmemcache

  cd ~/co/nsmemcache/default

  hg qinit

  hg qimport -r :

  hg up

  hg qpop -a

  ls

  # all gone...

All that's left is to clean up some of the formatting of the commit
messages. Just edit the patch and then push it. (there's only 8
revisions to nsmemcache).

  less .hg/patches/1.diff

  # looks good

  hg qpush

  vi .hg/patches/2.diff

  hg qpush


You will need to add other people to the ~/authors file if they've
touched the module you're converting.

When your done:

  hg clone ~/co/nsmemcache/default ~/co/nsmemcache-hg
  rm -rf ~/co/nsmemcache

  hg clone ~/co/nsmemcache-hg  ssh://sf/ns/hg/nsmemcache

Re: [naviserver-devel] Mercurial: naviserver.sourceforge.net/hg/

[Vlad S. <vl...@cr...>]

I decided to try, followed all the instructions.
First impression is very positive, it was easy. I commited my latest 
changes into hg, so now both repos are in sync.
I will try to maintain both for a while and see how it goes and will 
import all the modules one by one.

Stephen Deasey wrote:
> I updated the naviserver mercurial repo with the latest changes from
> cvs put it on sourceforge:
> 
>   http://naviserver.sourceforge.net/hg/
> 
> 
> To check it out:
> 
>   hg clone http://naviserver.sourceforge.net/hg/naviserver  ~/in/naviserver-hg
> 
> Or, if you've already cloned from the freehg.org repo, you can simply
> update with the differences:
> 
>   hg -R ~/in/navserver-hg pull -u
> 
> The -u at the end means 'and update the working directory'. pull and
> update are 2 separate things.
> The -R saves you from CD'ing into the repo directory.
> 
> If you are updating instead of cloning, you might want to change the
> default pull location in the repo config file:
> 
>   ~/in/naviserver-hg/.hg/hgrc
> 
>   [paths]
>   default = http://naviserver.sourceforge.net/hg/naviserver
> 
> Now you don't have to specify where to pull from each time. cd into
> the repo directory and 'hg pull -u'. Same for other commands which
> work with two repos: incoming, outgoing etc.
> 
> 
> I guess that's how most people would grab a copy of the latest source.
> For people who expect to commit to the public repo themselves you
> might want to clone via ssh. A couple of prerequisites:
> 
> Add something like the following to your ~/.ssh/config file:
> 
>   Host sf shell.sf.net
>     Hostname  shell.sf.net
>     User          yoursfusername
> 
> log into sf and do the following:
> 
>   ssh sf
>   ln -s /home/groups/n/na/naviserver ~/ns
>   echo "source /home/groups/n/na/naviserver/bashc" >> ~/.bashrc
> 
> bashrc just sets the umask correctly and adds the 'hg' command to the PATH.
> 
> Now you can clone via ssh:
> 
>   hg clone ssh://sf/ns/hg/naviserver ~/in/naviserver-hg
> 
> That's also where you push to make your commits public.
> 
>   hg clone ~/in/naviserver-hg ~/ns-work
>   cd ~/work
>   ... hack hack hack ...
>   hg commit
>   hg push ssh://sf/ns/hg/naviserver
> 
> 
> For people who don't have direct commit access, and with mercurial
> that's really no disadvantage, perhaps a good way to work is to use
> the 'patchbomb' extension.  Add the following to your ~/.hgrc file:
> 
>   [extensions]
>   patchbomb=
> 
>   [email]
>   from = Your Name <you@wherever>
> 
>   [smtp]
>   host = smtp.gmail.com
>   port = 587
>   tls = 1
>   username = you@wherever
>   password = ****
> 
> (or whatever)
> 
> btw. you'll also want to make sure that the following is present --
> it's what your name appears as in the commit message:
> 
>   [ui]
>   username = Your Name <you@wherever>
> 
> 
> Now, to publish your last commit (the tip, aka HEAD) you could do:
> 
>   hg email -r tip --to nav...@li...
> 
>   ('hg help email' for more)
> 
> The patch is created as an attachment such that it can exactly
> reproduce the commit when imported to another repo, including the
> committer name, date etc., so full credit is always given.  At this
> point some one with commit access would import the patch, check it,
> and if OK push it:
> 
>   hg import ~/saved-email
>   hg push
> 
> 
> Commit Messages:
> 
> Format them like an email. A single like subject of about ~70 chars,
> followed by a blank like, followed by the body, word wrapped to ~80
> chars.  Keyword stuff the subject so that folks can get the gist of it
> by skimming. Prefix with a module name such as nsperm: if you think it
> makes sense. Say 'Add ...' instead of 'Added ...'.
> 
> 
> 
> The commit messages should be working, and so is cia.vc. Here's an example:
> 
> http://sourceforge.net/mailarchive/message.php?msg_id=hg.1883a10a6e0c.1210791169.-2015825136%40sc8-pr-shella-b.sourceforge.net
> 
> 
> Does this all look OK?
> 
> -------------------------------------------------------------------------
> This SF.net email is sponsored by: Microsoft
> Defy all challenges. Microsoft(R) Visual Studio 2008.
> http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
> _______________________________________________
> naviserver-devel mailing list
> nav...@li...
> https://lists.sourceforge.net/lists/listinfo/naviserver-devel
> 

-- 
Vlad Seryakov
vl...@cr...
http://www.crystalballinc.com/vlad/

Re: [naviserver-devel] nsmemcached

[Vlad S. <vl...@cr...>]

Nice catch

Daniel Stasinski wrote:
> On Tue, May 27, 2008 at 10:30 AM, Vlad Seryakov <vl...@cr...> wrote:
>> Just tested it, works fine regardless is it first time or not
> 
> I spent an hour going through it and tracked down the problem.
> 
>    rc = mc_conn_read(conn, BUFSIZE, 1, &line);
> 
> On the first read, the line arg is set to point to an offset within
> conn->ds.dstring.   The problem is that mc_conn_read() there are calls
> to Ns_DStringSetLength() which can (and does) relocate
> conn->ds.dstring, therefor leaving &line pointing to a deallocated
> memory block.   The only time ds.dstring is in a static location is
> when it's 200 bytes or less.
> 
> I just happened come across a perhaps a platform specific set of data
> that could duplicate the problem over and over.
> 
> Will patch and update cvs.
> 
> Daniel
> 

Re: [naviserver-devel] nsmemcached

[Daniel S. <moo...@av...>]

On Tue, May 27, 2008 at 10:30 AM, Vlad Seryakov <vl...@cr...> wrote:
> Just tested it, works fine regardless is it first time or not

I spent an hour going through it and tracked down the problem.

   rc = mc_conn_read(conn, BUFSIZE, 1, &line);

On the first read, the line arg is set to point to an offset within
conn->ds.dstring.   The problem is that mc_conn_read() there are calls
to Ns_DStringSetLength() which can (and does) relocate
conn->ds.dstring, therefor leaving &line pointing to a deallocated
memory block.   The only time ds.dstring is in a static location is
when it's 200 bytes or less.

I just happened come across a perhaps a platform specific set of data
that could duplicate the problem over and over.

Will patch and update cvs.

Daniel

-- 
| ---------------------------------------------------------------
| Daniel P. Stasinski | http://www.saidsimple.com
| moo...@av... | http://www.disabilities-r-us.com
| XMMP: moo...@av... | http://www.avenues.org
| Google Talk: mooooooo | http://www.scriptkitties.com

Re: [naviserver-devel] nsmemcached

[Stephen D. <sd...@gm...>]

On Tue, May 27, 2008 at 8:12 PM, Vlad Seryakov <vl...@cr...> wrote:
>>
>>
>> Looks like the 'expires' and 'flags' variables might be uninitialised
>> for the cmdSet etc. commands if values aren't passed from Tcl.
>
> In CVS version 1.5 they are initialized with 0
>


Thinking about flags...

If you remove -flags from the Tcl interface then you could use it to
distinguish between urf8 and byte arrays. ATM all data is sent as a
byte array, which is flexible. But probably a lot of the data will be
utf8 strings, and in that case it gets converted on the way in, and
again on the way out.  It would be more efficient to save the data in
it's native format.

Re: [naviserver-devel] nsmemcached

[Vlad S. <vl...@cr...>]

> 
> 
> Looks like the 'expires' and 'flags' variables might be uninitialised
> for the cmdSet etc. commands if values aren't passed from Tcl.

In CVS version 1.5 they are initialized with 0

Re: [naviserver-devel] nsmemcached

[Stephen D. <sd...@gm...>]

On Tue, May 27, 2008 at 6:30 PM, Vlad Seryakov <vl...@cr...> wrote:
>
> Daniel Stasinski wrote:
>>
>> I have noticed a quirk in the nsmemcache module.  On the very first
>> "get" command from a fresh restart of nsd, it will not read past about
>> 1379 bytes and returns a partial chunk of data.  The length is
>> correct, but the data past 1379 is corrupt.
>>
>> To set, I performed:
>>
>>    ns_memcache set bigdata [string repeat "X" 2048]
>>
>> Next, I killed and restarted nsd and performed:
>>
>>    ns_puts [ns_memcache get bigdata text]<br>        ' returns 1
>>    ns_puts [string length $text]<br/>                           ' returns 2048
>>    ns_puts $text
>>
>> All subsequent reads are correct.  Only the very first read is affected.
>>
>
> Just tested it, works fine regardless is it first time or not
>
> I am using latest version from CVS of server and the module on Archlinux
> 2.6.24-ARCH
>


Looks like the 'expires' and 'flags' variables might be uninitialised
for the cmdSet etc. commands if values aren't passed from Tcl.

Re: [naviserver-devel] nsmemcached

[Vlad S. <vl...@cr...>]

Just tested it, works fine regardless is it first time or not

I am using latest version from CVS of server and the module on Archlinux 
2.6.24-ARCH

Daniel Stasinski wrote:
> I have noticed a quirk in the nsmemcache module.  On the very first
> "get" command from a fresh restart of nsd, it will not read past about
> 1379 bytes and returns a partial chunk of data.  The length is
> correct, but the data past 1379 is corrupt.
> 
> To set, I performed:
> 
>    ns_memcache set bigdata [string repeat "X" 2048]
> 
> Next, I killed and restarted nsd and performed:
> 
>    ns_puts [ns_memcache get bigdata text]<br>        ' returns 1
>    ns_puts [string length $text]<br/>                           ' returns 2048
>    ns_puts $text
> 
> All subsequent reads are correct.  Only the very first read is affected.
> 
> Daniel
> 

[naviserver-devel] nsmemcached

[Daniel S. <moo...@av...>]

I have noticed a quirk in the nsmemcache module.  On the very first
"get" command from a fresh restart of nsd, it will not read past about
1379 bytes and returns a partial chunk of data.  The length is
correct, but the data past 1379 is corrupt.

To set, I performed:

   ns_memcache set bigdata [string repeat "X" 2048]

Next, I killed and restarted nsd and performed:

   ns_puts [ns_memcache get bigdata text]<br>        ' returns 1
   ns_puts [string length $text]<br/>                           ' returns 2048
   ns_puts $text

All subsequent reads are correct.  Only the very first read is affected.

Daniel

-- 
| ---------------------------------------------------------------
| Daniel P. Stasinski | http://www.saidsimple.com
| moo...@av... | http://www.disabilities-r-us.com
| XMMP: moo...@av... | http://www.avenues.org
| Google Talk: mooooooo | http://www.scriptkitties.com

Re: [naviserver-devel] gzip compression fixes

[Daniel S. <moo...@av...>]

On Fri, May 23, 2008 at 1:54 PM, Stephen Deasey <sd...@gm...> wrote:
> What are the bugs that are fixed here? The message doesn't say.

When gzip is enabled for adp's, Internet Explorer 6 quietly rejects it
and renders nothing.  Firefox is forgiving of malformed gzip pages, IE
is not.   Curl also grumbles:  curl --compressed --trace - -i
mydomain.com

I had fixed this in AOLserver 4.0.10 cvs over 3 years ago and was
surprised it had crept back in.

When compress2() is done, it pads the destination buffer with 4 extra
bytes.  To be honest, I don't remember why it does this.  I did long
ago, but I don't now.  I do recall verifying it by comparing the
output of ns_gzip to the output of unix command line gzip.

The changes to the code rewind those 4 bytes and then appends the
footer.   Network byte ordering is not used.  The net result is an RFC
1952 complaint gzip file, which is what Internet Explorer 6 and curl
seem to demand.

Also, manually calculating the size destination buffer is deprecated.
compressBound() is advised.

Daniel
-- 
| ---------------------------------------------------------------
| Daniel P. Stasinski | http://www.saidsimple.com
| moo...@av... | http://www.disabilities-r-us.com
| XMMP: moo...@av... | http://www.avenues.org
| Google Talk: mooooooo | http://www.scriptkitties.com

Re: [naviserver-devel] drop CVS (was: [AOLSERVER] nsdbi database driver interface 0.1)

[Stephen D. <sd...@gm...>]

On Wed, May 7, 2008 at 10:11 AM, Vasiljevic Zoran <zv...@ar...> wrote:
>
> On 06.05.2008, at 01:56, Stephen Deasey wrote:
>
>> I am too lazy to write that essay. You should try it out to see what
>> you're missing out on.  Here's a starter:
>
> That _was_ the essay! Thanks for going to such extent to
> show me what SVN can do.
>
> I recall watching a video on YouTube with Linus Thorvalds
>
>      http://www.youtube.com/watch?v=4XpnKHJAok8
>
> where he takes both CVS and SVN under heavy barrage,
> advocating for his GIT solution. As we are in the process
> of considering a repository change, I thought everybody
> should be at least informed about the other possibilities.


That's a great video. Here's another, a Google Tech Talk on Mercurial:

  http://video.google.com/videoplay?docid=-7724296011317502612

It's a while since I watched them both, but as I recall, they both
talk more about the ideas behind dvcs, less than they do the
particular commands. So it's an easy listen.

Linus makes great points about things like git not needing commit
permissions as cvs does and how this changes the dynamics of the
project for the better -- no people on the inside vs. those on the
outside.  And things like clone and diff and commit being
instantaneous, encouraging exploratory development.