naviserver-devel — Developer discussion

[naviserver-devel] Re: [naviserver-commits] naviserver/nslog nslog.c,1.1.1.1,1.2

[Stephen D. <sd...@gm...>]

I've noticed some problems with this recent change.


The log message doesn't say what has changed, just that something has
changed, although the ChangeLog entry is better.  The X-Forwarded-For
change is a bug fix and is not mentioned in either.  I thought we'd
already agreed that non-trivial changes should have an RFE or BUG
posted to the tracker?


It's unreasonable to expect end users to examine the source code for
documentation, so we should not clutter up the code with it.  There
are no other source files I'm aware of which do this.


The members of the Log struct have been re-arranged.  Variable
declarations beginning a function have moved around.  Many of the
comments have been reformatted.  Correctly formatted code has had
braces and spacing removed, etc.  This all makes it very tricky to
read diffs to figure out what has logically changed.


Code like the following:

logPtr->file = Ns_ConfigGetValue(path, "file");
if (logPtr->file == NULL) {
    logPtr->file = "access.log";
}

Has been changed into code like this:

if(!(logPtr->file = Ns_ConfigGetValue(path,"file"))) logPtr->file =
"access.log";
logPtr->file = ns_strdup(logPtr->file);

This is not an improvement in readability, and doesn't follow our code
formatting conventions.


The RCSID static variable is missing.



On Tue, 01 Mar 2005 21:39:59 +0000, Vlad Seryakov
<ser...@us...> wrote:
> Update of /cvsroot/naviserver/naviserver/nslog
> In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv2963/nslog
> 
> Modified Files:
>         nslog.c
> Log Message:
> Added more options to the module and to the command ns_accesslog
> 
> Index: nslog.c
> ===================================================================
> RCS file: /cvsroot/naviserver/naviserver/nslog/nslog.c,v
> retrieving revision 1.1.1.1
> retrieving revision 1.2
> diff -C2 -d -r1.1.1.1 -r1.2
> *** nslog.c     16 Feb 2005 08:41:00 -0000      1.1.1.1
> --- nslog.c     1 Mar 2005 21:39:57 -0000       1.2
> ***************
> *** 1,10 ****
>   /*
> !  * The contents of this file are subject to the AOLserver Public License
> !  * Version 1.1 (the "License"); you may not use this file except in
>    * compliance with the License. You may obtain a copy of the License at
> !  * http://aolserver.com/.
>    *
>    * Software distributed under the License is distributed on an "AS IS"
> !  * basis, WITHOUT WARRANTY OF ANY KIND, either express or implied. See
>    * the License for the specific language governing rights and limitations
>    * under the License.
> [...1216 lines suppressed...]
> !     logPtr->extheaders = ns_calloc((size_t)(i + 1), sizeof *logPtr->extheaders);
> !
> !     logPtr->extheaders[0] = config;
> !
> !     for (i = 1, p = config; *p; p++) {
> !       if (*p == ',') {
> !           *p = '\000';
> !           logPtr->extheaders[i++] = p + 1;
> !       }
> !     }
> !
> !     logPtr->extheaders[i] = NULL;
> !
>   }
> -
> --- 736,739 ----
>   LogRollCallback(void *arg)
>   {
> !     LogCallback(LogRoll,arg,"roll");
>   }

Re: [naviserver-devel] Does Ns_ParseObjv() look ok?

[Zoran V. <zv...@ar...>]

On Monday 28 February 2005 08:25, Stephen Deasey wrote:
> I was thinking about making the Ns_ObjvBool proc look at it's arg, and
> if present, place that in the destination pointer and not consume an
> object from the objv array.  The presence of the option (without
> argument) alone would signify true, it's absence false.
> 
> Then I realised I left out the short-circuit logic...  When a --
> (break) arg is found the options are assumed to have ended and we jump
> to arg processing.  The signal for this is that the Ns_ObjvBreak proc
> returns exactly objc.  But that's really what the Bool proc should
> return in the case described above when it doesn't consume an arg.
> 
> Unfortunately it's not as simple as that.  The "wrong num args"
> description needs to know that the option takes no argument too.
> 
> 
> Any thoughts?

And if Ns_ObjvBreak returns zero as a signal that none
of the options are expected any more:

    remain = specPtr->proc(specPtr->dest, interp, objc, objv + objvIndex,
                           specPtr->arg);
    if (remain == 0 || remain == objc) {
        remain = objc;
        break;
    }

Hm?
Zoran

Re: [naviserver-devel] Does Ns_ParseObjv() look ok?

[Stephen D. <sd...@gm...>]

I was thinking about making the Ns_ObjvBool proc look at it's arg, and
if present, place that in the destination pointer and not consume an
object from the objv array.  The presence of the option (without
argument) alone would signify true, it's absence false.

Then I realised I left out the short-circuit logic...  When a --
(break) arg is found the options are assumed to have ended and we jump
to arg processing.  The signal for this is that the Ns_ObjvBreak proc
returns exactly objc.  But that's really what the Bool proc should
return in the case described above when it doesn't consume an arg.

Unfortunately it's not as simple as that.  The "wrong num args"
description needs to know that the option takes no argument too.


Any thoughts?

Re: [naviserver-devel] Does Ns_ParseObjv() look ok?

[Zoran V. <zv...@ar...>]

On Tuesday 22 February 2005 00:27, Stephen Deasey wrote:
> Has anyone had a chance to look at the Ns_ParseObjv() patch I posted?
> 
> http://sourceforge.net/tracker/index.php?func=detail&aid=1122940&group_id=130646&atid=719009
> 
> My main concern is that the general approach is about right.  Does it
> make sense?  One thing I notice is that there's no facility to check
> the presence of a switch that doesn't take an arg, a boolean switch. 


It makes sense. I have checked this in and took the liberty to 
reformat it a little to maintain the 80-char margin, fix tabs 
to spaces and a touch in function comment headers here/there.
I hope you don't mind... I'm just an old nitpicker!

> That is a simple Ns_ObjvProc plugin.

Yup. This we should add as well.

Oh, yes... I changed Ns_ObjvString to optionally return 
the length of the parsed string in *arg. This should not
break anything, as I see it, or?

int
Ns_ObjvString(void *dest, Tcl_Interp *interp, int objc, Tcl_Obj *CONST objv[],
              void *arg)
{
    if (objc > 0) {
        if (arg == NULL) {
            *((char **) dest) = Tcl_GetString(objv[0]);
        } else {
            *((char **) dest) = Tcl_GetStringFromObj(objv[0], (int*)arg);
        }
        return --objc;
    }

    return -1;
}

Cheers
Zoran

[naviserver-devel] Unavailable until Friday, 4 March

[Zoran V. <zv...@ar...>]

Hi all,

As you may have noticed, I'm not giving any signs of myself
lately. This is not because I'm lazy. This is because we have
some pretty tought things to resolve concerning our product
and this eats up all of my time. I anticipate to get all this
done until 04.03 (friday in a week). 

Cheer's
Zoran

Re: [naviserver-devel] Does Ns_ParseObjv() look ok?

[Zoran V. <zv...@ar...>]

On Tuesday 22 February 2005 00:27, Stephen Deasey wrote:
> Has anyone had a chance to look at the Ns_ParseObjv() patch I posted?
> 
> http://sourceforge.net/tracker/index.php?func=detail&aid=1122940&group_id=130646&atid=719009
> 
> My main concern is that the general approach is about right.  Does it
> make sense?  One thing I notice is that there's no facility to check
> the presence of a switch that doesn't take an arg, a boolean switch. 
> That is a simple Ns_ObjvProc plugin.
> 
> I have a couple of other patches which use the facility so I'd like to
> make some headway with it.
>
Yup. Been very busy in last few days. Did however looked at it
very briefly. Yes, there's no facility to check a switch-type arg.
This is what I immediately saw. Apart from that I didn't give it 
a try (which is what I'd like to, as soon as this support issues 
are off my back :( )

Cheers
Zoran

Re: [naviserver-devel] Backwards compatibility

[Zoran V. <zv...@ar...>]

On Tuesday 22 February 2005 00:21, Stephen Deasey wrote:

> That ugly data union is to support ns_register_proc and friends which
> take a 'conn' argument.  The conn arg is no longer used and hasn't
> been since the server was released as open source.  It's only there
> for backwards compatibility.

Scrap it.
Zoran

[naviserver-devel] Does Ns_ParseObjv() look ok?

[Stephen D. <sd...@gm...>]

Has anyone had a chance to look at the Ns_ParseObjv() patch I posted?

http://sourceforge.net/tracker/index.php?func=detail&aid=1122940&group_id=130646&atid=719009

My main concern is that the general approach is about right.  Does it
make sense?  One thing I notice is that there's no facility to check
the presence of a switch that doesn't take an arg, a boolean switch. 
That is a simple Ns_ObjvProc plugin.

I have a couple of other patches which use the facility so I'd like to
make some headway with it.


Thanks!

[naviserver-devel] Backwards compatibility

[Stephen D. <sd...@gm...>]

What's the story on backwards compatibility?  I'd say we should try to
maintain backwards compatibility where ever possible, and examine it
on a case-by-case basis.  So here's the case I'm thinking of:

I created some infrastructure to help write C functions which take Tcl
callbacks.  The structure which gets passed around looks like this:

typedef struct Ns_TclCallback {
    char     *server;
    char     *script;
    char     *scriptarg;
    union {
        int   intValue;
        void *ptrValue;
    } data;
} Ns_TclCallback;

That ugly data union is to support ns_register_proc and friends which
take a 'conn' argument.  The conn arg is no longer used and hasn't
been since the server was released as open source.  It's only there
for backwards compatibility.

So my question is, would anyone be upset if I removed support for
passing around a fake 'conn' in functions like ns_register_proc,
ns_conn, etc.?  I seem to remember it's removal was mentioned on the
other list some time ago, and it certainly makes the docs hard to
read.

Re: [naviserver-devel] Please update ChangeLog after making changes

[Stephen D. <sd...@gm...>]

If you're an emacs user, then C-x v-a is like cvs2cl, except it merges
in only the entries not already there.

Maybe better is something like C-x 4-a which creates the ChangeLog
entry before you commit, so everything can be commited togther.  You
can cut 'n paste from the ChangeLog buffer into the commit message.

The ChangeLog is important for people who download tarballs or install
RPMs etc., so we should try to keep up-to-date at all times.




On Thu, 17 Feb 2005 19:00:36 +0100, Zoran Vasiljevic <zv...@ar...> wrote:
> On Thursday 17 February 2005 18:47, Vlad Seryakov wrote:
> > It is really no big deal, we can maintain ChangeLog manually, use
> > comments from cvs using that script and
> > just appending it.
> 
> I see... Well, I will have to make myself acquainted
> with it. I hate doing cut/paste all the time when commiting
> but haven't find out any other way. This seems to be one...
> 
> Zoran
> 
> 
> -------------------------------------------------------
> SF email is sponsored by - The IT Product Guide
> Read honest & candid reviews on hundreds of IT Products from real users.
> Discover which products truly live up to the hype. Start reading now.
> http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
> _______________________________________________
> naviserver-devel mailing list
> nav...@li...
> https://lists.sourceforge.net/lists/listinfo/naviserver-devel
>

Re: [naviserver-devel] Please update ChangeLog after making changes

[Zoran V. <zv...@ar...>]

On Thursday 17 February 2005 18:47, Vlad Seryakov wrote:
> It is really no big deal, we can maintain ChangeLog manually, use 
> comments from cvs using that script and
> just appending it.

I see... Well, I will have to make myself acquainted 
with it. I hate doing cut/paste all the time when commiting
but haven't find out any other way. This seems to be one...

Zoran

Re: [naviserver-devel] Please update ChangeLog after making changes

[Vlad S. <vl...@cr...>]

It is really no big deal, we can maintain ChangeLog manually, use 
comments from cvs using that script and
just appending it.


Zoran Vasiljevic wrote:
> On Thursday 17 February 2005 18:19, Vlad Seryakov wrote:
> 
>>What i did was just ran
>>cvs2cl.pl in the naviserver directory.
>>Our history is small, so it produces the whole ChanleLog pretty quickly.
> 
> 
> Aha. So it will always regenerate the whole file from scratch...
> Hmmm... This way the information entered in the file will be 
> zeroed and recreated? This is semi-good since any deliberate
> edits will go away, or? 
> Is there a way to make it somehow selective?
> 
> 
> -------------------------------------------------------
> SF email is sponsored by - The IT Product Guide
> Read honest & candid reviews on hundreds of IT Products from real users.
> Discover which products truly live up to the hype. Start reading now.
> http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
> _______________________________________________
> naviserver-devel mailing list
> nav...@li...
> https://lists.sourceforge.net/lists/listinfo/naviserver-devel

-- 
Vlad Seryakov
571 262-8608 office
vl...@cr...
http://www.crystalballinc.com/vlad/

Re: [naviserver-devel] Please update ChangeLog after making changes

[Zoran V. <zv...@ar...>]

On Thursday 17 February 2005 18:19, Vlad Seryakov wrote:
> What i did was just ran
> cvs2cl.pl in the naviserver directory.
> Our history is small, so it produces the whole ChanleLog pretty quickly.

Aha. So it will always regenerate the whole file from scratch...
Hmmm... This way the information entered in the file will be 
zeroed and recreated? This is semi-good since any deliberate
edits will go away, or? 
Is there a way to make it somehow selective?

Re: [naviserver-devel] Please update ChangeLog after making changes

[Vlad S. <vl...@cr...>]

when run as cvs2cl.pl --stdout -l "-d>=2005-02-17"

it will produce changelog since that date on the stdout, so
it is easy to append changelog since the last entry, do not reproduce 
the whole file every time

We can generate chanmgelog every week or daily, not with every commit.

Vlad Seryakov wrote:
> What i did was just ran
> cvs2cl.pl in the naviserver directory.
> Our history is small, so it produces the whole ChanleLog pretty quickly.
> 
> 
> Zoran Vasiljevic wrote:
> 
>> On Thursday 17 February 2005 17:53, Vlad Seryakov wrote:
>>
>>> Works pretty nice, i just tested it.
>>>
>>> Can we use it ?
>>
>>
>>
>> If you explain me how, I'm all for it! But, be gentle... I'm an old 
>> man :-)
>> Care for an "executive update" or "cvs2cl for dummies" ?
>>
>> Zoran
> 
> 
> 
> ------------------------------------------------------------------------
> 
> 2005-02-17 09:19  seryakov
> 
> 	* ChangeLog: updated changelog
> 
> 2005-02-17 04:43  vasiljevic
> 
> 	* ChangeLog: See file
> 
> 2005-02-17 04:43  vasiljevic
> 
> 	* nsd/tclfile.c: Fixed broken NsTclChanObjCmd command which caused
> 	  server crashes when trasporting channels between threads when
> 	  linked against Tcl 8.4+
> 
> 2005-02-16 11:45  seryakov
> 
> 	* Makefile, configure.in, sample-config.tcl,
> 	  include/Makefile.build, include/Makefile.global.in,
> 	  include/Makefile.module.in, include/ns.h, include/nsdb.h,
> 	  include/nsextmsg.h, include/nspd.h, include/nsthread.h,
> 	  tcl/charsets.tcl, tcl/compat.tcl, tcl/debug.tcl,
> 	  tcl/fastpath.tcl, tcl/file.tcl, tcl/form.tcl, tcl/http.tcl,
> 	  tcl/init.tcl, tcl/modlog.tcl, tcl/nsdb.tcl, tcl/sendmail.tcl,
> 	  tcl/util.tcl: License terms in the headers are changed to
> 	  Mozilla.  sendmail proc extended to support cc as argument and
> 	  possibly ignore error on receiving QUIT response, some mail
> 	  servers just drop the connection and then sendmail generate
> 	  error. ns_getform checks for connection and if no connection
> 	  returns empty instead of generate error, to be used safely in
> 	  schedule scripts when same code runs on the Web frontend and
> 	  backend.
> 
> 2005-02-16 10:59  seryakov
> 
> 	* nsd/init.c: In rare cases when dns resolver cannot resolve the
> 	  hostname on startup and tries to log this error it crashes
> 	  because log was not initilized yet.
> 
> 2005-02-16 10:05  seryakov
> 
> 	* configure, include/Makefile.global.in,
> 	  include/Makefile.module.in, nsd/binder.c, nsd/tclsock.c,
> 	  nsdb/dbdrv.c: Binder suppport for different protocols added,
> 	  supported TCP/UDP/ICMP/UNIX protocols. Added
> 	  Ns_SockListenUdp,Ns_SockListenRaw,Ns_SockListenUnix functions.
> 	  Backported sockopen command from 4.1 tree with
> 	  -localhost/-localport options. db select will reuse exception
> 	  which driver set otherwise will set standard error about wrong
> 	  query.
> 
> 2005-02-16 03:38  vasiljevic
> 
> 	* Makefile, README, aclocal.m4, sample-config.tcl, configure,
> 	  configure.in, install-sh, ChangeLog, license.terms, doc/Ns_Db.3,
> 	  doc/Ns_Fd.3, doc/Ns_Alloc.3, doc/Ns_Htuu.3, doc/Ns_Info.3,
> 	  doc/ns_getchannels.n, doc/Ns_List.3, doc/Ns_Mime.3,
> 	  doc/Ns_TclDbGetHandle.3, doc/Ns_Thread.3, doc/ns_shutdown.n,
> 	  doc/ns_writefp.n, doc/Ns_Adp.3, doc/Ns_Cls.3, doc/Ns_DbPool.3,
> 	  doc/Ns_Env.3, doc/Ns_QuoteHtml.3, doc/ns_return.n, doc/Ns_Log.3,
> 	  doc/Ns_Nsd.3, doc/Ns_Set.3, doc/Ns_ThreadAlloc.3, doc/Ns_Tls.3,
> 	  doc/Ns_Uid.3, doc/Ns_Pool.3, doc/Ns_Rand.3, doc/Ns_Reentrant.3,
> 	  doc/Ns_Url.3, doc/install-doc, doc/ns_modulepath.n,
> 	  doc/Ns_Cache.3, doc/Ns_DString.3, doc/Ns_Sema.3, doc/Ns_Sock.3,
> 	  doc/nsd.1, doc/Ns_DbUtil.3, doc/Ns_Index.3, doc/Ns_Time.3,
> 	  doc/ns_crash.n, doc/ns_crypt.n, doc/ns_library.n,
> 	  doc/ns_rollfile.n, doc/Ns_DbDriver.3, doc/Ns_String.3,
> 	  doc/Ns_TclConn.3, doc/ns_headers.n, doc/ns_httptime.n,
> 	  doc/Ns_Pathname.3, doc/Ns_SockIO.3, doc/Ns_TclFile.3,
> 	  doc/Ns_TclSet.3, doc/Ns_UrlSpecific.3, doc/ns_module.n,
> 	  doc/Ns_ConnRequest.3, doc/Ns_TclInit.3, doc/ns_parseheader.n,
> 	  doc/ns_sched.n, doc/ns_url2file.n, doc/Ns_IntPrint.3,
> 	  doc/Ns_Register.3, doc/ns_config.n, doc/ns_filter.n,
> 	  doc/ns_markfordelete.n, doc/ns_share.n, doc/mkLinks,
> 	  doc/ns_requestauthorize.n, doc/ns_sleep.n, doc/ns_geturl.n,
> 	  doc/Ns_TclRegister.3, doc/ns_adp.n, doc/ns_env.n, doc/ns_img.n,
> 	  doc/Ns_Encoding.3, doc/ns_job.n, doc/ns_log.n, doc/ns_set.n,
> 	  doc/Ns_Encrypt.3, doc/Ns_Sched.3, doc/Ns_Signal.3,
> 	  doc/Ns_Thread2.3, doc/ns_tmp.n, doc/ns_uuencode.n,
> 	  doc/Ns_ConnCopy.3, doc/Ns_ConnWrite.3, doc/Ns_ServerSpecific.3,
> 	  doc/Ns_SockErrno.3, doc/Ns_TclTimeObj.3, doc/ns_logroll.n,
> 	  doc/ns_purgefiles.n, doc/Ns_CritSec.3, doc/Ns_Fetch.3,
> 	  doc/Ns_Filter.3, doc/Ns_Module.3, doc/Ns_Request.3, doc/ns_at.n,
> 	  doc/ns_parsequery.n, doc/ns_thread.n, doc/Ns_ConnRead.3,
> 	  doc/Ns_ConnReturn.3, doc/Ns_ProcInfo.3, doc/Ns_UrlToFile.3,
> 	  doc/ns_addr.n, doc/ns_db.n, doc/Ns_ConnSend.3, doc/Ns_Driver.3,
> 	  doc/Ns_ExtDb.3, doc/Ns_TclThread.3, doc/ns_chan.n, doc/ns_conn.n,
> 	  doc/Ns_Config.3, doc/Ns_Master.3, doc/Ns_SockCallback.3,
> 	  doc/ns_eval.n, doc/ns_file.n, doc/ns_normalizepath.n,
> 	  doc/man.macros, doc/ns_html.n, doc/ns_http.n, doc/ns_info.n,
> 	  doc/ns_init.n, doc/Ns_Mutex.3, doc/Ns_RWLock.3,
> 	  doc/Ns_RollFile.3, doc/Ns_TempFile.3, doc/ns_guesstype.n,
> 	  doc/ns_kill.n, doc/ns_urlencode.n, doc/Ns_HttpTime.3,
> 	  doc/Ns_InetAddr.3, doc/Ns_UrlEncode.3, doc/ns_proc.n,
> 	  doc/ns_rand.n, doc/Ns_Auth.3, doc/Ns_DbSp.3, doc/Ns_TclInterp.3,
> 	  doc/ns_cache.n, doc/Ns_Cond.3, doc/Ns_Conn.3,
> 	  doc/Ns_ConnHeaders.3, doc/Ns_Location.3, doc/ns_sock.n,
> 	  doc/Ns_ConnDriver.3, doc/Ns_Exec.3, doc/ns_checkurl.n,
> 	  doc/ns_sync.n, doc/ns_time.n, nsd/binder.c, nsd/fd.c, nsd/op.c,
> 	  nsd/Makefile, nsd/encoding.c, nsd/listen.c, nsd/dsprintf.c,
> 	  nsd/cls.c, nsd/crypt.c, nsd/dns.c, nsd/log.c, nsd/nsd.h,
> 	  nsd/set.c, nsd/str.c, nsd/url.c, nsd/queue.c, nsd/return.c,
> 	  nsd/uuencode.c, nsd/mimetypes.c, nsd/sched.c, nsd/urlopen.c,
> 	  nsd/nswin32.c, nsd/dstring.c, nsd/tclrequest.c, nsd/adpparse.c,
> 	  nsd/tclthread.c, nsd/compress.c, nsd/filter.c, nsd/stamp.c,
> 	  nsd/fastpath.c, nsd/auth.c, nsd/conn.c, nsd/tclatclose.c,
> 	  nsd/driver.c, nsd/config.c, nsd/connio.c, nsd/tclcmds.c,
> 	  nsd/tclconf.c, nsd/exec.c, nsd/random.c, nsd/form.c,
> 	  nsd/nsconf.c, nsd/nsconf.h, nsd/getopt.c, nsd/getopt.h,
> 	  nsd/request.c, nsd/callbacks.c, nsd/adprequest.c, nsd/tclfile.c,
> 	  nsd/modload.c, nsd/info.c, nsd/init.c, nsd/tclsched.c,
> 	  nsd/urlencode.c, nsd/tclhttp.c, nsd/tclinit.c, nsd/urlspace.c,
> 	  nsd/lisp.c, nsd/main.c, nsd/tclshare.c, nsd/nsmain.c,
> 	  nsd/nsthread.c, nsd/proc.c, nsd/tclmisc.c, nsd/pidfile.c,
> 	  nsd/sock.c, nsd/tclresp.c, nsd/unix.c, nsd/tclsock.c,
> 	  nsd/server.c, nsd/tclxkeylist.c, nsd/adpcmds.c, nsd/pathname.c,
> 	  nsd/adpeval.c, nsd/cache.c, nsd/init.tcl, nsd/quotehtml.c,
> 	  nsd/rollfile.c, nsd/index.c, nsd/httptime.c, nsd/sockcallback.c,
> 	  nsd/tclenv.c, nsd/tclimg.c, nsd/tcljob.c, nsd/tclobj.c,
> 	  nsd/tclset.c, nsd/tclvar.c, tcl/charsets.tcl, tcl/compat.tcl,
> 	  tcl/debug.tcl, tcl/fastpath.tcl, tcl/file.tcl, tcl/form.tcl,
> 	  tcl/http.tcl, tcl/nsdb.tcl, tcl/prodebug.tcl, tcl/sendmail.tcl,
> 	  tcl/init.tcl, tcl/modlog.tcl, tcl/stats.tcl, tcl/util.tcl,
> 	  nsdb/db.h, nsdb/dbdrv.c, nsdb/Makefile, nsdb/dbtcl.c,
> 	  nsdb/dbinit.c, nscp/Makefile, nsdb/dbutil.c, nsdb/nsdb.c,
> 	  nscp/nscp.c, nspd/pd.h, nspd/Makefile, nspd/listen.c, nspd/log.c,
> 	  nscgi/Makefile, nspd/main.c, nscgi/nscgi.c, nsext/Makefile,
> 	  nsext/msg.c, nsext/nsext.c, nslog/Makefile, nslog/nslog.c,
> 	  tests/http-test-config.tcl, tests/http.test,
> 	  tests/ns_addrbyhost.test, tests/ns_hostbyaddr.test,
> 	  tests/ns_hrefs.test, tests/all.tcl, tests/harness.tcl,
> 	  tests/ns_adp_compress.test,
> 	  tests/servers/server1/pages/ns_adp_compress.adp,
> 	  win32/aolserver.dsw, win32/nsd/nsd.dsp, win32/group/grpall.dsp,
> 	  win32/main/main.dsp, win32/nscp/nscp.dsp, win32/nsdb/nsdb.dsp,
> 	  win32/test/nsd.tcl, win32/test/servers/test/pages/cgitest.bat,
> 	  win32/test/servers/test/pages/index.adp, win32/group/grpcore.dsp,
> 	  win32/group/grpopenacs.dsp, win32/nscgi/nscgi.dsp,
> 	  win32/nslog/nslog.dsp, win32/nsperm/nsperm.dsp,
> 	  win32/nssock/nssock.dsp, nsperm/Makefile, nsperm/compat.tcl,
> 	  nsperm/group, nsperm/hosts.allow, nsperm/passwd, nsperm/perms,
> 	  win32/cgitest/cgitest.dsp, win32/cgitest/main.c,
> 	  win32/nsthread/nsthread.dsp, win32/threadtest/threadtest.dsp,
> 	  nsperm/hosts.deny, nsperm/init.tcl, nsperm/nsperm.c,
> 	  nssock/Makefile, nssock/nssock.c, nsthread/Makefile,
> 	  nsthread/cslock.c, nsthread/nsthreadtest.c, nsthread/pthread.c,
> 	  nsthread/tls.c, nsthread/signal.c, nsthread/error.c,
> 	  nsthread/winthread.c, nsthread/compat.c, nsthread/fork.c,
> 	  nsthread/master.c, nsthread/reentrant.c, nsthread/mutex.c,
> 	  nsthread/sema.c, nsthread/time.c, nsthread/rwlock.c,
> 	  nsthread/thread.c, nsthread/thread.h, nsthread/memory.c,
> 	  include/ns.h, include/Makefile.module.in, include/nsdb.h,
> 	  include/nspd.h, include/Makefile.build,
> 	  include/Makefile.global.in, include/nsextmsg.h,
> 	  include/nsthread.h: Initial import
> 
> 2005-02-16 03:38  vasiljevic
> 
> 	* Makefile, README, aclocal.m4, sample-config.tcl, configure,
> 	  configure.in, install-sh, ChangeLog, license.terms, doc/Ns_Db.3,
> 	  doc/Ns_Fd.3, doc/Ns_Alloc.3, doc/Ns_Htuu.3, doc/Ns_Info.3,
> 	  doc/ns_getchannels.n, doc/Ns_List.3, doc/Ns_Mime.3,
> 	  doc/Ns_TclDbGetHandle.3, doc/Ns_Thread.3, doc/ns_shutdown.n,
> 	  doc/ns_writefp.n, doc/Ns_Adp.3, doc/Ns_Cls.3, doc/Ns_DbPool.3,
> 	  doc/Ns_Env.3, doc/Ns_QuoteHtml.3, doc/ns_return.n, doc/Ns_Log.3,
> 	  doc/Ns_Nsd.3, doc/Ns_Set.3, doc/Ns_ThreadAlloc.3, doc/Ns_Tls.3,
> 	  doc/Ns_Uid.3, doc/Ns_Pool.3, doc/Ns_Rand.3, doc/Ns_Reentrant.3,
> 	  doc/Ns_Url.3, doc/install-doc, doc/ns_modulepath.n,
> 	  doc/Ns_Cache.3, doc/Ns_DString.3, doc/Ns_Sema.3, doc/Ns_Sock.3,
> 	  doc/nsd.1, doc/Ns_DbUtil.3, doc/Ns_Index.3, doc/Ns_Time.3,
> 	  doc/ns_crash.n, doc/ns_crypt.n, doc/ns_library.n,
> 	  doc/ns_rollfile.n, doc/Ns_DbDriver.3, doc/Ns_String.3,
> 	  doc/Ns_TclConn.3, doc/ns_headers.n, doc/ns_httptime.n,
> 	  doc/Ns_Pathname.3, doc/Ns_SockIO.3, doc/Ns_TclFile.3,
> 	  doc/Ns_TclSet.3, doc/Ns_UrlSpecific.3, doc/ns_module.n,
> 	  doc/Ns_ConnRequest.3, doc/Ns_TclInit.3, doc/ns_parseheader.n,
> 	  doc/ns_sched.n, doc/ns_url2file.n, doc/Ns_IntPrint.3,
> 	  doc/Ns_Register.3, doc/ns_config.n, doc/ns_filter.n,
> 	  doc/ns_markfordelete.n, doc/ns_share.n, doc/mkLinks,
> 	  doc/ns_requestauthorize.n, doc/ns_sleep.n, doc/ns_geturl.n,
> 	  doc/Ns_TclRegister.3, doc/ns_adp.n, doc/ns_env.n, doc/ns_img.n,
> 	  doc/Ns_Encoding.3, doc/ns_job.n, doc/ns_log.n, doc/ns_set.n,
> 	  doc/Ns_Encrypt.3, doc/Ns_Sched.3, doc/Ns_Signal.3,
> 	  doc/Ns_Thread2.3, doc/ns_tmp.n, doc/ns_uuencode.n,
> 	  doc/Ns_ConnCopy.3, doc/Ns_ConnWrite.3, doc/Ns_ServerSpecific.3,
> 	  doc/Ns_SockErrno.3, doc/Ns_TclTimeObj.3, doc/ns_logroll.n,
> 	  doc/ns_purgefiles.n, doc/Ns_CritSec.3, doc/Ns_Fetch.3,
> 	  doc/Ns_Filter.3, doc/Ns_Module.3, doc/Ns_Request.3, doc/ns_at.n,
> 	  doc/ns_parsequery.n, doc/ns_thread.n, doc/Ns_ConnRead.3,
> 	  doc/Ns_ConnReturn.3, doc/Ns_ProcInfo.3, doc/Ns_UrlToFile.3,
> 	  doc/ns_addr.n, doc/ns_db.n, doc/Ns_ConnSend.3, doc/Ns_Driver.3,
> 	  doc/Ns_ExtDb.3, doc/Ns_TclThread.3, doc/ns_chan.n, doc/ns_conn.n,
> 	  doc/Ns_Config.3, doc/Ns_Master.3, doc/Ns_SockCallback.3,
> 	  doc/ns_eval.n, doc/ns_file.n, doc/ns_normalizepath.n,
> 	  doc/man.macros, doc/ns_html.n, doc/ns_http.n, doc/ns_info.n,
> 	  doc/ns_init.n, doc/Ns_Mutex.3, doc/Ns_RWLock.3,
> 	  doc/Ns_RollFile.3, doc/Ns_TempFile.3, doc/ns_guesstype.n,
> 	  doc/ns_kill.n, doc/ns_urlencode.n, doc/Ns_HttpTime.3,
> 	  doc/Ns_InetAddr.3, doc/Ns_UrlEncode.3, doc/ns_proc.n,
> 	  doc/ns_rand.n, doc/Ns_Auth.3, doc/Ns_DbSp.3, doc/Ns_TclInterp.3,
> 	  doc/ns_cache.n, doc/Ns_Cond.3, doc/Ns_Conn.3,
> 	  doc/Ns_ConnHeaders.3, doc/Ns_Location.3, doc/ns_sock.n,
> 	  doc/Ns_ConnDriver.3, doc/Ns_Exec.3, doc/ns_checkurl.n,
> 	  doc/ns_sync.n, doc/ns_time.n, nsd/binder.c, nsd/fd.c, nsd/op.c,
> 	  nsd/Makefile, nsd/encoding.c, nsd/listen.c, nsd/dsprintf.c,
> 	  nsd/cls.c, nsd/crypt.c, nsd/dns.c, nsd/log.c, nsd/nsd.h,
> 	  nsd/set.c, nsd/str.c, nsd/url.c, nsd/queue.c, nsd/return.c,
> 	  nsd/uuencode.c, nsd/mimetypes.c, nsd/sched.c, nsd/urlopen.c,
> 	  nsd/nswin32.c, nsd/dstring.c, nsd/tclrequest.c, nsd/adpparse.c,
> 	  nsd/tclthread.c, nsd/compress.c, nsd/filter.c, nsd/stamp.c,
> 	  nsd/fastpath.c, nsd/auth.c, nsd/conn.c, nsd/tclatclose.c,
> 	  nsd/driver.c, nsd/config.c, nsd/connio.c, nsd/tclcmds.c,
> 	  nsd/tclconf.c, nsd/exec.c, nsd/random.c, nsd/form.c,
> 	  nsd/nsconf.c, nsd/nsconf.h, nsd/getopt.c, nsd/getopt.h,
> 	  nsd/request.c, nsd/callbacks.c, nsd/adprequest.c, nsd/tclfile.c,
> 	  nsd/modload.c, nsd/info.c, nsd/init.c, nsd/tclsched.c,
> 	  nsd/urlencode.c, nsd/tclhttp.c, nsd/tclinit.c, nsd/urlspace.c,
> 	  nsd/lisp.c, nsd/main.c, nsd/tclshare.c, nsd/nsmain.c,
> 	  nsd/nsthread.c, nsd/proc.c, nsd/tclmisc.c, nsd/pidfile.c,
> 	  nsd/sock.c, nsd/tclresp.c, nsd/unix.c, nsd/tclsock.c,
> 	  nsd/server.c, nsd/tclxkeylist.c, nsd/adpcmds.c, nsd/pathname.c,
> 	  nsd/adpeval.c, nsd/cache.c, nsd/init.tcl, nsd/quotehtml.c,
> 	  nsd/rollfile.c, nsd/index.c, nsd/httptime.c, nsd/sockcallback.c,
> 	  nsd/tclenv.c, nsd/tclimg.c, nsd/tcljob.c, nsd/tclobj.c,
> 	  nsd/tclset.c, nsd/tclvar.c, tcl/charsets.tcl, tcl/compat.tcl,
> 	  tcl/debug.tcl, tcl/fastpath.tcl, tcl/file.tcl, tcl/form.tcl,
> 	  tcl/http.tcl, tcl/nsdb.tcl, tcl/prodebug.tcl, tcl/sendmail.tcl,
> 	  tcl/init.tcl, tcl/modlog.tcl, tcl/stats.tcl, tcl/util.tcl,
> 	  nsdb/db.h, nsdb/dbdrv.c, nsdb/Makefile, nsdb/dbtcl.c,
> 	  nsdb/dbinit.c, nscp/Makefile, nsdb/dbutil.c, nsdb/nsdb.c,
> 	  nscp/nscp.c, nspd/pd.h, nspd/Makefile, nspd/listen.c, nspd/log.c,
> 	  nscgi/Makefile, nspd/main.c, nscgi/nscgi.c, nsext/Makefile,
> 	  nsext/msg.c, nsext/nsext.c, nslog/Makefile, nslog/nslog.c,
> 	  tests/http-test-config.tcl, tests/http.test,
> 	  tests/ns_addrbyhost.test, tests/ns_hostbyaddr.test,
> 	  tests/ns_hrefs.test, tests/all.tcl, tests/harness.tcl,
> 	  tests/ns_adp_compress.test,
> 	  tests/servers/server1/pages/ns_adp_compress.adp,
> 	  win32/aolserver.dsw, win32/nsd/nsd.dsp, win32/group/grpall.dsp,
> 	  win32/main/main.dsp, win32/nscp/nscp.dsp, win32/nsdb/nsdb.dsp,
> 	  win32/test/nsd.tcl, win32/test/servers/test/pages/cgitest.bat,
> 	  win32/test/servers/test/pages/index.adp, win32/group/grpcore.dsp,
> 	  win32/group/grpopenacs.dsp, win32/nscgi/nscgi.dsp,
> 	  win32/nslog/nslog.dsp, win32/nsperm/nsperm.dsp,
> 	  win32/nssock/nssock.dsp, nsperm/Makefile, nsperm/compat.tcl,
> 	  nsperm/group, nsperm/hosts.allow, nsperm/passwd, nsperm/perms,
> 	  win32/cgitest/cgitest.dsp, win32/cgitest/main.c,
> 	  win32/nsthread/nsthread.dsp, win32/threadtest/threadtest.dsp,
> 	  nsperm/hosts.deny, nsperm/init.tcl, nsperm/nsperm.c,
> 	  nssock/Makefile, nssock/nssock.c, nsthread/Makefile,
> 	  nsthread/cslock.c, nsthread/nsthreadtest.c, nsthread/pthread.c,
> 	  nsthread/tls.c, nsthread/signal.c, nsthread/error.c,
> 	  nsthread/winthread.c, nsthread/compat.c, nsthread/fork.c,
> 	  nsthread/master.c, nsthread/reentrant.c, nsthread/mutex.c,
> 	  nsthread/sema.c, nsthread/time.c, nsthread/rwlock.c,
> 	  nsthread/thread.c, nsthread/thread.h, nsthread/memory.c,
> 	  include/ns.h, include/Makefile.module.in, include/nsdb.h,
> 	  include/nspd.h, include/Makefile.build,
> 	  include/Makefile.global.in, include/nsextmsg.h,
> 	  include/nsthread.h: Initial revision
> 

-- 
Vlad Seryakov
571 262-8608 office
vl...@cr...
http://www.crystalballinc.com/vlad/

Re: [naviserver-devel] Please update ChangeLog after making changes

[Vlad S. <vl...@cr...>]

What i did was just ran
cvs2cl.pl in the naviserver directory.
Our history is small, so it produces the whole ChanleLog pretty quickly.


Zoran Vasiljevic wrote:
> On Thursday 17 February 2005 17:53, Vlad Seryakov wrote:
> 
>>Works pretty nice, i just tested it.
>>
>>Can we use it ?
> 
> 
> If you explain me how, I'm all for it! 
> But, be gentle... I'm an old man :-)
> Care for an "executive update" or "cvs2cl for dummies" ?
> 
> Zoran

-- 
Vlad Seryakov
571 262-8608 office
vl...@cr...
http://www.crystalballinc.com/vlad/

Re: [naviserver-devel] Please update ChangeLog after making changes

[Zoran V. <zv...@ar...>]

On Thursday 17 February 2005 17:53, Vlad Seryakov wrote:
> Works pretty nice, i just tested it.
> 
> Can we use it ?

If you explain me how, I'm all for it! 
But, be gentle... I'm an old man :-)
Care for an "executive update" or "cvs2cl for dummies" ?

Zoran

Re: [naviserver-devel] Please update ChangeLog after making changes

[Vlad S. <vl...@cr...>]

Works pretty nice, i just tested it.

Can we use it ?

This way we just enter comments when commit.

Zoran Vasiljevic wrote:
> On Thursday 17 February 2005 15:59, Bernd Eidenschink wrote:
> 
>>Hi,
>>
>>
>>>On Thursday 17 February 2005 15:06, Vlad Seryakov wrote:
>>>
>>>>Sure, i have already put explanation in the cvs log, i thought ChangeLog
>>>>generated from it.
>>>
>>>Huh, I don't know how this works. I always edit the ChangeLog by hand.
>>>Do you know how to generate ChangeLog entries out of the cvs logs?
>>
>>http://directory.fsf.org/all/cvs2cl.html
>>http://www.red-bean.com/cvs2cl
>>
> 
> 
> Hey, this is nice. I suppose I will have to make myself a test-try
> and see how this works. Anybody has some experience?
> 
> Zoran
> 
> 
> -------------------------------------------------------
> SF email is sponsored by - The IT Product Guide
> Read honest & candid reviews on hundreds of IT Products from real users.
> Discover which products truly live up to the hype. Start reading now.
> http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
> _______________________________________________
> naviserver-devel mailing list
> nav...@li...
> https://lists.sourceforge.net/lists/listinfo/naviserver-devel

-- 
Vlad Seryakov
571 262-8608 office
vl...@cr...
http://www.crystalballinc.com/vlad/

Re: [naviserver-devel] Please update ChangeLog after making changes

[Bernd E. <eid...@we...>]

> > http://directory.fsf.org/all/cvs2cl.html
> > http://www.red-bean.com/cvs2cl
>
> Hey, this is nice. I suppose I will have to make myself a test-try
> and see how this works. Anybody has some experience?

As a subversion-converted I can't help you much, but AFAIK calling it without 
args produces a what-did-we-do-since-world-was-created-long-listing. You can 
pass args to the underlying CVS to restrict output to certain tags or 
revisions.

See -g or -l options from the usage:
http://www.red-bean.com/cvs2cl/cvs2cl-usage.txt

Bernd.

Re: [naviserver-devel] Please update ChangeLog after making changes

[Zoran V. <zv...@ar...>]

On Thursday 17 February 2005 15:59, Bernd Eidenschink wrote:
> Hi,
> 
> > On Thursday 17 February 2005 15:06, Vlad Seryakov wrote:
> > > Sure, i have already put explanation in the cvs log, i thought ChangeLog
> > > generated from it.
> >
> > Huh, I don't know how this works. I always edit the ChangeLog by hand.
> > Do you know how to generate ChangeLog entries out of the cvs logs?
> 
> http://directory.fsf.org/all/cvs2cl.html
> http://www.red-bean.com/cvs2cl
>

Hey, this is nice. I suppose I will have to make myself a test-try
and see how this works. Anybody has some experience?

Zoran

Re: [naviserver-devel] Please update ChangeLog after making changes

[Bernd E. <eid...@we...>]

Hi,

> On Thursday 17 February 2005 15:06, Vlad Seryakov wrote:
> > Sure, i have already put explanation in the cvs log, i thought ChangeLog
> > generated from it.
>
> Huh, I don't know how this works. I always edit the ChangeLog by hand.
> Do you know how to generate ChangeLog entries out of the cvs logs?

http://directory.fsf.org/all/cvs2cl.html
http://www.red-bean.com/cvs2cl

Bernd.

Re: [naviserver-devel] Please update ChangeLog after making changes

[Zoran V. <zv...@ar...>]

On Thursday 17 February 2005 15:06, Vlad Seryakov wrote:
> Sure, i have already put explanation in the cvs log, i thought ChangeLog 
> generated from it.

Huh, I don't know how this works. I always edit the ChangeLog by hand.
Do you know how to generate ChangeLog entries out of the cvs logs?

Cheers,
Zoran

Re: [naviserver-devel] Please update ChangeLog after making changes

[Vlad S. <vl...@cr...>]

Sure, i have already put explanation in the cvs log, i thought ChangeLog 
generated from it.

Zoran Vasiljevic wrote:
> Hi!
> 
> We should always update the ChangeLog after making changes to the tree.
> This way one can immediately see what has been done lately. 
> 
> Vlad, can you please reflect changes made in files below into
> the ChangeLog? I know I'm a pest, but it is really important
> to do so. One simple short sentence would do...
> 
> P Makefile
> P configure
> P configure.in
> P sample-config.tcl
> P include/Makefile.build
> P include/Makefile.global.in
> P include/Makefile.module.in
> P include/ns.h
> P include/nsdb.h
> P include/nsextmsg.h
> P include/nspd.h
> P include/nsthread.h
> P nsd/binder.c
> P nsd/init.c
> P nsd/tclsock.c
> P nsdb/dbdrv.c
> P tcl/charsets.tcl
> P tcl/compat.tcl
> P tcl/debug.tcl
> P tcl/fastpath.tcl
> P tcl/file.tcl
> P tcl/form.tcl
> P tcl/http.tcl
> P tcl/init.tcl
> cvs update: tcl/modlog.tcl is no longer in the repository
> P tcl/nsdb.tcl
> P tcl/sendmail.tcl
> P tcl/util.tcl
> 
> Cheers,
> Zoran
> 
> 
> -------------------------------------------------------
> SF email is sponsored by - The IT Product Guide
> Read honest & candid reviews on hundreds of IT Products from real users.
> Discover which products truly live up to the hype. Start reading now.
> http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
> _______________________________________________
> naviserver-devel mailing list
> nav...@li...
> https://lists.sourceforge.net/lists/listinfo/naviserver-devel

-- 
Vlad Seryakov
571 262-8608 office
vl...@cr...
http://www.crystalballinc.com/vlad/

[naviserver-devel] Please update ChangeLog after making changes

[Zoran V. <zv...@ar...>]

Hi!

We should always update the ChangeLog after making changes to the tree.
This way one can immediately see what has been done lately. 

Vlad, can you please reflect changes made in files below into
the ChangeLog? I know I'm a pest, but it is really important
to do so. One simple short sentence would do...

P Makefile
P configure
P configure.in
P sample-config.tcl
P include/Makefile.build
P include/Makefile.global.in
P include/Makefile.module.in
P include/ns.h
P include/nsdb.h
P include/nsextmsg.h
P include/nspd.h
P include/nsthread.h
P nsd/binder.c
P nsd/init.c
P nsd/tclsock.c
P nsdb/dbdrv.c
P tcl/charsets.tcl
P tcl/compat.tcl
P tcl/debug.tcl
P tcl/fastpath.tcl
P tcl/file.tcl
P tcl/form.tcl
P tcl/http.tcl
P tcl/init.tcl
cvs update: tcl/modlog.tcl is no longer in the repository
P tcl/nsdb.tcl
P tcl/sendmail.tcl
P tcl/util.tcl

Cheers,
Zoran

[naviserver-devel] cvs import done

[Zoran V. <zv...@ar...>]

This is how to checkout:

  cvs -d:ext:<developername>@cvs.sourceforge.net:/cvsroot/naviserver co naviserver

This will create a "naviserver" directory in your current directory
and checkout all files there.
But, what am I telling you... You're all experienced guys :-)

I took the freedom and modified the README file to get rid of 
the AOL references. Also, for the software installation root 
I think of "/usr/local/ns" per default (didn't change anything
in this respect in the sources yet).

Well, it's there now. Feel freee to hack the beast :-)

Cheers
Zoran

Re: [naviserver-devel] cleanup before first import (questions)

[Stephen D. <sd...@gm...>]

Tried out the tarball and it doesn't compile with tcl 8.5 from cvs. 
Neither does standard aolserver 4.0.10, but my fork does.  I don't
think this has to be fixed before initial import -- that's what cvs is
for... :-)

Looks like we're good to go.  Don't worry, I'll fill up the bug
tracker for you...



On Tue, 15 Feb 2005 17:26:02 +0100, Zoran Vasiljevic <zv...@ar...> wrote:
> On Saturday 12 February 2005 17:53, Zoran Vasiljevic wrote:
> >
> > This is the current layout:
> >
> > aclocal.m4  configure.in  include      install-sh     nscgi  nsdb   nspd    nsssl     sample-config.tcl  tests
> > ChangeLog   CVS           index.html   license.terms  nscp   nsext  nsperm  nsthread  tcl                win32
> > configure   doc           ini2tcl.tcl  Makefile       nsd    nslog  nssock  README    tcl2ini.tcl
> >
> 
> I have done the initial cleanup:
> 
>   o. removed all those silly *.html pages from various places
>      containing nothing but (mostly) junk; this info should
>      go into the docs finally
> 
>   o. removed traces of nsssl module
> 
>   o. removed most of the tests and kept only those written
>      lately which utilize tcltest environment
> 
>   o. reset ChangeLog
> 
>   o. removed ini2tcl.tcl and tcl2ini.tcl files
> 
> I have put the tarball on the:
> 
>    http://www.archiware.com/www/downloads/aolserver_v40_r10.tar.gz
> 
> for you to check. If there are any things you need to fix,
> tell now, so we can proceed.
> 
> Cheers
> Zoran
> 
> 
> -------------------------------------------------------
> SF email is sponsored by - The IT Product Guide
> Read honest & candid reviews on hundreds of IT Products from real users.
> Discover which products truly live up to the hype. Start reading now.
> http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
> _______________________________________________
> naviserver-devel mailing list
> nav...@li...
> https://lists.sourceforge.net/lists/listinfo/naviserver-devel
>