naviserver-devel — Developer discussion

Re: [naviserver-devel] Re: [naviserver-commits] naviserver/nsd tclobjv.c,1.7,1.8 tclresp.c,1.4,1.5

[Zoran V. <zv...@ar...>]

Am 10.06.2005 um 15:41 schrieb Vlad Seryakov:

> * Tcl_GetByteArrayFromObj --
> *
> *      Attempt to get the array of bytes from the Tcl object.  If the
> *      object is not already a ByteArray object, an attempt will be
> *      made to convert it to one.
>
> So, if i call ns_return from Tcl and pass data parameter, it will  
> be always type of String. ByteArrays are created from Tcl by binary  
> command only, other commands work with String types, so i need to  
> tell ns_return to treat data as bytearray. Tcl string
> can contain binary data but it is still String and that check will  
> never work for binary data.
>

I'm afraid you are right. I also have my own (binary-aware) ns_return  
somewhere
in my toolbox but never thought it would be of general interest.

OTOH, the "ns_return -binary" would look nicer but I do not
know if we'd be backwardly-compatible (guess not).

Zoran

Re: [naviserver-devel] binder, sockets

[Zoran V. <zv...@ar...>]

Am 10.06.2005 um 15:46 schrieb Vlad Seryakov:

> Looks like you already know what to do, so go ahead and cleanup  
> that stuff.
>

Vlad,

Can you do me a favour and try the my new checkin of binder.c?
I think I got it all right, but you never know until you
test it. The usual TCP stuff works. I have not tried the
rest (it should work though).

Cheers
Zoran

[naviserver-devel] config.h

[Vlad S. <vl...@cr...>]

Is it possible to rename config.h to nsconfig.h?

-- 
Vlad Seryakov
571 262-8608 office
vl...@cr...
http://www.crystalballinc.com/vlad/

Re: [naviserver-devel] Re: [naviserver-commits] naviserver/nsd tclobjv.c,1.7,1.8 tclresp.c,1.4,1.5

[Vlad S. <vl...@cr...>]

Yes, i see.
fixed

Stephen Deasey wrote:
> On 6/9/05, Vlad Seryakov <vl...@cr...> wrote:
> 
>>I have no failed tests
>>
>>Tests running in interp:  /home/vlad/src/naviserver/nsd/nsd
>>Tests located in:  /home/vlad/src/naviserver/tests
>>Tests running in:  /home/vlad/src/naviserver/tests
>>Temporary files stored in /home/vlad/src/naviserver/tests
>>Test files sourced into current interpreter
>>Running tests that match:  *
>>Skipping test files that match:  l.*.test
>>Only running test files that match:  *.test
>>Tests began at Thu Jun 09 08:30:29 PM EDT 2005
>>http.test
>>ns_addrbyhost.test
>>ns_adp_compress.test
>>[09/Jun/2005:20:30:29][5516.3073625008][-conn:test::0] Notice: encoding:
>>loaded: iso8859-1
>>ns_conn_host.test
>>ns_hashpath.test
>>ns_hostbyaddr.test
>>ns_hrefs.test
>>ns_nsv.test
>>ns_pagepath.test
>>ns_parseargs.test
>>ns_serverpath.test
>>ns_urlencode.test
>>tclresp.test
>>
>>Tests ended at Thu Jun 09 08:30:30 PM EDT 2005
>>all.tcl:        Total   193     Passed  193     Skipped 0       Failed  0
>>Sourced 13 Test Files.
> 
> 
> 
> The test server is linking against some other libnsd.so you have
> installed on the machine, so you're not testing what you think you're
> testing...
> 
> Unfortunately LD_LIBRARY_PATH isn't enough to fix this as the lib
> locations are embeded into the binaries with rpath.  I'm not sure what
> the best way to fix this is yet, but as a temporary measure you can
> configure your test server with --prefix=/tmp/nsdtest, i.e. something
> other than the installed nsd.
> 
> 
> -------------------------------------------------------
> This SF.Net email is sponsored by: NEC IT Guy Games.  How far can you shotput
> a projector? How fast can you ride your desk chair down the office luge track?
> If you want to score the big prize, get to know the little guy.  
> Play to win an NEC 61" plasma display: http://www.necitguy.com/?r 
> _______________________________________________
> naviserver-devel mailing list
> nav...@li...
> https://lists.sourceforge.net/lists/listinfo/naviserver-devel

-- 
Vlad Seryakov
571 262-8608 office
vl...@cr...
http://www.crystalballinc.com/vlad/

Re: [naviserver-devel] binder, sockets

[Vlad S. <vl...@cr...>]

Looks like you already know what to do, so go ahead and cleanup that stuff.

Zoran Vasiljevic wrote:
> Hi!
> 
> I'm in the process of cleaning up the code in order to
> re-enable Windows compilation.
> I've found several things we'd need to unify somehow:
> 
> We have (until recently) had only TCP protocol support
> hence the calls like:
> 
>   Ns_SockBind
>   Ns_SockListen
>   etc.
> 
> As of now, there are multiple other connection options
> supported (raw sockets, udp sockets, unix domain sockets).
> There are couple of places in the code where I see:
> 
> 
> Ns_SockBindUdp
> 
> Ns_SockListenEx
> Ns_SockListenUdp
> Ns_SockListenRaw
> Ns_SockListenUnix
> 
> I'd like to bring in some logic there. Therefore the proposal:
> 
> All TCP related calls should stay as-is.
> 
> We'd add additional calls to better identify what's being done:
> 
>   Ns_SockListenTcp   (new, should be called by Ns_SocketListen)
>   Ns_SockListenUdp   (exists)
>   Ns_SockListenRaw   (exists)
>   Ns_SockListenUnix  (exists)
> 
> Then:
> 
>   Ns_SockBindTcp   (new, should be called by Ns_SocketBind)
>   Ns_SockBindUdp   (exists)
>   Ns_SockBindRaw   (new)
>   Ns_SockBindUnix  (new)
> 
> In binder.c there are some calls which are only used withing the
> file hence we'd need to adjust the call interface to illustrate
> this:
> 
>   Ns_SockRaw  - > SockRaw
> 
> Also, the Ns_SockListenUnix is a combination of create + bind
> but unlike other pendants, does not honour the preboundUnix sockets.
> We should split this. Make the Ns_SockListenUnix actually
> honour prebound sockets (which it does not do now) and use
> internally the Ns_SockBindUnix to bind so it'd be on-pair with
> the TCP.
> 
> All in all, this will not change the functionality but will
> *definitely* improve understanding and code maintenance.
> There are other places in sock.c which seem pretty odd like
> 
>   Ns_SockBind calls Ns_BindSock
> 
> what is the reason of having those two (backward-compat?)
> 
> I will like to cleanup this now. Are there any voices against
> or any other ideas?
> 
> Cheers
> Zoran
> 
> 
> -------------------------------------------------------
> This SF.Net email is sponsored by: NEC IT Guy Games.  How far can you 
> shotput
> a projector? How fast can you ride your desk chair down the office luge 
> track?
> If you want to score the big prize, get to know the little guy.  Play to 
> win an NEC 61" plasma display: http://www.necitguy.com/?r=20
> _______________________________________________
> naviserver-devel mailing list
> nav...@li...
> https://lists.sourceforge.net/lists/listinfo/naviserver-devel

-- 
Vlad Seryakov
571 262-8608 office
vl...@cr...
http://www.crystalballinc.com/vlad/

Re: [naviserver-devel] Re: [naviserver-commits] naviserver/nsd tclobjv.c,1.7,1.8 tclresp.c,1.4,1.5

[Vlad S. <vl...@cr...>]

* Tcl_GetByteArrayFromObj --
*
*      Attempt to get the array of bytes from the Tcl object.  If the
*      object is not already a ByteArray object, an attempt will be
*      made to convert it to one.

So, if i call ns_return from Tcl and pass data parameter, it will be 
always type of String. ByteArrays are created from Tcl by binary command 
only, other commands work with String types, so i need to tell ns_return 
to treat data as bytearray. Tcl string
can contain binary data but it is still String and that check will never 
work for binary data.

Stephen Deasey wrote:
> I think it's fine to also alow ns_return to handle binary data, I'm
> just wondering if it should be with the extra command ns_returnbinary?
> 
> It looks like you can simple check the type of the Tcl object passed
> to ns_return for "bytearray".  That's the only case it makes sense to
> write the bytes directly.
> 
> The advantage over ns_returnbinary is that in many cases the uses
> doesn't have to know what's going on.  e.g. a command which creates a
> png graph would be returned as a byte array, and if passed to
> ns_return everything should just work.
> 
> 
> 
> On 6/9/05, Vlad Seryakov <vl...@cr...> wrote:
> 
>>ns_respond now supports binary so ns_returnbinary is redundant, but i
>>think Tcl_GetByteArray works with string and byte array, just
>>Tcl_GetByteArray does not do eny encoding/converting to/From utf.
>>
>>Stephen Deasey wrote:
>>
>>>Before you cvs commit, you must make test.  Two tests are broken...
>>>We're strugeling for tests, but tclresp.c is one file that does have a
>>>reasonably complete set.  Can you add some for the new commands?
>>>Also, the cut 'n paste comment for Ns_ObjvByteArray is no longer
>>>correct.
>>>
>>>I was wondering, is ns_returnbinary necessary?  What if ns_return was
>>>modified to check the type of it's data arg, and if it's byterray,
>>>send using Ns_ConnReturnData.  Would this work?
> 
> 
> 
> -------------------------------------------------------
> This SF.Net email is sponsored by: NEC IT Guy Games.  How far can you shotput
> a projector? How fast can you ride your desk chair down the office luge track?
> If you want to score the big prize, get to know the little guy.  
> Play to win an NEC 61" plasma display: http://www.necitguy.com/?r 
> _______________________________________________
> naviserver-devel mailing list
> nav...@li...
> https://lists.sourceforge.net/lists/listinfo/naviserver-devel

-- 
Vlad Seryakov
571 262-8608 office
vl...@cr...
http://www.crystalballinc.com/vlad/

[naviserver-devel] binder, sockets

[Zoran V. <zv...@ar...>]

Hi!

I'm in the process of cleaning up the code in order to
re-enable Windows compilation.
I've found several things we'd need to unify somehow:

We have (until recently) had only TCP protocol support
hence the calls like:

   Ns_SockBind
   Ns_SockListen
   etc.

As of now, there are multiple other connection options
supported (raw sockets, udp sockets, unix domain sockets).
There are couple of places in the code where I see:


Ns_SockBindUdp

Ns_SockListenEx
Ns_SockListenUdp
Ns_SockListenRaw
Ns_SockListenUnix

I'd like to bring in some logic there. Therefore the proposal:

All TCP related calls should stay as-is.

We'd add additional calls to better identify what's being done:

   Ns_SockListenTcp   (new, should be called by Ns_SocketListen)
   Ns_SockListenUdp   (exists)
   Ns_SockListenRaw   (exists)
   Ns_SockListenUnix  (exists)

Then:

   Ns_SockBindTcp   (new, should be called by Ns_SocketBind)
   Ns_SockBindUdp   (exists)
   Ns_SockBindRaw   (new)
   Ns_SockBindUnix  (new)

In binder.c there are some calls which are only used withing the
file hence we'd need to adjust the call interface to illustrate
this:

   Ns_SockRaw  - > SockRaw

Also, the Ns_SockListenUnix is a combination of create + bind
but unlike other pendants, does not honour the preboundUnix sockets.
We should split this. Make the Ns_SockListenUnix actually
honour prebound sockets (which it does not do now) and use
internally the Ns_SockBindUnix to bind so it'd be on-pair with
the TCP.

All in all, this will not change the functionality but will
*definitely* improve understanding and code maintenance.
There are other places in sock.c which seem pretty odd like

   Ns_SockBind calls Ns_BindSock

what is the reason of having those two (backward-compat?)

I will like to cleanup this now. Are there any voices against
or any other ideas?

Cheers
Zoran

[naviserver-devel] Move nscgi to modules?

[Zoran V. <zv...@ar...>]

Hi!

In the process of wholesale cleanup, we might consider
moving the nscgi module out of the main server and
into the modules section.

The nslog/nsperm/nscp are pretty important to the server
operation and I'd leave them where they are. Just the
nscgi thing: we never needed it.

Not something of the terrible importance. Just a thought.

Cheers
Zoran

[naviserver-devel] Dont forget Windows

[Zoran V. <zv...@ar...>]

Hi !

We are now about to get the Windows version compiled.
When you do some changes/improvements do not forget
that the Windows platform should be considered.

There is a nswin32.c file which contains Windows specifics.

Cheers
Zoran

Re: [naviserver-devel] compilation ?

[Zoran V. <zv...@ar...>]

Am 10.06.2005 um 09:09 schrieb Stephen Deasey:
>>
>> dsprintf.c: In function `Ns_DStringVPrintf':
>> dsprintf.c:294: warning: use of `long double' type; its size may
>> change in a future release
>> dsprintf.c:294: warning: (Long double usage is reported only once for
>> each file.
>> dsprintf.c:294: warning: To disable this warning, use -Wno-long- 
>> double.)
>>
>> What should we do about that?
>>
>
>
> Has this always been a warning on Darwin?  I don't see any LONGDBL
> mentioned in the Tcl source...

Aha! No. It actually popped out since I got 10.4 installed.
I will see what is going on here.

>
>
>
>> return.c: In function `Ns_ConnConstructHeaders':
>> return.c:262: warning: suggest parentheses around && within ||
>> return.c: At top level:
>>
>> This is here for the long time. I think it is the time to
>> get rid of it. I looked there but am not sure.
>>
>
>
> I cleaned up some warnings a while ago but left this one as there's a
> better solution in AOLserver HEAD, but it requires a few extra new
> functions which I didn't want to add just for a clean-up.
>

OK.

>
> As far as I remember, adding some of the extra checks such as for
> printf format strings turns up some genuine bugs.  Maybe we should go
> for those now too?

Certainly.

>
> If this is a bug you should also file it with the Tcl project as this
> is the tcl.m4 used by all Tcl packages.
>

I know. But this is not a bug per-se. It is somehow related to the
linking we're doing. Again, I will look into this.

Zoran

Re: [naviserver-devel] compilation ?

[Stephen D. <sd...@gm...>]

On 6/10/05, Zoran Vasiljevic <zv...@ar...> wrote:
>=20
> Am 10.06.2005 um 08:21 schrieb Stephen Deasey:
>=20
> > On 6/9/05, Vlad Seryakov <vl...@cr...> wrote:
> >
> >> HAVE_TM_GMTOFF is not defined in the config.h.in
> >> so it never gets to config.h
> >>
> >
> >
> > Ah, thanks.  I've added the right call in the configure script to make
> > this happen.
>=20
> Still some things left:
>=20
> dsprintf.c: In function `Ns_DStringVPrintf':
> dsprintf.c:294: warning: use of `long double' type; its size may
> change in a future release
> dsprintf.c:294: warning: (Long double usage is reported only once for
> each file.
> dsprintf.c:294: warning: To disable this warning, use -Wno-long-double.)
>=20
> What should we do about that?


Has this always been a warning on Darwin?  I don't see any LONGDBL
mentioned in the Tcl source...


> return.c: In function `Ns_ConnConstructHeaders':
> return.c:262: warning: suggest parentheses around && within ||
> return.c: At top level:
>=20
> This is here for the long time. I think it is the time to
> get rid of it. I looked there but am not sure.


I cleaned up some warnings a while ago but left this one as there's a
better solution in AOLserver HEAD, but it requires a few extra new
functions which I didn't want to add just for a clean-up.


> tclxkeylist.c: In function `Tcl_GetKeyedListKeys':
> tclxkeylist.c:285: warning: passing arg 2 of `Tcl_GetStringFromObj'
> from incompatible pointer type
> tclxkeylist.c:293: warning: passing arg 2 of `Tcl_GetStringFromObj'
> from incompatible pointer type
> tclxkeylist.c: In function `Tcl_GetKeyedListField':
> tclxkeylist.c:353: warning: passing arg 2 of `Tcl_GetStringFromObj'
> from incompatible pointer type
> tclxkeylist.c: In function `Tcl_SetKeyedListField':
> tclxkeylist.c:407: warning: passing arg 2 of `Tcl_GetStringFromObj'
> from incompatible pointer type
> tclxkeylist.c: In function `Tcl_DeleteKeyedListField':
> tclxkeylist.c:453: warning: passing arg 2 of `Tcl_GetStringFromObj'
> from incompatible pointer type
> tclxkeylist.c: At top level:
>=20
> This should be easy. I will take care of that.
>=20
> Stepen, you mentioned usage of some macro to get rid of the
>=20
> nsdb.c:36: warning: `RCSID' defined but not used
>=20
> type of warnings. I suppose you'd have to go wholesale change all
> files, right?


Yes, that's the RFE I posted recently.  I wasn't going to add that
until after this release, but we've started churning the code again so
might as well add this now I suppose.

As far as I remember, adding some of the extra checks such as for
printf format strings turns up some genuine bugs.  Maybe we should go
for those now too?


> Anyways, it compiles now on Darwin. Not very clean though:
>=20
> ld: warning prebinding disabled because (__TEXT segment (address =3D
> 0x0 size =3D 0x63000) of libnsd.dylib overlaps with __TEXT segment
> (address =3D 0x0 size =3D 0x6000) of /usr/local/ns/lib/libnsthread.dylib
> ld: warning prebinding disabled because (__TEXT segment (address =3D
> 0x0 size =3D 0x63000) of libnsd.dylib overlaps with __DATA segment
> (address =3D 0x6000 size =3D 0x1000) of /usr/local/ns/lib/libnsthread.dyl=
ib
> ld: warning prebinding disabled because (__TEXT segment (address =3D
> 0x0 size =3D 0x63000) of libnsd.dylib overlaps with __LINKEDIT segment
> (address =3D 0x7000 size =3D 0xd000) of /usr/local/ns/lib/libnsthread.dyl=
ib
>=20
> but I will have to see why. The tcl.m4 has the "-prebind" option to
> linker
> and I'd have to check if this is really needed.


If this is a bug you should also file it with the Tcl project as this
is the tcl.m4 used by all Tcl packages.

Re: [naviserver-devel] Re: [naviserver-commits] naviserver/nsd tclobjv.c,1.7,1.8 tclresp.c,1.4,1.5

[Stephen D. <sd...@gm...>]

I think it's fine to also alow ns_return to handle binary data, I'm
just wondering if it should be with the extra command ns_returnbinary?

It looks like you can simple check the type of the Tcl object passed
to ns_return for "bytearray".  That's the only case it makes sense to
write the bytes directly.

The advantage over ns_returnbinary is that in many cases the uses
doesn't have to know what's going on.  e.g. a command which creates a
png graph would be returned as a byte array, and if passed to
ns_return everything should just work.



On 6/9/05, Vlad Seryakov <vl...@cr...> wrote:
> ns_respond now supports binary so ns_returnbinary is redundant, but i
> think Tcl_GetByteArray works with string and byte array, just
> Tcl_GetByteArray does not do eny encoding/converting to/From utf.
>=20
> Stephen Deasey wrote:
> > Before you cvs commit, you must make test.  Two tests are broken...
> > We're strugeling for tests, but tclresp.c is one file that does have a
> > reasonably complete set.  Can you add some for the new commands?
> > Also, the cut 'n paste comment for Ns_ObjvByteArray is no longer
> > correct.
> >
> > I was wondering, is ns_returnbinary necessary?  What if ns_return was
> > modified to check the type of it's data arg, and if it's byterray,
> > send using Ns_ConnReturnData.  Would this work?

Re: [naviserver-devel] Re: [naviserver-commits] naviserver/nsd tclobjv.c,1.7,1.8 tclresp.c,1.4,1.5

[Stephen D. <sd...@gm...>]

On 6/9/05, Vlad Seryakov <vl...@cr...> wrote:
> I have no failed tests
>=20
> Tests running in interp:  /home/vlad/src/naviserver/nsd/nsd
> Tests located in:  /home/vlad/src/naviserver/tests
> Tests running in:  /home/vlad/src/naviserver/tests
> Temporary files stored in /home/vlad/src/naviserver/tests
> Test files sourced into current interpreter
> Running tests that match:  *
> Skipping test files that match:  l.*.test
> Only running test files that match:  *.test
> Tests began at Thu Jun 09 08:30:29 PM EDT 2005
> http.test
> ns_addrbyhost.test
> ns_adp_compress.test
> [09/Jun/2005:20:30:29][5516.3073625008][-conn:test::0] Notice: encoding:
> loaded: iso8859-1
> ns_conn_host.test
> ns_hashpath.test
> ns_hostbyaddr.test
> ns_hrefs.test
> ns_nsv.test
> ns_pagepath.test
> ns_parseargs.test
> ns_serverpath.test
> ns_urlencode.test
> tclresp.test
>=20
> Tests ended at Thu Jun 09 08:30:30 PM EDT 2005
> all.tcl:        Total   193     Passed  193     Skipped 0       Failed  0
> Sourced 13 Test Files.


The test server is linking against some other libnsd.so you have
installed on the machine, so you're not testing what you think you're
testing...

Unfortunately LD_LIBRARY_PATH isn't enough to fix this as the lib
locations are embeded into the binaries with rpath.  I'm not sure what
the best way to fix this is yet, but as a temporary measure you can
configure your test server with --prefix=3D/tmp/nsdtest, i.e. something
other than the installed nsd.

Re: [naviserver-devel] compilation ?

[Zoran V. <zv...@ar...>]

Am 10.06.2005 um 08:21 schrieb Stephen Deasey:

> On 6/9/05, Vlad Seryakov <vl...@cr...> wrote:
>
>> HAVE_TM_GMTOFF is not defined in the config.h.in
>> so it never gets to config.h
>>
>
>
> Ah, thanks.  I've added the right call in the configure script to make
> this happen.

Still some things left:

dsprintf.c: In function `Ns_DStringVPrintf':
dsprintf.c:294: warning: use of `long double' type; its size may  
change in a future release
dsprintf.c:294: warning: (Long double usage is reported only once for  
each file.
dsprintf.c:294: warning: To disable this warning, use -Wno-long-double.)

What should we do about that?


return.c: In function `Ns_ConnConstructHeaders':
return.c:262: warning: suggest parentheses around && within ||
return.c: At top level:

This is here for the long time. I think it is the time to
get rid of it. I looked there but am not sure.


tclxkeylist.c: In function `Tcl_GetKeyedListKeys':
tclxkeylist.c:285: warning: passing arg 2 of `Tcl_GetStringFromObj'  
from incompatible pointer type
tclxkeylist.c:293: warning: passing arg 2 of `Tcl_GetStringFromObj'  
from incompatible pointer type
tclxkeylist.c: In function `Tcl_GetKeyedListField':
tclxkeylist.c:353: warning: passing arg 2 of `Tcl_GetStringFromObj'  
from incompatible pointer type
tclxkeylist.c: In function `Tcl_SetKeyedListField':
tclxkeylist.c:407: warning: passing arg 2 of `Tcl_GetStringFromObj'  
from incompatible pointer type
tclxkeylist.c: In function `Tcl_DeleteKeyedListField':
tclxkeylist.c:453: warning: passing arg 2 of `Tcl_GetStringFromObj'  
from incompatible pointer type
tclxkeylist.c: At top level:

This should be easy. I will take care of that.

Stepen, you mentioned usage of some macro to get rid of the

nsdb.c:36: warning: `RCSID' defined but not used

type of warnings. I suppose you'd have to go wholesale change all  
files, right?

Anyways, it compiles now on Darwin. Not very clean though:

ld: warning prebinding disabled because (__TEXT segment (address =  
0x0 size = 0x63000) of libnsd.dylib overlaps with __TEXT segment  
(address = 0x0 size = 0x6000) of /usr/local/ns/lib/libnsthread.dylib
ld: warning prebinding disabled because (__TEXT segment (address =  
0x0 size = 0x63000) of libnsd.dylib overlaps with __DATA segment  
(address = 0x6000 size = 0x1000) of /usr/local/ns/lib/libnsthread.dylib
ld: warning prebinding disabled because (__TEXT segment (address =  
0x0 size = 0x63000) of libnsd.dylib overlaps with __LINKEDIT segment  
(address = 0x7000 size = 0xd000) of /usr/local/ns/lib/libnsthread.dylib

but I will have to see why. The tcl.m4 has the "-prebind" option to  
linker
and I'd have to check if this is really needed.

Zoran

Re: [naviserver-devel] compilation ?

[Stephen D. <sd...@gm...>]

On 6/9/05, Vlad Seryakov <vl...@cr...> wrote:
> HAVE_TM_GMTOFF is not defined in the config.h.in
> so it never gets to config.h


Ah, thanks.  I've added the right call in the configure script to make
this happen.


> The problem i usually have with config.h if i include different packages
> and they all use config.h which is common with GNU/configure based
> packages they interfere with each other and config.h should be exported
> and distributed with public header files. It was designed for internal
> compilation only(this is my guess), now even public API cannot be
> compiled without it.


When compiling a naviserver module the Tcl defs will be present either
on the command line because they're embeded in Makefile.global or in
the config.h header, so I don't think it makes a difference from this
point of view.

Re: [naviserver-devel] Re: [naviserver-commits] naviserver/nsd tclobjv.c,1.7,1.8 tclresp.c,1.4,1.5

[Vlad S. <vl...@cr...>]

ns_respond now supports binary so ns_returnbinary is redundant, but i 
think Tcl_GetByteArray works with string and byte array, just 
Tcl_GetByteArray does not do eny encoding/converting to/From utf.

Stephen Deasey wrote:
> Before you cvs commit, you must make test.  Two tests are broken... 
> We're strugeling for tests, but tclresp.c is one file that does have a
> reasonably complete set.  Can you add some for the new commands? 
> Also, the cut 'n paste comment for Ns_ObjvByteArray is no longer
> correct.
> 
> I was wondering, is ns_returnbinary necessary?  What if ns_return was
> modified to check the type of it's data arg, and if it's byterray,
> send using Ns_ConnReturnData.  Would this work?
> 
> 
> 
> 
> On 6/8/05, Vlad Seryakov <ser...@us...> wrote:
> 
>>Update of /cvsroot/naviserver/naviserver/nsd
>>In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv15813/nsd
>>
>>Modified Files:
>>        tclobjv.c tclresp.c
>>Log Message:
>>Added -binary flag to ns_respond to return binary data without encoding conversion
>>
>>
>>Index: tclobjv.c
>>===================================================================
>>RCS file: /cvsroot/naviserver/naviserver/nsd/tclobjv.c,v
>>retrieving revision 1.7
>>retrieving revision 1.8
>>diff -C2 -d -r1.7 -r1.8
>>*** tclobjv.c   15 May 2005 07:47:21 -0000      1.7
>>--- tclobjv.c   8 Jun 2005 20:27:12 -0000       1.8
>>***************
>>*** 310,313 ****
>>--- 310,352 ----
>>   *----------------------------------------------------------------------
>>   *
>>+  * Ns_ObjvByteArray --
>>+  *
>>+  *      Consume exactly one argument, returning a pointer to it's
>>+  *      cstring into *spec->dest.
>>+  *
>>+  *      If spec->arg is != NULL it is assumed to be a pointer to an
>>+  *      int and the returned string length will be left in it.
>>+  *
>>+  * Results:
>>+  *      TCL_OK or TCL_ERROR.
>>+  *
>>+  * Side effects:
>>+  *        None.
>>+  *
>>+  *----------------------------------------------------------------------
>>+  */
>>+
>>+ int
>>+ Ns_ObjvByteArray(Ns_ObjvSpec *spec, Tcl_Interp *interp, int *objcPtr,
>>+               Tcl_Obj *CONST objv[])
>>+ {
>>+     unsigned char **dest = spec->dest;
>>+
>>+     if (*objcPtr > 0) {
>>+         if (spec->arg == NULL) {
>>+             *dest = Tcl_GetByteArrayFromObj(objv[0],0);
>>+         } else {
>>+             *dest = Tcl_GetByteArrayFromObj(objv[0], (int *) spec->arg);
>>+         }
>>+         *objcPtr -= 1;
>>+         return TCL_OK;
>>+     }
>>+     return TCL_ERROR;
>>+ }
>>+
>>+
>>+ /*
>>+  *----------------------------------------------------------------------
>>+  *
>>   * Ns_ObjvObj --
>>   *
>>
>>Index: tclresp.c
>>===================================================================
>>RCS file: /cvsroot/naviserver/naviserver/nsd/tclresp.c,v
>>retrieving revision 1.4
>>retrieving revision 1.5
>>diff -C2 -d -r1.4 -r1.5
>>*** tclresp.c   8 Jun 2005 20:13:12 -0000       1.4
>>--- tclresp.c   8 Jun 2005 20:27:12 -0000       1.5
>>***************
>>*** 252,256 ****
>>      Ns_Conn     *conn;
>>      int          status = 200, length = -1;
>>!     char        *type = "*/*", *setid = NULL;
>>      char        *string = NULL, *filename = NULL, *chanid = NULL;
>>      Ns_Set      *set = NULL;
>>--- 252,256 ----
>>      Ns_Conn     *conn;
>>      int          status = 200, length = -1;
>>!     char        *type = "*/*", *setid = NULL, *binary = NULL;
>>      char        *string = NULL, *filename = NULL, *chanid = NULL;
>>      Ns_Set      *set = NULL;
>>***************
>>*** 259,269 ****
>>
>>      Ns_ObjvSpec opts[] = {
>>!         {"-status",   Ns_ObjvInt,    &status,   NULL},
>>!         {"-type",     Ns_ObjvString, &type,     NULL},
>>!         {"-length",   Ns_ObjvInt,    &length,   NULL},
>>!         {"-headers",  Ns_ObjvString, &setid,    NULL},
>>!         {"-string",   Ns_ObjvString, &string,   NULL},
>>!         {"-file",     Ns_ObjvString, &filename, NULL},
>>!         {"-fileid",   Ns_ObjvString, &chanid,   NULL},
>>          {NULL, NULL, NULL, NULL}
>>      };
>>--- 259,270 ----
>>
>>      Ns_ObjvSpec opts[] = {
>>!         {"-status",   Ns_ObjvInt,       &status,   NULL},
>>!         {"-type",     Ns_ObjvString,    &type,     NULL},
>>!         {"-length",   Ns_ObjvInt,       &length,   NULL},
>>!         {"-headers",  Ns_ObjvString,    &setid,    NULL},
>>!         {"-string",   Ns_ObjvString,    &string,   NULL},
>>!         {"-file",     Ns_ObjvString,    &filename, NULL},
>>!         {"-fileid",   Ns_ObjvString,    &chanid,   NULL},
>>!         {"-binary",   Ns_ObjvByteArray, &binary,   &length},
>>          {NULL, NULL, NULL, NULL}
>>      };
>>***************
>>*** 277,282 ****
>>          return TCL_ERROR;
>>      }
>>!     if ((string != NULL) + (filename != NULL) + (chanid != NULL) != 1) {
>>!         Tcl_SetResult(interp, "must specify only one of -string, -file "
>>                        "or -fileid", TCL_STATIC);
>>          return TCL_ERROR;
>>--- 278,283 ----
>>          return TCL_ERROR;
>>      }
>>!     if ((binary != NULL) + (string != NULL) + (filename != NULL) + (chanid != NULL) != 1) {
>>!         Tcl_SetResult(interp, "must specify only one of -string, -file, -binary "
>>                        "or -fileid", TCL_STATIC);
>>          return TCL_ERROR;
>>***************
>>*** 313,316 ****
>>--- 314,324 ----
>>          retval = Ns_ConnReturnFile(conn, status, type, filename);
>>
>>+     } else if (binary != NULL) {
>>+         /*
>>+          * We'll be returning a binary data
>>+          */
>>+
>>+         retval = Ns_ConnReturnData(conn, status, binary, length, type);
>>+
>>      } else {
>>          /*
> 
> 
> 
> -------------------------------------------------------
> This SF.Net email is sponsored by: NEC IT Guy Games.  How far can you shotput
> a projector? How fast can you ride your desk chair down the office luge track?
> If you want to score the big prize, get to know the little guy.  
> Play to win an NEC 61" plasma display: http://www.necitguy.com/?r 
> _______________________________________________
> naviserver-devel mailing list
> nav...@li...
> https://lists.sourceforge.net/lists/listinfo/naviserver-devel

-- 
Vlad Seryakov
571 262-8608 office
vl...@cr...
http://www.crystalballinc.com/vlad/

Re: [naviserver-devel] Re: [naviserver-commits] naviserver/nsd tclobjv.c,1.7,1.8 tclresp.c,1.4,1.5

[Vlad S. <vl...@cr...>]

I have no failed tests

Tests running in interp:  /home/vlad/src/naviserver/nsd/nsd
Tests located in:  /home/vlad/src/naviserver/tests
Tests running in:  /home/vlad/src/naviserver/tests
Temporary files stored in /home/vlad/src/naviserver/tests
Test files sourced into current interpreter
Running tests that match:  *
Skipping test files that match:  l.*.test
Only running test files that match:  *.test
Tests began at Thu Jun 09 08:30:29 PM EDT 2005
http.test
ns_addrbyhost.test
ns_adp_compress.test
[09/Jun/2005:20:30:29][5516.3073625008][-conn:test::0] Notice: encoding: 
loaded: iso8859-1
ns_conn_host.test
ns_hashpath.test
ns_hostbyaddr.test
ns_hrefs.test
ns_nsv.test
ns_pagepath.test
ns_parseargs.test
ns_serverpath.test
ns_urlencode.test
tclresp.test

Tests ended at Thu Jun 09 08:30:30 PM EDT 2005
all.tcl:        Total   193     Passed  193     Skipped 0       Failed  0
Sourced 13 Test Files.


Stephen Deasey wrote:
> Before you cvs commit, you must make test.  Two tests are broken... 
> We're strugeling for tests, but tclresp.c is one file that does have a
> reasonably complete set.  Can you add some for the new commands? 
> Also, the cut 'n paste comment for Ns_ObjvByteArray is no longer
> correct.
> 
> I was wondering, is ns_returnbinary necessary?  What if ns_return was
> modified to check the type of it's data arg, and if it's byterray,
> send using Ns_ConnReturnData.  Would this work?
> 
> 
> 
> 
> On 6/8/05, Vlad Seryakov <ser...@us...> wrote:
> 
>>Update of /cvsroot/naviserver/naviserver/nsd
>>In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv15813/nsd
>>
>>Modified Files:
>>        tclobjv.c tclresp.c
>>Log Message:
>>Added -binary flag to ns_respond to return binary data without encoding conversion
>>
>>
>>Index: tclobjv.c
>>===================================================================
>>RCS file: /cvsroot/naviserver/naviserver/nsd/tclobjv.c,v
>>retrieving revision 1.7
>>retrieving revision 1.8
>>diff -C2 -d -r1.7 -r1.8
>>*** tclobjv.c   15 May 2005 07:47:21 -0000      1.7
>>--- tclobjv.c   8 Jun 2005 20:27:12 -0000       1.8
>>***************
>>*** 310,313 ****
>>--- 310,352 ----
>>   *----------------------------------------------------------------------
>>   *
>>+  * Ns_ObjvByteArray --
>>+  *
>>+  *      Consume exactly one argument, returning a pointer to it's
>>+  *      cstring into *spec->dest.
>>+  *
>>+  *      If spec->arg is != NULL it is assumed to be a pointer to an
>>+  *      int and the returned string length will be left in it.
>>+  *
>>+  * Results:
>>+  *      TCL_OK or TCL_ERROR.
>>+  *
>>+  * Side effects:
>>+  *        None.
>>+  *
>>+  *----------------------------------------------------------------------
>>+  */
>>+
>>+ int
>>+ Ns_ObjvByteArray(Ns_ObjvSpec *spec, Tcl_Interp *interp, int *objcPtr,
>>+               Tcl_Obj *CONST objv[])
>>+ {
>>+     unsigned char **dest = spec->dest;
>>+
>>+     if (*objcPtr > 0) {
>>+         if (spec->arg == NULL) {
>>+             *dest = Tcl_GetByteArrayFromObj(objv[0],0);
>>+         } else {
>>+             *dest = Tcl_GetByteArrayFromObj(objv[0], (int *) spec->arg);
>>+         }
>>+         *objcPtr -= 1;
>>+         return TCL_OK;
>>+     }
>>+     return TCL_ERROR;
>>+ }
>>+
>>+
>>+ /*
>>+  *----------------------------------------------------------------------
>>+  *
>>   * Ns_ObjvObj --
>>   *
>>
>>Index: tclresp.c
>>===================================================================
>>RCS file: /cvsroot/naviserver/naviserver/nsd/tclresp.c,v
>>retrieving revision 1.4
>>retrieving revision 1.5
>>diff -C2 -d -r1.4 -r1.5
>>*** tclresp.c   8 Jun 2005 20:13:12 -0000       1.4
>>--- tclresp.c   8 Jun 2005 20:27:12 -0000       1.5
>>***************
>>*** 252,256 ****
>>      Ns_Conn     *conn;
>>      int          status = 200, length = -1;
>>!     char        *type = "*/*", *setid = NULL;
>>      char        *string = NULL, *filename = NULL, *chanid = NULL;
>>      Ns_Set      *set = NULL;
>>--- 252,256 ----
>>      Ns_Conn     *conn;
>>      int          status = 200, length = -1;
>>!     char        *type = "*/*", *setid = NULL, *binary = NULL;
>>      char        *string = NULL, *filename = NULL, *chanid = NULL;
>>      Ns_Set      *set = NULL;
>>***************
>>*** 259,269 ****
>>
>>      Ns_ObjvSpec opts[] = {
>>!         {"-status",   Ns_ObjvInt,    &status,   NULL},
>>!         {"-type",     Ns_ObjvString, &type,     NULL},
>>!         {"-length",   Ns_ObjvInt,    &length,   NULL},
>>!         {"-headers",  Ns_ObjvString, &setid,    NULL},
>>!         {"-string",   Ns_ObjvString, &string,   NULL},
>>!         {"-file",     Ns_ObjvString, &filename, NULL},
>>!         {"-fileid",   Ns_ObjvString, &chanid,   NULL},
>>          {NULL, NULL, NULL, NULL}
>>      };
>>--- 259,270 ----
>>
>>      Ns_ObjvSpec opts[] = {
>>!         {"-status",   Ns_ObjvInt,       &status,   NULL},
>>!         {"-type",     Ns_ObjvString,    &type,     NULL},
>>!         {"-length",   Ns_ObjvInt,       &length,   NULL},
>>!         {"-headers",  Ns_ObjvString,    &setid,    NULL},
>>!         {"-string",   Ns_ObjvString,    &string,   NULL},
>>!         {"-file",     Ns_ObjvString,    &filename, NULL},
>>!         {"-fileid",   Ns_ObjvString,    &chanid,   NULL},
>>!         {"-binary",   Ns_ObjvByteArray, &binary,   &length},
>>          {NULL, NULL, NULL, NULL}
>>      };
>>***************
>>*** 277,282 ****
>>          return TCL_ERROR;
>>      }
>>!     if ((string != NULL) + (filename != NULL) + (chanid != NULL) != 1) {
>>!         Tcl_SetResult(interp, "must specify only one of -string, -file "
>>                        "or -fileid", TCL_STATIC);
>>          return TCL_ERROR;
>>--- 278,283 ----
>>          return TCL_ERROR;
>>      }
>>!     if ((binary != NULL) + (string != NULL) + (filename != NULL) + (chanid != NULL) != 1) {
>>!         Tcl_SetResult(interp, "must specify only one of -string, -file, -binary "
>>                        "or -fileid", TCL_STATIC);
>>          return TCL_ERROR;
>>***************
>>*** 313,316 ****
>>--- 314,324 ----
>>          retval = Ns_ConnReturnFile(conn, status, type, filename);
>>
>>+     } else if (binary != NULL) {
>>+         /*
>>+          * We'll be returning a binary data
>>+          */
>>+
>>+         retval = Ns_ConnReturnData(conn, status, binary, length, type);
>>+
>>      } else {
>>          /*
> 
> 
> 
> -------------------------------------------------------
> This SF.Net email is sponsored by: NEC IT Guy Games.  How far can you shotput
> a projector? How fast can you ride your desk chair down the office luge track?
> If you want to score the big prize, get to know the little guy.  
> Play to win an NEC 61" plasma display: http://www.necitguy.com/?r 
> _______________________________________________
> naviserver-devel mailing list
> nav...@li...
> https://lists.sourceforge.net/lists/listinfo/naviserver-devel

-- 
Vlad Seryakov
571 262-8608 office
vl...@cr...
http://www.crystalballinc.com/vlad/

Re: [naviserver-devel] Re: [naviserver-commits] modules/nsfreetds nsfreetds.c,1.5,1.6

[Vlad S. <vl...@cr...>]

yes, my bad, my modules subdir under naviserver and commit took it with 
main comit.

Stephen Deasey wrote:
> Before you cvs commit, you must cvs diff.  This commit message does
> not go with this change.  It doesn't even go with this module.
> 
> 
> 
> On 6/9/05, Vlad Seryakov <ser...@us...> wrote:
> 
>>Update of /cvsroot/naviserver/modules/nsfreetds
>>In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv23043/modules/nsfreetds
>>
>>Modified Files:
>>        nsfreetds.c
>>Log Message:
>>added missed TCL_DEFS in the global makefile
>>
>>
>>Index: nsfreetds.c
>>===================================================================
>>RCS file: /cvsroot/naviserver/modules/nsfreetds/nsfreetds.c,v
>>retrieving revision 1.5
>>retrieving revision 1.6
>>diff -C2 -d -r1.5 -r1.6
>>*** nsfreetds.c 8 Jun 2005 20:03:44 -0000       1.5
>>--- nsfreetds.c 9 Jun 2005 21:07:37 -0000       1.6
>>***************
>>*** 250,253 ****
>>--- 250,254 ----
>>      if(rc != TDS_SUCCEED && rc != TDS_NO_MORE_RESULTS) {
>>         Ns_Log(Error,"Db_GetRow(%s): tds_process_row_tokens: %d",handle->datasource,rc);
>>+        Db_Cancel(handle);
>>         return NS_ERROR;
>>      }
>>***************
>>*** 291,294 ****
>>--- 292,296 ----
>>      if(IS_TDSDEAD(GET_TDS(handle))) {
>>         Ns_Log(Error, "Db_Cancel(%s): dead connection detected.", handle->datasource);
>>+        tds_free_all_results(GET_TDS(handle));
>>         handle->statement = NULL;
>>         handle->fetchingRows = 0;
> 
> 
> 
> -------------------------------------------------------
> This SF.Net email is sponsored by: NEC IT Guy Games.  How far can you shotput
> a projector? How fast can you ride your desk chair down the office luge track?
> If you want to score the big prize, get to know the little guy.  
> Play to win an NEC 61" plasma display: http://www.necitguy.com/?r 
> _______________________________________________
> naviserver-devel mailing list
> nav...@li...
> https://lists.sourceforge.net/lists/listinfo/naviserver-devel

-- 
Vlad Seryakov
571 262-8608 office
vl...@cr...
http://www.crystalballinc.com/vlad/

Re: [naviserver-devel] compilation ?

[Vlad S. <vl...@cr...>]

HAVE_TM_GMTOFF is not defined in the config.h.in
so it never gets to config.h

The problem i usually have with config.h if i include different packages
and they all use config.h which is common with GNU/configure based 
packages they interfere with each other and config.h should be exported 
and distributed with public header files. It was designed for internal 
compilation only(this is my guess), now even public API cannot be 
compiled without it.

I think old style having TCL_DEFs in the Makefile was more cleaner way.

Stephen Deasey wrote:
> On 6/9/05, Zoran Vasiljevic <zv...@ar...> wrote:
> 
>>Am 09.06.2005 um 23:05 schrieb Vlad Seryakov:
>>
>>
>>>I just fixed that in the CVS
>>
>>Hmmm... now it does compile but I still do not understand one thing:
>>include/config.h file overlapps with TCL_DEFS in various places.
>>Is this willingly done so or is this just a coincidence?
>>
>>Also, do we need TCL_DEFS when using the config.h?
>>Stephen has done some work on that lately as I see from
>>the ChangeLog. Stephen, can you mabe comment on this?
> 
> 
> 
> Yes, config.h is the new TCL_DEFS -- adding TCL_DEFS back into
> Makefile.global.in is not the right fix.
> 
> Zoran, is HAVE_TM_GMTOFF defined in config.h after you run configure? 
> The check in tcl.m4 which we now ship looks identical to the code in
> the Tcl tarball.
> 
> 
> -------------------------------------------------------
> This SF.Net email is sponsored by: NEC IT Guy Games.  How far can you shotput
> a projector? How fast can you ride your desk chair down the office luge track?
> If you want to score the big prize, get to know the little guy.  
> Play to win an NEC 61" plasma display: http://www.necitguy.com/?r 
> _______________________________________________
> naviserver-devel mailing list
> nav...@li...
> https://lists.sourceforge.net/lists/listinfo/naviserver-devel

-- 
Vlad Seryakov
571 262-8608 office
vl...@cr...
http://www.crystalballinc.com/vlad/

[naviserver-devel] Re: [naviserver-commits] naviserver/nsd tclobjv.c,1.7,1.8 tclresp.c,1.4,1.5

[Stephen D. <sd...@gm...>]

Before you cvs commit, you must make test.  Two tests are broken...=20
We're strugeling for tests, but tclresp.c is one file that does have a
reasonably complete set.  Can you add some for the new commands?=20
Also, the cut 'n paste comment for Ns_ObjvByteArray is no longer
correct.

I was wondering, is ns_returnbinary necessary?  What if ns_return was
modified to check the type of it's data arg, and if it's byterray,
send using Ns_ConnReturnData.  Would this work?




On 6/8/05, Vlad Seryakov <ser...@us...> wrote:
> Update of /cvsroot/naviserver/naviserver/nsd
> In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv15813/nsd
>=20
> Modified Files:
>         tclobjv.c tclresp.c
> Log Message:
> Added -binary flag to ns_respond to return binary data without encoding c=
onversion
>=20
>=20
> Index: tclobjv.c
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> RCS file: /cvsroot/naviserver/naviserver/nsd/tclobjv.c,v
> retrieving revision 1.7
> retrieving revision 1.8
> diff -C2 -d -r1.7 -r1.8
> *** tclobjv.c   15 May 2005 07:47:21 -0000      1.7
> --- tclobjv.c   8 Jun 2005 20:27:12 -0000       1.8
> ***************
> *** 310,313 ****
> --- 310,352 ----
>    *---------------------------------------------------------------------=
-
>    *
> +  * Ns_ObjvByteArray --
> +  *
> +  *      Consume exactly one argument, returning a pointer to it's
> +  *      cstring into *spec->dest.
> +  *
> +  *      If spec->arg is !=3D NULL it is assumed to be a pointer to an
> +  *      int and the returned string length will be left in it.
> +  *
> +  * Results:
> +  *      TCL_OK or TCL_ERROR.
> +  *
> +  * Side effects:
> +  *        None.
> +  *
> +  *---------------------------------------------------------------------=
-
> +  */
> +
> + int
> + Ns_ObjvByteArray(Ns_ObjvSpec *spec, Tcl_Interp *interp, int *objcPtr,
> +               Tcl_Obj *CONST objv[])
> + {
> +     unsigned char **dest =3D spec->dest;
> +
> +     if (*objcPtr > 0) {
> +         if (spec->arg =3D=3D NULL) {
> +             *dest =3D Tcl_GetByteArrayFromObj(objv[0],0);
> +         } else {
> +             *dest =3D Tcl_GetByteArrayFromObj(objv[0], (int *) spec->ar=
g);
> +         }
> +         *objcPtr -=3D 1;
> +         return TCL_OK;
> +     }
> +     return TCL_ERROR;
> + }
> +
> +
> + /*
> +  *---------------------------------------------------------------------=
-
> +  *
>    * Ns_ObjvObj --
>    *
>=20
> Index: tclresp.c
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> RCS file: /cvsroot/naviserver/naviserver/nsd/tclresp.c,v
> retrieving revision 1.4
> retrieving revision 1.5
> diff -C2 -d -r1.4 -r1.5
> *** tclresp.c   8 Jun 2005 20:13:12 -0000       1.4
> --- tclresp.c   8 Jun 2005 20:27:12 -0000       1.5
> ***************
> *** 252,256 ****
>       Ns_Conn     *conn;
>       int          status =3D 200, length =3D -1;
> !     char        *type =3D "*/*", *setid =3D NULL;
>       char        *string =3D NULL, *filename =3D NULL, *chanid =3D NULL;
>       Ns_Set      *set =3D NULL;
> --- 252,256 ----
>       Ns_Conn     *conn;
>       int          status =3D 200, length =3D -1;
> !     char        *type =3D "*/*", *setid =3D NULL, *binary =3D NULL;
>       char        *string =3D NULL, *filename =3D NULL, *chanid =3D NULL;
>       Ns_Set      *set =3D NULL;
> ***************
> *** 259,269 ****
>=20
>       Ns_ObjvSpec opts[] =3D {
> !         {"-status",   Ns_ObjvInt,    &status,   NULL},
> !         {"-type",     Ns_ObjvString, &type,     NULL},
> !         {"-length",   Ns_ObjvInt,    &length,   NULL},
> !         {"-headers",  Ns_ObjvString, &setid,    NULL},
> !         {"-string",   Ns_ObjvString, &string,   NULL},
> !         {"-file",     Ns_ObjvString, &filename, NULL},
> !         {"-fileid",   Ns_ObjvString, &chanid,   NULL},
>           {NULL, NULL, NULL, NULL}
>       };
> --- 259,270 ----
>=20
>       Ns_ObjvSpec opts[] =3D {
> !         {"-status",   Ns_ObjvInt,       &status,   NULL},
> !         {"-type",     Ns_ObjvString,    &type,     NULL},
> !         {"-length",   Ns_ObjvInt,       &length,   NULL},
> !         {"-headers",  Ns_ObjvString,    &setid,    NULL},
> !         {"-string",   Ns_ObjvString,    &string,   NULL},
> !         {"-file",     Ns_ObjvString,    &filename, NULL},
> !         {"-fileid",   Ns_ObjvString,    &chanid,   NULL},
> !         {"-binary",   Ns_ObjvByteArray, &binary,   &length},
>           {NULL, NULL, NULL, NULL}
>       };
> ***************
> *** 277,282 ****
>           return TCL_ERROR;
>       }
> !     if ((string !=3D NULL) + (filename !=3D NULL) + (chanid !=3D NULL) =
!=3D 1) {
> !         Tcl_SetResult(interp, "must specify only one of -string, -file =
"
>                         "or -fileid", TCL_STATIC);
>           return TCL_ERROR;
> --- 278,283 ----
>           return TCL_ERROR;
>       }
> !     if ((binary !=3D NULL) + (string !=3D NULL) + (filename !=3D NULL) =
+ (chanid !=3D NULL) !=3D 1) {
> !         Tcl_SetResult(interp, "must specify only one of -string, -file,=
 -binary "
>                         "or -fileid", TCL_STATIC);
>           return TCL_ERROR;
> ***************
> *** 313,316 ****
> --- 314,324 ----
>           retval =3D Ns_ConnReturnFile(conn, status, type, filename);
>=20
> +     } else if (binary !=3D NULL) {
> +         /*
> +          * We'll be returning a binary data
> +          */
> +
> +         retval =3D Ns_ConnReturnData(conn, status, binary, length, type=
);
> +
>       } else {
>           /*

[naviserver-devel] Re: [naviserver-commits] modules/nsfreetds nsfreetds.c,1.5,1.6

[Stephen D. <sd...@gm...>]

Before you cvs commit, you must cvs diff.  This commit message does
not go with this change.  It doesn't even go with this module.



On 6/9/05, Vlad Seryakov <ser...@us...> wrote:
> Update of /cvsroot/naviserver/modules/nsfreetds
> In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv23043/modules/nsfre=
etds
>=20
> Modified Files:
>         nsfreetds.c
> Log Message:
> added missed TCL_DEFS in the global makefile
>=20
>=20
> Index: nsfreetds.c
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> RCS file: /cvsroot/naviserver/modules/nsfreetds/nsfreetds.c,v
> retrieving revision 1.5
> retrieving revision 1.6
> diff -C2 -d -r1.5 -r1.6
> *** nsfreetds.c 8 Jun 2005 20:03:44 -0000       1.5
> --- nsfreetds.c 9 Jun 2005 21:07:37 -0000       1.6
> ***************
> *** 250,253 ****
> --- 250,254 ----
>       if(rc !=3D TDS_SUCCEED && rc !=3D TDS_NO_MORE_RESULTS) {
>          Ns_Log(Error,"Db_GetRow(%s): tds_process_row_tokens: %d",handle-=
>datasource,rc);
> +        Db_Cancel(handle);
>          return NS_ERROR;
>       }
> ***************
> *** 291,294 ****
> --- 292,296 ----
>       if(IS_TDSDEAD(GET_TDS(handle))) {
>          Ns_Log(Error, "Db_Cancel(%s): dead connection detected.", handle=
->datasource);
> +        tds_free_all_results(GET_TDS(handle));
>          handle->statement =3D NULL;
>          handle->fetchingRows =3D 0;

Re: [naviserver-devel] compilation ?

[Stephen D. <sd...@gm...>]

On 6/9/05, Zoran Vasiljevic <zv...@ar...> wrote:
>=20
> Am 09.06.2005 um 23:05 schrieb Vlad Seryakov:
>=20
> > I just fixed that in the CVS
>
> Hmmm... now it does compile but I still do not understand one thing:
> include/config.h file overlapps with TCL_DEFS in various places.
> Is this willingly done so or is this just a coincidence?
>=20
> Also, do we need TCL_DEFS when using the config.h?
> Stephen has done some work on that lately as I see from
> the ChangeLog. Stephen, can you mabe comment on this?


Yes, config.h is the new TCL_DEFS -- adding TCL_DEFS back into
Makefile.global.in is not the right fix.

Zoran, is HAVE_TM_GMTOFF defined in config.h after you run configure?=20
The check in tcl.m4 which we now ship looks identical to the code in
the Tcl tarball.

[naviserver-devel] Impressed!

[Zoran V. <zv...@ar...>]

Hi!

I just noticed the modules section in CVS.
It grew quite a lot lately :-)
Who is to "blame" for that? Vlad?
I believe I will have to invest some days to check that all.
Great work!

Zoran

Re: [naviserver-devel] compilation ?

[Zoran V. <zv...@ar...>]

Am 09.06.2005 um 23:05 schrieb Vlad Seryakov:

> I just fixed that in the CVS

Hmmm... now it does compile but I still do not understand one thing:
include/config.h file overlapps with TCL_DEFS in various places.
Is this willingly done so or is this just a coincidence?

Also, do we need TCL_DEFS when using the config.h?
Stephen has done some work on that lately as I see from
the ChangeLog. Stephen, can you mabe comment on this?

Cheers
Zoran

Re: [naviserver-devel] compilation ?

[Zoran V. <zv...@ar...>]

Am 09.06.2005 um 22:49 schrieb Zoran Vasiljevic:

> Hi!
>
> I'm afraid the compilation is somehow broken:
>
> zoran:~/sf/naviserver/nsd zoran$ make
> gcc -pipe -g -Wall -Wno-implicit-int -fno-common  -I../include -I"/ 
> usr/local/include"  -DNO_CONST -DHAVE_CONFIG_H   -c -o log.o log.c
> log.c: In function `LogTime':
> log.c:762: error: wrong type argument to unary minus
> log.c: At top level:
> log.c:37: warning: `RCSID' defined but not used
> make: *** [log.o] Error 1


I see... the config.h is now used. But I'd need some help
to know how this all is used. Any hints for startup?

OTOH, the HAVE_TM_GMTOFF define is missing. W/o this the
Darwin compilation fails as seen from above.

Zoran