Re: [naviserver-devel] Release

[Stephen D. <sd...@gm...>]

The *.test file are in utf-8, and are sourced by Tcl, and I think Tcl
it's picking up the default encoding to use from the env. So no real
surprise there. You'd expect encoding.test:1.1, which is completely
defined within that file, to fail.

But why are the ADP tests failing? The ADP's should be read off disk
in the correct encoding (and they seem to be). Tracing through the
rest of it, the server seems to be spitting out the correct bytes (I
think).

So it's down to the test harness itself. It does this:

proc nstest_http {args} {
    ns_parseargs {
        {-encoding "utf-8"} ...
    } $args

    ...

	#
	# Force a specific encoding (utf-8 default).
	#

	fconfigure $rfd -encoding $encoding
	fconfigure $wfd -encoding $encoding


Which looks fair enough to me.

Why isn't this working?



On 8/3/07, Vlad Seryakov <vl...@cr...> wrote:
> I could have not correct environment, let me check with fresh install,
> it is happening everytime, we may put big fat warning in make tst to
> make sure it is running on fresh install :-)))
>
> Stephen Deasey wrote:
> > On 8/3/07, Vlad Seryakov <vl...@cr...> wrote:
> >> ... there are still errors in encoding tests.
> >>
> >> Stephen, i was quite busy lately and lost track, is it still broken or
> >> tests are just to up to date? The reason is, we cannot release with
> >> broken encoding support.
> >
> > Oh. I didn't know about this. Works for me.
> >
> > This fails though:
> >
> > LANG=en_US.iso-8859-1 make test TCLTESTARGS="-file encoding.test"
> >
> > (my default is UTF-8)
> >
> > I'll take a look...
> >