Re: [naviserver-devel] log format broken?

[Stephen D. <sd...@gm...>]

On 6/26/07, Zoran Vasiljevic <zv...@ar...> wrote:
> One access.log entry:
>
> 192.168.234.103 - - [26/Jun/2007:17:34:18 +0200] "GET /favicon.ico
> HTTP/1.1" 404 533"" "Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:
> 1.8.1.4) Gecko/20070515 Firefox/2.0.0.4"
>
> It seems to me that
>
>     "GET /favicon.ico HTTP/1.1" 404 533"" "Mozilla ...
>                                        ^
> there is a space lacking ----------- here


Looks like it...


diff -r c6262f976ecc nslog/nslog.c
--- a/nslog/nslog.c	Tue Jun 26 01:08:34 2007 +0100
+++ b/nslog/nslog.c	Tue Jun 26 16:51:55 2007 +0100
@@ -417,7 +417,7 @@ LogTrace(void *arg, Ns_Conn *conn)
      */

     if ((logPtr->flags & LOG_COMBINED)) {
-        Ns_DStringAppend(&ds, "\"");
+        Ns_DStringAppend(&ds, " \"");
         p = Ns_SetIGet(conn->headers, "referer");
         if (p) {
             Ns_DStringAppend(&ds, p);