Re: [naviserver-devel] Bug in upload stats

[Vlad S. <vl...@cr...>]

My bad :-(( Can you fix it, i cannot for some reason login into CVS over ssh

Stephen Deasey wrote:
> In nsd/driver.c:NsTclUploadStatsObjCmd
> 
>     while (drvPtr != NULL) {
>         Tcl_HashEntry *hPtr;
>         spPtr = &drvPtr->spooler;
>         Ns_MutexLock(&spPtr->lock);
>         hPtr = Tcl_FindHashEntry(&spPtr->table, Tcl_GetString(objv[1]));
>         if (hPtr != NULL) {
>             Sock *sockPtr = (Sock *)Tcl_GetHashValue(hPtr);
>             UploadStats *statsPtr = &sockPtr->upload;
>             sprintf(buf, "%lu %lu", statsPtr->length, statsPtr->size);
>             break;
>         }
>         Ns_MutexUnlock(&spPtr->lock);
>         drvPtr = drvPtr->nextPtr;
>     }
> 
> If the command is successful in finding the correct stats, the loop is
> exited with break.  In this case, the mutex is never unlocked, right?
> 
> No tests...  :-(
> 
> 
> -------------------------------------------------------------------------
> Using Tomcat but need to do more? Need to support web services, security?
> Get stuff done quickly with pre-integrated technology to make your job easier
> Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
> _______________________________________________
> naviserver-devel mailing list
> nav...@li...
> https://lists.sourceforge.net/lists/listinfo/naviserver-devel
> 

-- 
Vlad Seryakov
571 262-8608 office
vl...@cr...
http://www.crystalballinc.com/vlad/