From: Stephen D. <sd...@gm...> - 2006-05-04 16:12:28
|
On 5/3/06, Zoran Vasiljevic <zv...@ar...> wrote: > > On 03.05.2006, at 20:56, Stephen Deasey wrote: > > > > > Can you write a test that fails? > > This is a very good question.... I do not know. Well, give it a shot then. :-) The bug is fixed when the test stops failing. > I know the app breaks which worked with older + newer > cache code up to that version... I do not do anything > really weird there... just ns_cache_eval. > > What is the change you did really after? Looks like it's just making sure the default ttl from the cache is used (if specified) if a specific ttl isn't given. This is not the same as the timeout, which is the time one thread will wait for another thread to fill in a cache entry, should two or more try to update an entry at once. It's the later that gives the error message your getting, so I don't think the code you've quoted above is the problem. |