Re: [naviserver-devel] Test failures: while executing "close $wfd" invoked from within "nstest_http ..."

[Zoran V. <zv...@ar...>]

Am 10.03.2006 um 00:13 schrieb Stephen Deasey:

> Zoran!  Why do you hate my test suite?    :-)
>
>
> RCS file: /cvsroot/naviserver/naviserver/tcl/http.tcl,v
> date: 2006/03/09 11:25:55;  author: vasiljevic;  state: Exp;   
> lines: +356 -312
>
> ...The http.tcl and sendmail.tcl are rewritten to take advantage of
> automatic end-of-line handling of Tcl channels...
>

Since WHEN we are supporting "_ns_" as part of the API?

This is in testtinghttp.tcl:

         if {[string equal $http ""]} {
             set request "$method $url\r"
         } else {
             set request "$method $url HTTP/$http\r"
         }
         _ns_http_puts $timeout $wfd $request ; ######################
         for {set i 0} {$i < [ns_set size $hdrs]} {incr i} {


Yes, I have modified http.tcl/sendmail.tcl code given the fact
that Tcl will perfectly well handle the network-line-break
with on-board tools. But I did not expect anybody using internal
helper procedures from outside.

I guess the simple and easy fix to that is to:
   a. provide complete custom support for http conns in testtinghttp.tcl
   b. trash it entirely and use standard ns_httpget

I will opt for the a. for the moment and fix this in about 15 minutes.
Please: do not use non API calls in the future.

Cheers
Zoran