Re: [naviserver-devel] Upload Progress

[Vlad S. <vl...@cr...>]

Just in case for future encahncements, we may restrict spooling queue 
and keep socks in waiting list in driver for timeout or something else.

Zoran Vasiljevic wrote:
> 
> Am 06.01.2006 um 16:56 schrieb Vlad Seryakov:
> 
>> I uploaded driver.c into SFE, it needs more testing because after  my 
>> last corrections and cleanups it seems i broke something.
>>
> 
> What is the meaning of:
> 
>                 case SOCK_SPOOL:
>                     if (!SockSpoolPush(sockPtr)) {
>                         sockPtr->nextPtr = readPtr;
>                         readPtr = sockPtr;
>                     }
>                     break;
> 
> The SockSpoolPush() as I see can only return true,
> hence the test is not needed.
> I would rewrite the SockSpoolPush to return void
> and hence:
> 
>                 case SOCK_SPOOL:
>                     SockSpoolPush(sockPtr);
>                     break;
> 
> Or is there any hidden case when SockSpoolPush()
> can fail (I can't see that from the code)?
> 
> Cheers
> Zoran
> 
> 
> -------------------------------------------------------
> This SF.net email is sponsored by: Splunk Inc. Do you grep through log 
> files
> for problems?  Stop!  Download the new AJAX search engine that makes
> searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
> http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click
> _______________________________________________
> naviserver-devel mailing list
> nav...@li...
> https://lists.sourceforge.net/lists/listinfo/naviserver-devel
> 

-- 
Vlad Seryakov
571 262-8608 office
vl...@cr...
http://www.crystalballinc.com/vlad/