Re: [naviserver-devel] Upload Progress

[Zoran V. <zv...@ar...>]

Am 06.01.2006 um 16:56 schrieb Vlad Seryakov:

> I uploaded driver.c into SFE, it needs more testing because after  
> my last corrections and cleanups it seems i broke something.
>

What is the meaning of:

                 case SOCK_SPOOL:
                     if (!SockSpoolPush(sockPtr)) {
                         sockPtr->nextPtr = readPtr;
                         readPtr = sockPtr;
                     }
                     break;

The SockSpoolPush() as I see can only return true,
hence the test is not needed.
I would rewrite the SockSpoolPush to return void
and hence:

                 case SOCK_SPOOL:
                     SockSpoolPush(sockPtr);
                     break;

Or is there any hidden case when SockSpoolPush()
can fail (I can't see that from the code)?

Cheers
Zoran